Code cleanup
Description:
Clean up internals of group creation & iteration code.
Platforms tested:
FreeBSD 4.11 (sleipnir)
Mac OS X (nile)
Too minor to require h5committest
Code cleanup (sorta)
Description:
Adjust H5G_stat_t to prepare for eventual "external link" information.
This also puts the information for regular objects and soft links into more
obviously separate places.
Platforms tested:
FreeBSD 4.11 (sleipnir)
Linux 2.4
minor tidy up.
Description:
Changed both test programs and test scripts to use the same suffixes
(.chkexe and .chklog). Changed from .log to .chklog to avoid running
into potential conflicts by other "things" (e.g., config.log).
Tested:
Heping.
Code cleanup
Description:
Prevent memory leak when too many links are traversed. Also add test to
traverse too many links.
Platforms tested:
FreeBSD 4.11 (sleipnir)
Linux 2.4
Improvement for Windows
Description:
thread number can not be printed out on windows. Add a special
macro for WIN32 to print out some helpful messages
Solution:
Platforms tested:
Heping and MSVS 6.0 on Windows XP
Misc. update:
Code cleanup & speedup
Description:
Refactor h5dump & related code to be considerably cleaner & faster for
files with large #'s of objects.
Platforms tested:
FreeBS 4.11 (sleipnir)
Linux 2.4
Bug fix
Description:
Fix "strong" file closing to handle a dangling dataset which uses a
dangling named datatype.
Platforms tested:
FreeBSD 4.11 (sleipnir)
Too minor too require h5committest
bug fix
Description:
The previous version always tests with mpi-IO driver even when mpi-posix driver is set.
Solution:
Add the option to test mpi-posix driver for the first round collective chunk IO test.
Platforms tested:
IRIX64, AIX 5.1, Linux 2.4
Misc. update:
"bug fix"
Description:
The test_mpio_derived_dtype() often hangs when fails. So it was
not run by default to avoid hanging the daily tests or confusing
users. But then new system or new codes in collective chunk fails
while one can't tell for sure if it is because of the complicated
derived type failures or something else.
Solution:
Changed the logic so it is skipped only if it is known that
the complicated MPI derived type does not work. (This is
indicated by macro H5_MPI_COMPLEX_DERIVED_DATATYPE_WORKS NOT
defined.
Platforms tested:
heping pp (where it is tested by default).
Modi4 pp (where it is SKIPPED by default.)
I also forced modi4 to test it and modi4 said it actually
is working and should change the setting of
H5_MPI_COMPLEX_DERIVED_DATATYPE_WORKS to working?!!
Misc. update:
Code cleaning.
Description:
The block of code that is conditioned by the H5_MPI_COMPLEX_DERIVED_DATATYPE_WORKS
and manipulates the return code of test_mpio_derived_dtype, does not really
belong in main. If return code of test_mpio_derived_dtype needs to be
adjusted, it should be done in test_mpio_derived_dtype.
Solution:
Moved that block of code test_mpio_derived_dtype.
Platforms tested:
heping PP.
Misc. update:
Maintenance on Windows
Description:
Add how to build hdf5 with thread-safe feature on windows into the
document
Solution:
Platforms tested:
Misc. update:
cleanup
Description:
Changed the conditional definitions of HDvsnrintf and HDsnprint be
dependent on TFLOPS being defined so that these are consistent with
the condition in H5.c in which the two functions are coded.
Platforms tested:
heping.
Misc. update:
Maintenance on Windows
Description:
Move Win32 Macros(snprintf and vsnprintf) to the right places
Solution:
Platforms tested:
MSVS 6.0 on Windows XP
heping
Misc. update:
bug fix
Description:
The set of h5diffdebugN macros that printed nothing did not have
the proper number of parameters. Some compilers (gcc) did not
like it.
Solution:
Fixed them to have the matching number of parameters.
Platforms tested:
heping pp (using both mpich-icc and mpich-gcc), modi4 pp.
Code cleanup
Description:
Clean up code somewhat:
- Move from HDmemset() -> H5G_ent_reset() to clear out group entry info
- Simplify H5G_unlink() call
- Use portability macros instead of direct system calls in more places
- Improve readbility by neatening whitespace, etc.
- Move some macros into source code module instead of header files
Platforms tested:
FreeBSD 4.11 (sleipnir)
Linux 2.4
New debugging feature
Description:
Add some code to track where memory from the internal free list allocator
is allocated within the library. It's not quite ready for "prime time" yet,
but it's close enough to be useful.
This is disabled by default and requires the H5FL_TRACK macro in
src/H5FLprivate.h to be uncommented to activate during debugging.
Platforms tested:
FreeBSD 4.11 (sleipnir)
Linux 2.4
Too minor to require full h5committest
Code cleanup
Description:
Clean up unused variables & use portability macros better
Platforms tested:
FreeBSD 4.11 (sleipnir)
Too minor to require h5committest
Bug fix
Description:
Fix core dump when checking whether to invalidate the name of an object
when unlinking an object in a group opened through an object reference.
Solution:
Check if names of various objects are valid before comparing them, etc.
Platforms tested:
FreeBSD 4.11 (sleipnir)
Too minor to require h5committest
Code cleanup/bug fix
Description:
Add missing files to manifest
Remove C++ style single-line comment from recent checkin and also re-indent
in a few places.
Platforms tested:
FreeBSD 4.11 (sleipnir) w/thread-safe
Not configured w/h5committest
Description:
Forgot to modify the examples for the "using" declaration changes
in the library. Added "using" declaration appropriately.
Platforms tested:
Linux 2.4 (heping) - very minor
Improvement on windows
Description:
Add Thread safe project file with pthread-win32 on Windows
Solution:
Platforms tested:
MSVS 6.0 on Windows XP
Misc. update:
Improvement
Description:
ttsafe cancel failed on Windows because pthread mutex and cond are not initialized
Add some assertion statements to locate the errors when they happen
Solution:
Initialize pthread mutex and cond to the default attributes.
Platforms tested:
MSVS 6.0 on windows XP and heping(with pthread)
Misc. update:
Improvement
Description:
Add some assertion statements to locate the errors when they happen
Solution:
Platforms tested:
MSVS 6.0 on windows and heping(with pthread)
Misc. update:
Improvement
Description:
Add some assertion statements to locate the error when errors happen
Solution:
Platforms tested:
MSVS 6.0 on windows XP and heping(enable threadsafe with pthread)
Misc. update:
Add more comments for collective chunk IO supports.
Description:
On some platforms that use mpich library internally, we have no way to check mpich version number. We have to manually turn off the collective IO supports.
One example is Altix(cobalt). Just put a comment there so that we won't forget about this.
Solution:
Platforms tested:
Misc. update:
New feature
Description:
All datasets were 1D only before. Added -g to use 2D datasets such
that it allows more options in testing various access patterns.
Platforms tested:
heping pp.
Misc. update:
Feature and bug patch
Description:
Added the SKIP feature which skips a test.
The latest code will hang the very last test. Skip that test for now.
Platforms tested:
heping pp.
Description: repart_test.c was mistakenly treated as a tool, instead of a test program.
Solution: Took it out of the tool list.
Platforms tested: fuss - simple change.
Bug fix
Description:
ph5diff had been hanging in Tflops. Found out that vsnprintf ph5diff
uses was a local coded that did not limit printing according to the size
argument. That resulted in buffer overflow and other problems.
Solution:
Added some sort of size checking in the home-grown vsnprintf and
had ph5diff checked for error return of vsnprintf. Leon also
revamped the ph5diff manager's way of handling communications with
the workers. That eliminated all but the last case of hanging.
Platforms tested:
Tflops.
Misc. update:
Bug fix.
Description:
Reactivated the code for snprintf and vsnprintf for Tflops but added
the SN_SIZ_MIN as an attempt to require the minimum amount of space needed,
hoping vsnprintf/snprintf do not print larger than it per request.
Also added code to detect overflow and return error (IF overflow has
not crashed the application yet.) These are all short term patches.
Platforms tested:
Tested at Tflops.
Update & feature
Added a new cached data conversion setting.
Added -DH5_FLOPS to CPPFLAGS for compiling. Had used the builtin
__PUMAGON__ but H5_TFLOPS is more meaningful.
Platforms tested:
Tested in Flops.
Misc. update:
Description: In some macro definition, some constant values like D_MIN and D_MAX were
not casted to the destination type. They may cause problems for some system like
TFLOPS.
Solution: Cast them to destination type.
Platforms tested: fuss - very simple changes.
Maintenance on windows
Description:
Add two macros for windows, susbstitue functions HDsnprintf and HDvsnprintf
with _snprintf and _vsnprintf when using Visual C++ on windows
Solution:
Platforms tested:
MSVC 6.0 on Windows XP
heping
Misc. update:
Code cleanup
Description:
Trim trailing whitespace, which is making 'diff'ing the two branches
difficult.
Solution:
Ran this script in each directory:
foreach f (*.[ch] *.cpp)
sed 's/[[:blank:]]*$//' $f > sed.out && mv sed.out $f
end
Platforms tested:
FreeBSD 4.11 (sleipnir)
Too minor to require h5committest
Code cleanup
Description:
Collapse the various tests on groups opened by dereferencing into one test.
Platforms tested:
FreeBSD 4.11 (sleipnir)
Too minor to require h5committest
Code cleanup
Description:
Use enum type instead of int for datatype conversion exception callback
routine.
Platforms tested:
FreeBSD 4.11 (sleipnir)
Too minor to require h5committest
Code cleanup
Description:
Fix logic error in previous checkin and also finish refactoring I/O
initialization, including simplifying all the collective & parallel cases
into a more unified mechanism.
Platforms tested:
FreeBSD 4.11 (sleipnir) w/ & w/o parallel
Linux 2.4 (mir)