Update
Description:
Replaced
#include <hdf5_file.h>
with
#include "hdf5_file.h"
so that gcc can pick up our files more easily without picking up
system header files (which we don't care about being in the
dependencies list).
Platforms tested:
Linux
Update
Description:
Replaced "#include <hdf5_file.h>" with the equivalent, but better
#include "hdf5_file.h" so that gcc can pick up our header files more
easily.
Platforms tested:
Linux
Bug Fix
Description:
We shouldn't create Makefiles in the testpar/ directory unless we're
building this as parallel.
Solution:
Put flag in there specifying that we're doing this in Parallel and we
should build the Makefile in testpar/.
Portability tweaks
Description:
Certain features (signal for FPE, some assertions, etc) used in testing
are not available in certain non-UNIX platforms.
Solution:
Ifdef'd out the test code on the platforms which don't have that support.
Platforms tested:
FreeBSD 4.3 (hawkwind)
Code tweak
Description:
Large data arrays were being created on the stack.
Solution:
Hoisted the data variables out of the function(s) and make into static
variables.
Platforms tested:
FreeBSD 4.3 (hawkwind)
Code Tweaks
Description:
"FILE" macro for file names was getting confused with Standard C __FILE__
macro on certain platforms.
Solution:
Changed "FILE" macro usage to "DATAFILE"
Platforms tested:
FreeBSD 4.3 (hawkwind)
Code cleanup
Description:
Code had ifdef's instead of using standard macro wrappers for getpid()
call.
Solution:
Took out ifdef's and changed to use standard H5getpid() macro.
Platforms tested:
FreeBSD 4.3 (hawkwind)
Code cleanup
Description:
Defined snprintf macro for non-UNIX platform which needed tweak.
Solution:
Added extra ifdef around snprintf macro to accomodate platform.
Platforms tested:
FreeBSD 4.3 (hawkwind)
Code cleanup
Description:
ssize_t is not defined on certain (non-UNIX) platforms.
Solution:
Added steps to configure to generate SIZEOF_SSIZE_T macro and then used
the new macro to define ssize_t for platforms which don't have it.
Platforms tested:
FreeBSD 4.3 (hawkwind)
Improvment
Description:
H5config.h and H5pubconf.h are generated by configure. It does
not have the #ifndef _H5config_H ... #endif guard to prevent
duplicated definitions if it is included more than once.
It is messy to try make configure to put in those guards.
Solution:
HDF5 has set an internal rule that H5public.h includes H5pubconf.h
and H5private.h includes H5config.h. Source files should NOT include
H5config.h or H5pubconf.h directly but include it via H5public.h or
H5private.h respectively. The #ifndef ... #endif in the H5public.h
and H5private.h would prevent repeated definitions from repeated
include.
Adjusted H5FDstream.c and H5FDstream.h to follow this rule.
Platforms tested:
modi4, eirene.
Bug Fix
Description:
If the user specifies where to look for a library (like the zlib) on
the commandline, then we add that directory to the LDFLAGS macro.
Solution:
Copied the code which checks for this from the C configure.in. Also
added code which checks for the --with-zlib flag since that wasn't in
there.
Platforms tested:
Linux
Purpose:
a bug fix
Description:
when creating sds dimensional scale dataset, I accidently created two sds dimensional scale dataset with the same name, (say using name "dim1" for both rank 2 and rank 3).
hdf4 library doesn't give me complaints, hdp dumpsds doesn't generate complaints. h4toh5 converter since assumed that dimensional scale name has to be unique, simply skip if finding the same dimensional name, so accidently the result from hdp dumpsds are the same as the result from h5dump until I implement library API and find this bug.
Solution:
make unique sds dimensional scale name for this test file. Will also need to modify testfiles later.
suggestions: somebody check hdf4 library to disallow the same dimensional scale nameOused for the same sds object.
Platforms tested:
eirene, and this check in will not affect daily test.
Purpose:
update install document for windows
Description:
If user wants to remove zlib, they have to remove two lines that define
H5_HAVE_LIBZ and H5_HAVE_COMPRESS2 in both H5config.h and *H5pubconf.h*.
Solution:
add "H5pubconf.h" in the document
Platforms tested:
new test
Description:
Added two new tests.
test_mpio_offset:
Verify that MPI_Offset exceeding 2**31 can be computed correctly.
test_mpio_gb_file
Test if MPIO can write file from under 2GB to over 2GB and then
from under 4GB to over 4GB.
Platforms tested:
modi4(-64), tflops.
Update
Description:
Remove the doc from the SUBDIRS macro since we don't have to go to
that directory for all make options. Add doc to the "cleaning"
actions...
Platforms tested:
Linux
Description:
dsets.cpp:
- Added routine's headers to be consistent with the C tests
- Added the following tests (they are not in the C version
test because they are C++ specific):
+ Test copying a user-defined type using DataType::copy
+ Test copying a user-defined type using DataType::operator=
+ Test copying a user-defined int type using DataType::operator=
+ Test copying an integer predefined type using a constructor
+ Test copying an integer predefined type using DataType::operator=
th5s.cpp:
- Added routine's headers to be consistent with the C tests
- Cleanup old couts and statements used during debugging
Platforms tested:
arabica (sparc-sun-solaris 2.7)
Description and Solution:
- Predefined type objects become outdated when the application calls
H5close and then H5open to use the library again.
Solution:
+ Reimplemented PredType using enum type to obtain up-to-date
values for predefined types, i.e. H5T_xxx_yyy's, when they
are used.
+ Added to PredType its own version of getId() to return the
appropriate predefined type id according to the enum value.
+ Made IdComponent::getId() a virtual function
- Since Albert already fixed the "multiply defined RcsId" problem,
removed the now become unnessary "#undef RCSID" from H5Include.h
- Added a check for func_name != NULL in one of the Exception
constructors because seg. fault. might occur in some situations.
- It is more convenient to make a copy of a datatype, dataspace,
or property list by using assignment operator
Solution:
+ Added assignment operator to DataType, DataSpace, and
PropList so that they will invoke H5Tcopy, H5Scopy,
and H5Pcopy, respectively, instead of just simply
copying the data members as for other classes. So,
now a type, space, or property list can be copied by
either :
mytype = original_type, or
mytype.copy(original_type)
Note that copy constructors are still just copying the
data members.
+ Added an assignment operator to DataType that takes a
predefined type.
+ Made IdComponent::operator= a virtual function
Platforms tested:
arabica (sparc-sun-solaris 2.7)
Bug Fix
Description:
Create a Makefile in the testpar/ directory only if PARALLEL is
enabled.
Solution:
Set a macro to the testpar/Makefile for the generation script.
Update
Description:
Applied fix to h5dumper which was applied to the 1.4 branch. Done
just before creating subdirectories in the 1.4 branch.
Platforms tested:
Linux
Updated
Description:
Updated test results for the h5dumper's XML option. The tool now
conforms with the fixes implemented in the 1.4 branch.
Platforms tested:
Linux
Bug fix (sort of)
Description:
The RCSID string in H5public.h was causing the C++ code problem as it
was included multiple times and C++ did not like multiple definitions
of the same static variable.
Solution:
Since we don't really make use of the RCSID strings as we have not
installed it in all source files, we decided to remove it.
Platforms tested:
eirene (linux), modi4 (IRIX64-64) both serial and parallel modes.
Improvement
Description:
Changed the default value of $NPROCS from 2 to 3. This is the
value libSAF uses since 3 processes have a much bigger chance
catching parallel errors than just 2 processes.
Changed the default dataset sizes from 800 to 1200 so that it is
a multiple for 3 (and 8 too which is ofter used in the Tflops test.)
Platforms tested:
Modi4 (IRIX64) both serial and parallel modes.
Improvement
Description:
Changed the default value of $NPROCS from 2 to 3. This is the
value libSAF uses since 3 processes have a much bigger chance
catching parallel errors than just 2 processes.
Platforms tested:
Modi4 (IRIX64) both serial and parallel modes.
adjustment
Description:
When gondolin failed the 1.5 test, it moved ahead for the 1.4 test.
The 1.5 test usually takes 1 hour to complete but runtest only waited
30 minutes for the 1.4 cvs update to complete. So, gondolin ended
up failing the 1.4 test too.
Solution:
Changed the wait time to 90 minutes.
Added echo statements showing it is waiting for some event. This
would help the human knowing it is waiting for something.
Added more comments about the algorithm of the waiting.
Platforms tested:
Gotta be right. :-)
Bug Fix
Description:
Partial hyperslabs which exactly fit the size of the lowest dimension of
a chunked dataset weren't being output correctly.
Solution:
Forgot to divide the offset (seq_len) by the size of the lower dimension
hyperslabs - fixed now.
Platforms tested:
FreeBSD 4.2 (hawkwind)
Code cleanup
Description:
Binh-Minh found several places where parameters and/or return-values in the
tests were not matching the current parameters for functions in the library.
Solution:
Walked through the code and aligned the parameters and return-values with
the current functions.
Platforms tested:
FreeBSD 4.2 (hawkwind)
Purpose:
Maintenance
Description:
[describe the bug, or describe the new feature, etc]
Solution:
Added comment block to each subroutine.
Platforms tested:
NONE, do it later.
Purpose:
[is this a bug fix? feature? ...]
Description:
[describe the bug, or describe the new feature, etc]
Solution:
[details about the changes, algorithm, etc...]
[Please as detail as you can since your own explanation is
better than others guessing it from the code.]
Platforms tested:
[machines you have tested the changed version. This is absolute
important. Test it out on at least two or three different platforms
such as Big-endian-32bit (SUN/IRIX), little-endian-32(LINUX) and
64-bit (IRIX64/UNICOS/DEC-ALPHA) would be good.]
Purpose:
Windows port and maintenance
Description:
Each C function called from F90 subroutine requires explicit
interface. Some drivers functions were not implemented.
Solution:
Added interfaces and comment blocks to each F90 subroutine.
Added the following subroutines:
h5pset(get)_fapl_core_f
h5pset(get)_fapl_family_f
h5pset_fapl_sec2_f
h5pset_fapl_stdio_f
Platforms tested:
Linux (eirene) to make sure that code still works on UNIX.
More UNIX platforms will be tested before moving to Windows.
Feature Add
Description:
This is the first (alpha) version of h5tools which does subsetting
according to the subsetting document. There's still some niceties
which need to be worked out, but this is the ground work.
Platforms tested:
Linux
Bug Fix
Description:
Some of the modules weren't being compiled cause they weren't added
to the TEST_OBJ macro.
Solution:
Added them to the TEST_OBJ macro a la the C tests.
Platforms tested:
Linux
Bug Fix
Description:
For some reason, the H5FDstream.h file was defined not once, not
twice, but three whole times in the install part...
Solution:
Removed all but one of those.
Purpose:
Adding data file for testing
Description:
The dataspace test, th5s.cpp, needs this data file.
Solution:
Added the file, using the copy of hdf5/test/th5s.h5
Platforms:
arabica (sparc-sun-solaris 2.7)
Bug Fix
Description:
On the Nersc machines, the install-sh script wasn't being found in
the proper place.
Solution:
Corrected the "fix" I put in there awhile ago. Essentially, if the
INSTALL macro is the program "install-sh" with anything around it,
then we assume they want our install-sh program and force the
Makefiles to find it in the hdf5/bin directory.
Platforms tested:
Nersc.
Purpose:
1) warning eliminatation
2) windows projects rearranging fit for the reorientation of various tools under
/hdf5/tools directory in the cvs tree
Description:
1) fix the long time repetative warnings of
"LINK : warning LNK4098: defaultlib "LIBC" conflicts with use of other libs; use /NODEFAULTLIB:library"
2) fixing h4toh5testrun.bat and dumptest.bat so that new h5dump-xml can be run on windows and new
h4toh5 test files
3) adding h4toh5test.dsp project
Solution:
Platforms tested:
windows 2000
Purpose:
Improve C++ API test output appearance
Description:
The C++ API tests are not easy to be spotted because their output
look similar to part of the C tests.
Solution:
Added "C++ API:" in front of the C++ test titles.
Platforms tested:
arabica (sparc-sun-solaris 2.7)
Bug Fix.
Description:
Kent is correct about the malloc error. It's harmless if it's not
needed anyway.
Solution:
Removed the #ifdef's since all platforms should use this.
Platforms tested:
Linux
Purpose:
fixing the format of dumper output for windows test
Description:
New dumptest includes the feature that an error of the output will be put into stderr in linux
On windows, that stderr will not be redirected into the output file and the comparsion between the expected file and the dumper output is not correct.
Solution:
change fprintf(stderr .....) at h5tool_util.c into fprintf(stdout ......) so that it fits the comparison.
Platforms tested:
windows 2000
Purpose:
a bug fix on windows(possible on other platforms)
Description:
not allocating enough space for a string at dump_all for debug version
a string tmp is defined at dump_all(....),
The memory that is allocated to tmp is malloc(strlen(prefix)+strlen(name)+1);
However, there is one testing case : strlen(prefix) is 0 and
tmp is allocated in the following:
strcat(tmp,"/");
strcat(tmp,name);
....
free(tmp);
the program fails when freeing tmp for debug (dll) version on windows 2000
Solution:
For windows platform:
allocate memory strlen(prefix)+strlen(name)+2
Platforms tested:
[machines you have tested the changed version. This is absolute
important. Test it out on at least two or three different platforms
such as Big-endian-32bit (SUN/IRIX), little-endian-32(LINUX) and
64-bit (IRIX64/UNICOS/DEC-ALPHA) would be good.]
