Commit Graph

22114 Commits

Author SHA1 Message Date
vchoi-hdfgroup
c835d16a59
Remove superfluous dot from hl doxygen. (#1891)
Co-authored-by: vchoi <vchoi@jelly.ad.hdfgroup.org>
2022-07-14 09:32:09 -07:00
Allen Byrne
385ae6ac5b
Eliminate unnecessary error output (#1879)
* Eliminate unnecessary error output

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-07-14 09:07:53 -07:00
Dana Robinson
b0d9fa058a
Fix for a tools compile issue when deprecated symbols are disabled (#1884)
* Fix for a tools compile issue when deprecated symbols are disabled

Introduced in #1811, also uses VOL token instead of addr

* Fix for similar compile issues in java when deprecated symbols are
disabled.

* Committing clang-format changes

Co-authored-by: Larry Knox <lrknox@hdfgroup.org>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-07-13 08:53:00 -07:00
raylu-hdf
b2363a8195
H5Oflush fails for parallel (#1876)
* H5Oflush causes H5Fclose to trigger an assertion failure in metadata cache for parallel.  This commit makes sure H5Oflush fails for parallel until this problem is solved in the future.

* Committing clang-format changes

* Changed the use of H5F_get_driver_id to H5F_HAS_FEATURE.

Co-authored-by: songyulu <songyulu@jelly.ad.hdfgroup.org>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-07-12 08:55:34 -07:00
Dana Robinson
c62b026609
Moves -Wstrict-overflow=5 to the developer warnings (#1878) 2022-07-11 18:25:57 -07:00
Dana Robinson
af014fa61c
Removes definitions for (U)LLONG_MAX and (S)SIZET_MAX (#1877)
LLONG_MAX and ULLONG_MAX are defined in limits.h in C99. SIZET_MAX
should be SIZE_MAX, which has been around forever. SSIZET_MAX should
be SSIZE_MAX, which is defined whereever ssize_t is found. I've kept
the definition for SSIZE_MAX (renamed from SSIZET_MAX) for platforms
where ssize_T is not present (e.g., Windows).
2022-07-11 15:48:51 -07:00
Dana Robinson
dae6064103
Fixes for warnings identified by MSVC (#1874)
* Fixes for warnings identified by MSVC

* Committing clang-format changes

* Moves the casts in H5Binternal.c to the other side

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-07-11 14:01:08 -07:00
Allen Byrne
b9d1d66ab8
Develop HDFFV-11310 (#1811)
* Rework java vl check in read/write. Handle old refs in h5dump

* Committing clang-format changes

* Java changes allow default VL reads

* Fix JNI utility for old refs

* HDFFV-11310 - implement vlen read/write for atomic types.

* format check fix

* Mostly format fixes

* More format issues

* Two format changes

* Use JNI names for sizeof

* format change

* fix size typo

* Change to older method to initialize list

* remove unused var

* format fix

* switch writeVL functions to use datatype instead of java type

* Add VL option to generic read/write check

* Correct function name typo

* Add JIRA issue

* Correct note to match change in code.

* HDFFV-11318 add VL references as byte arrays

* Add release note and format changes

* Another format update

* Fix unreleased allocations

* Fix format

* format correction

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-07-11 13:59:52 -07:00
Houjun Tang
663321087a
Support for UnifyFS with MPI_File_sync (#1801)
* Initial implementation for supporting UnifyFS in HDF5 with MPI_File_sync after write

* Committing clang-format changes

* Fix format

* Fix env variable and return value check

* Fix flag retrieve

* Fix issues with getting/setting the flag

* Fix merge conflicts

* Update

* Committing clang-format changes

* Update based on suggestions

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-07-11 13:59:19 -07:00
Dana Robinson
63ce6839b5
Reduce -Wstrict-overflow= from 5 to 2 (#1872)
The signal-to-noise ratio of the higher warning level is very low
and the noise obscures things we should fix
2022-07-11 11:26:03 -07:00
Dana Robinson
e269f90364
Misc clang warning fixes (#1869)
* Minor clang warning fixes in src and test

* Fixes clang warnings in high-level library

* clang format-nonliteral warning fixes

* Committing clang-format changes

* Fixed int -> float clang cast warnings in h5diff

* Quiets some warnings in flex/bison generated code

* Suppress overlong string warning for libinfo on clang

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-07-11 10:28:02 -07:00
Dana Robinson
0412d3f292
Fixes for production mode gcc warnings (#1873)
* Fixes for production mode gcc warnings

With the strict-overflow changes, this brings the number of warnings
in the C library w/ gcc 12 to zero.

* Fix typo

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-07-11 10:27:40 -07:00
Dana Robinson
fa7caf8435
Fixes C++ sign-conversion warnings w/ clang 14 (#1870)
* Fixes sign-conversion warnings w/ clang 14

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-07-11 08:59:51 -07:00
Dana Robinson
f599e2ac7f
Adds the mirror and direct VFDs to GitHub actions (#1871)
Both Autotools and CMake
2022-07-11 08:58:06 -07:00
Dana Robinson
460ee73a64
Adds format attribute to additional functions (#1868)
* Adds format attribute to (s|p)io_perf code

* Added gcc format attribute to additional test code

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-07-11 08:29:46 -07:00
Dana Robinson
be5de999a9
Adds explicit indices to drivernames array in the tools (#1867)
Will help keep the drivernames and driver_idx enum in sync.
2022-07-11 08:28:52 -07:00
Dana Robinson
e0c2443179
Adds the malloc attribute to appropriate functions (gcc only) (#1866) 2022-07-11 08:27:44 -07:00
Dana Robinson
ff089f8e36
Updates the patterns in Doxyfile.in to accept H5*develop.h (#1865) 2022-07-11 06:35:46 -07:00
Gerd Heber
7e1bde1cb5
Merge pull request #1857 from gheber/fix-doxy-warnings-and-cosmetics
Fix Doxygen warnings and cosmetics
2022-07-08 20:16:43 -05:00
jhendersonHDF
aa688c68c4
Convert assertion on (possibly corrupt) file contents to normal error check (#1861)
* Convert assertion on (possibly corrupt) file contents to normal error check

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-07-08 13:04:23 -07:00
Dana Robinson
a45ade8886
Fix for memory allocation issue identified by fuzzer (#732) (#1860)
GitHub issue #732 claims that mallocing a particular buffer can
trigger undefined behavior and that callocing the buffer fixes
the issue.

I did not confirm this, but the fix is trivial and better anyway.
2022-07-08 12:10:29 -07:00
Gerd Heber
6bc41fb11c
Resolve Allen's comment. 2022-07-08 12:48:48 -05:00
Gerd Heber
74c80f0bbf
Fix Doxygen warnings 2022-07-08 06:08:46 -05:00
Gerd Heber
52d6626254
Cosmetic changes to RM front 2022-07-08 06:06:47 -05:00
Gerd Heber
fe413fc6ff
Updated vfd swmr and reference rfcs (#1854)
* Add PDFs

* Update RFC table
2022-07-07 15:59:48 -07:00
Dana Robinson
0c0d3bf736
Suppress the "obsolete" category of Autoconf warnings (#1853)
Very new versions of Autoconf complain about our Java macros. Since they
work well enough and there is no obvious upgrade path, we're suppressing
the category for now.
2022-07-06 14:56:26 -07:00
Dana Robinson
424bbd16eb
Updates messages in cache sanity checks (#1851)
Previous messages were numbered, which was a maintenance burden,
and non-specific
2022-07-06 13:12:48 -07:00
Dana Robinson
a7f1ce46b9
Minor tweaks to the test_swmr.sh script (#1852) 2022-07-06 13:12:31 -07:00
Gerd Heber
9cd0d042f0
Update Doxyfile.in (#1849) 2022-07-06 13:01:36 -07:00
jhendersonHDF
8937054d5a
Fix invalid comment about character encoding in H5Fint.c (#1845) 2022-07-01 15:49:23 -07:00
Dana Robinson
6aa7aeeda4
Fixes a bug in h5perf that causes file open failures (#1846)
When the filename was flipped from being a static array to being
dynamically allocated, the sizeof(filename) call wasn't updated.
This always returns the size of the pointer, truncating the
filename.
2022-07-01 12:53:45 -07:00
vchoi-hdfgroup
9e97a22b8b
Add doxygen for high level modules. (#1839)
* Add doxygen for high level modules.

* Committing clang-format changes

* Correct spelling based on spelling check.

* Committing clang-format changes

Co-authored-by: vchoi <vchoi@jelly.ad.hdfgroup.org>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-07-01 08:42:15 -07:00
Dana Robinson
3ed53d17fb
Removes workaround for platforms that lack C99 stuct initializers (#1842) 2022-06-30 19:50:42 -07:00
Dana Robinson
41526f68f3
Adds a -Werror debug Autotools test and updates build modes (#1833)
* Adds a -Werror debug Autotools test and updates build modes

* Un-excludes the workflow files

* Strip out -Werror from CFLAGS when running configure tests

This causes spurious test failures when the configuration test
programs raise warnings.
2022-06-30 15:38:18 -07:00
Dana Robinson
015240e790
Minor configure comment tweaks from autoupdate (#1838)
The autoupdate script identified some cruft that was unchanged
in the comments
2022-06-30 12:26:38 -07:00
Dana Robinson
552833213c
Fix for gcc-12 warning about string truncation in H5Opline.c (#1835) 2022-06-30 07:47:34 -07:00
Dana Robinson
72db748dd9
Updates the MinGW configure.ac check for the Winsock library (#1837)
Ubuntu 22.04 complains about AC_HAVE_LIBRARY being deprecated. This
updates the macro to AC_CHECK_LIB, where the specified function
is GetUserName().

This change only affects MinGW
2022-06-30 06:59:03 -07:00
Dana Robinson
89fae896ae
Set Autotools build mode correctly in GitHub workflows (#1834)
* Sets build mode correctly w/ Autotools

* Updates GitHub gcc and installs OpenMPI
2022-06-30 06:58:37 -07:00
Dana Robinson
03ed7a3d79
Fixes a few minor parallel warnings (#1832) 2022-06-29 13:02:38 -07:00
Scot Breitenfeld
cb424b2c45
remove superfluous initialization, fixes issue with Cray compiler (Crusher) (#1828) 2022-06-29 10:44:21 -05:00
Dana Robinson
9e00089307
Quiets const warnings (#1831) 2022-06-29 10:41:45 -05:00
Dana Robinson
57a850f897
Documents Windows badness in H5Pget_external() (#1821)
* Documents Windows badness in H5Pget_external()

* Added a cast for off_t
2022-06-24 06:14:29 -07:00
Dana Robinson
249008d4ce
Converts testhdf5 macros to h5test macros in chunk_info.c (#1820)
The two macro schemes were not designed to work together. Also
quiets some MSVC warnings about comparing pointers and integers.
2022-06-23 09:11:30 -07:00
Dana Robinson
1a0fe1f6b7
Set a constant in H5SM to UINT_MAX instead of -1U (#1822) 2022-06-23 09:11:04 -07:00
Dana Robinson
896304d2da
Work-around for MSVC issue with flex-generated code (#1823) 2022-06-23 07:45:47 -07:00
Dana Robinson
9e55d51f46
Quiets size warning in large library setting string (#1818)
* Quiets size warning in large library setting string

If the size of this string is a problem, people can build with the
embedded library info disabled.

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-06-22 12:44:34 -07:00
Sean McBride
c064d3481b
sprintf to snprintf (#1815)
* Straightforward conversion of sprintf to the safer snprintf

* Trickier conversion of sprintf to safer snprintf

This involved minor changes to private function signatures to take the size of the buffer.

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-06-22 11:58:18 -07:00
Dana Robinson
d6f05069c1
Adds notes about off_t sizes on Windows (#1817) 2022-06-22 11:21:51 -07:00
Dana Robinson
8bfed8aae4
Converts __int64 to LONGLONG in LARGE_INTEGER union members on Windows (#1816) 2022-06-22 10:48:51 -07:00
Sean McBride
8b2e7b32b5
Various warning fixes (#1812)
* Fixed -Wreserved-id-macro warnings from header include guards

* Removed all __int64 and LL suffix stuff now that C99 is minimum requirement

* Rename `H5FD_CTL__` to `H5FD_CTL_` to fix -Wreserved-id-macro warnings

Double underscore is reserved in C++ and this public header should be C++ compatible.

* Never define __STDC_FORMAT_MACROS anymore

Defining it causes a -Wreserved-id-macro.

Happily, according to the C++11 standard:

"The macros defined by <stdint> are provided unconditionally. In particular, the symbols __STDC_LIMIT_MACROS and __STDC_CONSTANT_MACROS (mentioned in C99 footnotes 219, 220, and 222) play no role in C++."

https://cplusplus.github.io/LWG/issue984

So looks like it's not necessary to define it with reasonably new toolchains.

* Fixed some -Wunused-macros warnings, removed dead code

* Fixed all -Wdouble-promotion warnings in C++ files

* Fixed remaining -Wsuggest-destructor-override warnings

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-06-22 09:16:30 -07:00