Bug Fix.
Description:
Attributes whose datatype was an object or dataset region reference weren't
dumping correctly.
Solution:
Pass along attribute ID to the code which prints the attributes, so the
reference types can be dereferenced and printed.
Platforms tested:
FreeBSD 4.2 (hawkwind) & IRIX64 6.5 (modi4)
Improvement
Description:
During configure, it tries to find the size of various basic
C data types (int, int8, fast_int8, ...) by running a small
program for each data type. But Pecific blue uses a batch queue
system to launch all jobs and the whole process takes couple
minutes. With over 20 basic types to test, that takes "forever"
for the configure to complete.
Solution:
Let the configure complete, then save all those valid values in
the config.cache file into the specific config file for Pac. Blue.
With the values cached, configure does not need to run those little
problems.
Platform Tested:
Pacific blue with mpicc.
Bug fix.
Description:
Cray T3E (and J90?) was failing on partial I/O tests. The bug was in
the optimized hyperslab routines for cases where a hyperslab filled the
temporary datatype conversion buffer and the optimized hyperslab routine
needed to start in the middle of a hyperslab.
Solution:
Corrected code to detect the situation and read in the correct amount of
elements in the hyperslab.
Platforms tested:
Cray T3E (mcurie.nersc.gov)
Purpose:
Bugfix
Description:
The gcc linker couldn't resolve any socket routine symbols
if the Stream VFD was configure.
Solution:
Add the socket library to the LIBS makefile variable not just
when compiling with the native cc compiler
but also if using GNU tools (such as on Solaris x86 systems).
Platforms tested:
SunOS 5.5 with GNU cc (hatteras),
SunOS 5.6 with native cc (thor.sistec.kp.dlr.de)
Purpose:
Bugfix
Description:
Under SunOS 5.5 the symbol FIONBIO wasn't known.
Solution:
Include <sys/filio.h> which defines this symbol under Solaris.
Also put the UNUSED qualifier in the right place in a function
argument list (gcc 2.7.2 didn't like it before the type name).
Platforms tested:
SunOS 5.5 (hatteras), SunOS 5.6 t(thor.sistec.kp.dlr.de)
Purpose:
Bugfix
Description:
Under SunOS 5.5 the symbol FIONBIO wasn't known when compiling
with the Stream VFD configured.
Solution:
This symbol is defined in the system header file <sys/filio.h>.
Here we check whether this header is available.
Platforms tested:
SunOS 5.5 (hatteras), SunOS 5.6 (thor.sistec.kp.dlr.de)
Purpose:
Bug fix on T3E.
Description:
There was a typo in the h5init_types_c name translation line that
caused compilation errors.
Solution:
Fixed the typo. This fix exposes another error and I have no clue what to
do about this one
f90 -p. -p../src -dp -o fortranlib_test fortranlib_test.o hdf5test.o tH5F.o tH5D.o tH5R.o tH5S.o tH5T.o tH5Sselect.o tH5P.o tH5A.o tH5I.o tH5G.o ../src/.libs/libhdf5_fortran.a ../../src/.libs/libhdf5.a -L/u3/epourmal/HDF4/NewHDF/lib -lmfhdf -ldf -ljpeg -lz -lnsl -lm
cld-405 cld: WARNING
The entry point `HDF5' defined in relocatable object `../src/.libs/libhdf5_fortran.a[HDF5.o:HDF5]' is used; the definition in relocatable object `./../src/HDF5.o:HDF5' is ignored.
cld-431 cld: WARNING
The resulting output file `fortranlib_test' is not executable because of previous WARNING messages.
Make: "../../libtool --mode=link f90 -p. -p../src -dp -o fortranlib_test fortranlib_test.lo hdf5test.lo tH5F.lo tH5D.lo tH5R.lo tH5S.lo tH5T.lo tH5Sselect.lo tH5P.lo tH5A.lo tH5I.lo tH5G.lo ../src/libhdf5_fortran.la ../../src/libhdf5.la": Error code 1
cmd-2436 make: Stop.
+ exit 1
Make: "set -x; for d in src test examples; do \
(cd $d && make tests) || exit 1; \
done": Error code 1
Platforms tested:
T3E
Bug Fix
Description:
We were not propagating the FFLAGS macro. I.e., we were
overwriting it after it was set in the commence.in includes.
Solution:
Include it with a ``@FFLAGS@'' where we'd normally overwrite it
so that it isn't.
Platforms tested:
T3E
Attempted Bug Fix
Description:
Some machines (Cray T3E, need you ask?) use the ``-p'' flag for
enabling double precision. This breaks our Fortran interface.
Solution:
Put this test last. However, the T3E apparently doesn't need
modules, so we may have to resort to a better "fix" than this
in the future.
Platforms tested:
T3E
YABF
Description:
Needed to add the source directory for the built HDF5 library.
Solution:
Added -I../../src to the compile flags.
Platforms tested:
Linux
Bug fix
Description:
When building in a different directory, we weren't picking up the
header files correctly. The -I flag wasn't pointing to the
correct place.
Solution:
Changed the -I flag to point to the C++ source directory.
Platforms tested:
Linux
Reversal of Patch
Description:
I thought that the solaris boxen could handle the -Wc,<flag> flag
(or, rather, that libtool would do the correct thing with their
compilers). However, this isn't the case, apparently.
Solution:
Removed the ``-Wc,-LANG:std'' flag and put it in the CPPFLAGS
macro instead. This should cause it to be passed to the compiler
only...one hopes...
Following up on added tests.
Description:
Added the code to generate the vldata and array test files added into
the h5dump test suite recently. This doesn't have any affect on the
library or tools, it's just for future reference.
Platforms tested:
FreeBSD 4.2 (hawkwind)
Bug Fix
Description:
configure on Cray T3E is looking for a differently named config file,
so at it under that name.
Platforms tested:
Cray T3E (mcurie)
Bug fix
Description:
Compiler on Cray T3E has a weird problem with operations on size_t
variables.
Solution:
Change comparison to make Cray T3E happy.
Platforms tested:
Cray T3E (mcurie)
Buglet
Description:
If we compiled with -all-static, then the compiler could complain
about not being able to find dlopen and friends.
Solution:
Used the ``-dlopen self'' libtool command.
Platforms tested:
Linux
Bug-ish fix
Description:
Spurious warnings would show up if libtool was trying to pass the
-LANG:std flag to the compile line.
Also, if the library is compiled with -all-static, then it would
complain about not finding dlopen and friends.
Solution:
Used the libtool -Wc,<flag> option to pass the -LANG:std flag to
the compile line.
Used ``-dlopen self'' when compiling.
Platforms tested:
Linux
Purpose:
Bug fix
Description:
hdf5 1.4.0_beta1 build failed for Fortran test tH5T.f90 because
third argument of the h5tarray_create_f subroutine had INTEGER(SIZE_T)
type instead of INTEGER(HSIZE_T) type.
Solution:
Fixed the datatype.
Platforms tested:
Linux (eirene)
Major Hack (tm)
NOTE! When upgrading ltconfig in the future, this may have to be
re-fixed!!!
Description:
Pacific Blue didn't like the ``-b nolibpath -b libpath:...''
flags libtool was handing it. It looks as if those flags would
make mpicc forget where some of the libraries it needed were.
Solution:
Test the hostname to determine if we're at pacific.llnl.gov. If
so, then we don't want those flags.
Platforms tested:
Pacific Blue...
Purpose:
Bug fix.
Description:
H5f90global.f90:
One of the common block arrays (floating_types) had a typo in the name.
DEC compiler was the only compiler to warn about the problem.
H5Ff.f90
Compiler gave warnings about a variable that was used before its value was defined.
Fixed. Turned to be a typo in a variable name.
Platforms tested:
DEC UNIX (gondolin)
Purpose:
Bug fix
Description:
Test program was using h5init_types_f and h5close_type_f
instead of h5open_f and h5close_f. Would not compile on modi4.
Solution:
Fixed the code to use new functions.
Platforms tested:
O2K (modi4)
Purpose:
Bug fix
Description:
h5gget_linkval_f function had an argument with the type INTEGER instead
on INTEGER(SIZE_T). Test would not compile on O2K.
Solution:
Fixed argument datatype.
Platforms tested:
O2K (modi4)
Purpose:
Bug fix
Description:
Functions were using flags that were not defined anymore.
Somehow I forgot to check this file in when I modified code
to use run-time generated flags.
Platforms tested:
O2K (modi4)
Bug Fix
Description:
Some platforms don't have support for dlopen and friends when the
library is static.
Solution:
This is part of the attempt to correct this "feature". libtool
wants AC_LIBTOOL_DLOPEN in the configure.in file and -dlopen on
this line...
Platforms tested:
(untested)
Bug Fix
Description:
Some platforms, when building static libraries, complain that
libc doesn't have dlopen and friends.
Solution:
libtool supports workarounds for this. The one used here may not
work, but it's an attempt to correct it. If it doesn't work, then
there's something going on which I'm not privvy to...
Platforms tested:
(untested as of yet)
Bug Fix
Description:
T3E and J90 were complaining about not being able to make for
ADD_PARALLEL_FILES.
Solution:
Somehow the make on these machines must have been weirded out by
the funky pattern matching/replacement that's being done and
couldn't handle a null macro. I now assign "no" to the macro
explicitly
Platforms tested:
T3E
Bug fix
Description:
"UNUSED" macro was in wrong place for older versions of gcc
Solution:
Moved the "UNUSED" macro to the right of the H5FD_t type declaration and
the compiler was happy...
Platforms tested:
Solaris X86 2.5 (hatteras)
Purpose:
update proper settings for windows
Description:
update toolslibD setting from single-thread to Multithread
update dumptest.bat to include array data type and variable length type.
Solution:
Platforms tested:
windows NT 4.0,5.0
Purpose:
fix a bug
Description:
add <windows.h> for WIN32
Solution:
Add the following lines at the beginning of the file
#ifdef WIN32
#include <windows.h>
#endif
Platforms tested:
NT4.0,5.0, and LINUX
Purpose:
bug fix (zeroing memory for memory allocating for the name of dimensional list)
Description:
At modi4, test failed due to garbage read for name of dimensional list.
Solution:
zeroing out memory before writing the name.
Platforms tested:
modi4, eirene(Linux)
Code addition
Description:
The dumper needs to know when a datatype needs to be reclaimed, so I
added a small helper function to detect if a particular datatype is or
contains a particular class of datatypes.
Platforms tested:
Linux 2.2.16-3smp (eirene)
Patch on the patch of my code cleanup... :-)
Description:
Fix compiler problems with previous code patching...
Platforms tested:
Linux 2.2.16-3smp (eirene)
Bug fix
Description:
Had incorrect logic in testing for file families when v1.2 compatibility
was enabled..
Solution:
Corrected to match non-compatibility code.
Platforms tested:
Linux 2.2.16-3smp (eirene)
Code cleanup/bug fix
Description:
Variable length datatypes were leaking memory when being dumped.
Solution:
Reclaim the VL data after each element has been dumped out.
Platforms tested:
FreeBSD 4.2 (hawkwind) & Solaris 2.6 (baldric)
Re-enabling features.
Description:
Re-add the tests which had been core-dumping on a couple of platforms, now
that the underlying bug is fixed.
Platforms tested:
FreeBSD 4.2 (hawkwind) & Solaris 2.6 (baldric)
