Commit Graph

20614 Commits

Author SHA1 Message Date
David Young
a5f236e83b Reduce casts of HDcalloc()/HDmalloc() that -Wc++-compat required.
Reduce gratuitous casts---e.g., (size_t)1.

Use the right format string for a pointer.

In the H5C sanity checks, change a "size increase" variable from ssize_t
(too narrow) to int64_t (wide enough).

Parenthesize every appearance of `storage` in the macro
`H5D_CHUNK_STORAGE_INDEX_CHK(storage)` so that you can pass in an
expression like &sc and it works properly.

Disallow re-assignment of the `dset` parameter to H5D__chunk_init()
because it helped assure me that it's safe to replace the repeating
expression `&dset->shared->layout.storage.u.chunk` with `sc` throughout.

Replace lengthy expressions such as
`&dset->shared->layout.storage.u.chunk` with `sc` throughout several
functions in H5Dchunk.c ISTR that the compiler warned that `sc` was
declared but unused in a couple of functions, and then I found that `sc`
could be used in many places.  Maybe the disused `sc` appeared because a
bunch of code was copied and pasted, I don't know.  Anyway, it's a lot
tighter code now that I use `sc`.

In H5D__chunk_update_old_edge_chunks() and H5D__chunk_delete()
I actually expand `sc` and another temporary variable, `pline`,
because they're used only in !defined(NDEBUG) code.  This squashes
unused-variable warnings in the defined(NDEBUG) configuration.

Don't drop the `volatile` qualification with a cast in
tools/src/h5import/h5import.c.
2020-01-29 10:47:30 -06:00
Allen Byrne
f554a4fb54 Merge pull request #2275 in HDFFV/hdf5 from ~BYRN/hdf5_adb:develop to develop
* commit '4276e37eab01c4d67e0d669fff28d3eac31cc806':
  Remove commented warnings line
  Note for common warnings files
  Create common build system files for warnings
2020-01-29 10:41:33 -06:00
Allen Byrne
4276e37eab Remove commented warnings line 2020-01-29 10:28:10 -06:00
Allen Byrne
1755c2e38f Merging in latest from upstream (HDFFV/hdf5:refs/heads/develop)
* commit '71c050f837149a0c11e0936e661047c091deaa2f':
  rename macro
  fix issues from test fail
  change condition
  pick up from Dave's fix
  leave Wswitch-default for later fix
  fix Wredundant-decls, Wswitch-default, Wdeclaration-after-statement, Wsign-compare, Wmisleading-indentation, Wshadow
2020-01-28 13:46:27 -06:00
Kimmy Mu
71c050f837 Merge pull request #2311 in HDFFV/hdf5 from ~KMU/hdf5:misc to develop
* commit '406330addf45529ecdd088f4d22e9aab9a03661d':
  rename macro
  change condition
  pick up from Dave's fix
  leave Wswitch-default for later fix
  fix Wredundant-decls, Wswitch-default, Wdeclaration-after-statement, Wsign-compare, Wmisleading-indentation, Wshadow
2020-01-28 13:28:26 -06:00
kmu
406330addf rename macro 2020-01-28 13:27:50 -06:00
Kimmy Mu
57dd6d9864 Merge pull request #2315 in HDFFV/hdf5 from ~KMU/hdf5:develop to develop
* commit '3177c89c5b0749ef1294ec60e124bf402246feba':
  fix issues from test fail
2020-01-28 13:25:09 -06:00
kmu
3177c89c5b fix issues from test fail 2020-01-28 13:08:18 -06:00
Allen Byrne
c8e9e10593 Merging in latest from upstream (HDFFV/hdf5:refs/heads/develop)
* commit '15a1bce9a26b15313029410e23be6d706ad0c207':
  Replaced my_isnan with C99 isnan in h5diff.
2020-01-28 08:15:50 -06:00
Dana Robinson
15a1bce9a2 Merge pull request #2304 in HDFFV/hdf5 from ~DEROBINS/hdf5_der:isnan_fixes to develop
* commit '8b4d774eb9bb95cb3c59f033b43ed9fba340a54a':
  Replaced my_isnan with C99 isnan in h5diff.
2020-01-28 02:44:07 -06:00
kmu
9214617e2e change condition 2020-01-27 13:41:42 -06:00
kmu
cd2f954314 pick up from Dave's fix 2020-01-27 12:57:33 -06:00
kmu
54610a7c47 leave Wswitch-default for later fix 2020-01-27 11:38:20 -06:00
Allen Byrne
6637e76a38 Merging in latest from upstream (HDFFV/hdf5:refs/heads/develop)
* commit '38d3834c54ee1dfa7366ae1c581909f0cf7fa000':
  Add another warning variation
  Correct ignore warnings
  Only use sanitizer with Clang
  Remove cmake macros from valgrind tests
2020-01-27 11:12:25 -06:00
Allen Byrne
38d3834c54 Merge pull request #2308 in HDFFV/hdf5 from ~BYRN/hdf5_merge_adb:develop to develop
* commit '3b804074bd358b4a1f5b8ace30f53c4a5b250bf8':
  Add another warning variation
  Correct ignore warnings
  Only use sanitizer with Clang
  Remove cmake macros from valgrind tests
2020-01-27 11:11:27 -06:00
Allen Byrne
3b804074bd Merging in latest from upstream (HDFFV/hdf5:refs/heads/develop)
* commit 'b0aa2c037ebb742db520e4e9a72e06d21c4afa27':
  Restore fix of test assert fail eror undone by later commit.
2020-01-27 09:22:16 -06:00
Allen Byrne
e4055cbea6 Merging in latest from upstream (HDFFV/hdf5:refs/heads/develop)
* commit 'b0aa2c037ebb742db520e4e9a72e06d21c4afa27':
  Restore fix of test assert fail eror undone by later commit.
2020-01-27 09:22:08 -06:00
Larry Knox
b0aa2c037e Merge pull request #2312 in HDFFV/hdf5 from ~LRKNOX/hdf5_lrk:develop to develop
* commit '1c812fcd5d475afb7e65ed28d84990f96eefa649':
  Restore fix of test assert fail eror undone by later commit.
2020-01-27 09:18:53 -06:00
Larry Knox
1c812fcd5d Restore fix of test assert fail eror undone by later commit. 2020-01-27 09:02:58 -06:00
kmu
5163a7e1cf fix Wredundant-decls, Wswitch-default, Wdeclaration-after-statement, Wsign-compare, Wmisleading-indentation, Wshadow 2020-01-27 09:01:32 -06:00
Allen Byrne
999b9151d4 Add another warning variation 2020-01-26 15:13:28 -06:00
Allen Byrne
8e3cd63983 Correct ignore warnings 2020-01-26 10:51:31 -06:00
Allen Byrne
7e52c4a1e1 Only use sanitizer with Clang 2020-01-26 10:19:17 -06:00
Allen Byrne
87a8951fa0 Remove cmake macros from valgrind tests 2020-01-25 09:36:20 -06:00
Allen Byrne
0eec2cc207 Merging in latest from upstream (HDFFV/hdf5:refs/heads/develop)
* commit '5638d8860f3192f9830088ede372006a25bebbd2':
  fix assert fail
  Cleaned up warnings in test/tid.c.
2020-01-25 08:30:45 -06:00
Dana Robinson
5638d8860f Merge pull request #2305 in HDFFV/hdf5 from ~DEROBINS/hdf5_der:tid_cleanup to develop
* commit '51ed3d256e87b423265c17867c80f588ee48fa3b':
  Cleaned up warnings in test/tid.c.
2020-01-24 17:14:41 -06:00
Kimmy Mu
ff4da4f3f5 Merge pull request #2306 in HDFFV/hdf5 from ~KMU/hdf5:develop to develop
* commit 'a152ffafb322551033adb594112f53836f7eb240':
  fix assert fail
2020-01-24 12:31:45 -06:00
kmu
a152ffafb3 fix assert fail 2020-01-24 12:06:26 -06:00
kmu
fb6328b631 Merge branch 'develop' of https://git.hdfgroup.org/scm/~kmu/hdf5 into develop 2020-01-24 12:05:09 -06:00
Allen Byrne
5b92b4d362 Merging in latest from upstream (HDFFV/hdf5:refs/heads/develop)
* commit '590aaff33046df99a4d88ba59e4b461e060b36e4':
  Optimized the floating point comparisons a little bit.
  Fix for failing h5diff tests involving floating-point compares.
  Removed H5_DEC_ENUM
  Revert "Revert "Moved -Wunsuffixed-float-constants to the developer warnings.""
  Revert "Moved -Wunsuffixed-float-constants to the developer warnings."
  Moved -Wunsuffixed-float-constants to the developer warnings.
  Fixed a bug in testpar/t_cache.c concerning checking expected vs. actual cache entry reads and writes.
2020-01-24 09:57:39 -06:00
Dana Robinson
590aaff330 Merge pull request #2303 in HDFFV/hdf5 from ~DEROBINS/hdf5_der:develop_minor to develop
* commit '9475ee5d59e9ac916271a64c5372dfc28f709417':
  Optimized the floating point comparisons a little bit.
  Fix for failing h5diff tests involving floating-point compares.
2020-01-24 07:34:43 -06:00
Dana Robinson
51ed3d256e Cleaned up warnings in test/tid.c. 2020-01-23 21:19:24 -08:00
Dana Robinson
8b4d774eb9 Replaced my_isnan with C99 isnan in h5diff. 2020-01-23 20:12:16 -08:00
Dana Robinson
9475ee5d59 Optimized the floating point comparisons a little bit. 2020-01-23 19:12:24 -08:00
Dana Robinson
a85e4a75b2 Fix for failing h5diff tests involving floating-point compares. 2020-01-23 18:58:08 -08:00
Dana Robinson
3e22f567c4 Merge pull request #2302 in HDFFV/hdf5 from ~DEROBINS/hdf5_der:develop_minor to develop
* commit '601752e76e2e3f34c8bcd2b5b46cf73cad122cb2':
  Removed H5_DEC_ENUM
  Revert "Revert "Moved -Wunsuffixed-float-constants to the developer warnings.""
2020-01-23 17:23:35 -06:00
Dana Robinson
601752e76e Removed H5_DEC_ENUM 2020-01-23 14:43:59 -08:00
Dana Robinson
492d186a5c Revert "Revert "Moved -Wunsuffixed-float-constants to the developer warnings.""
This reverts commit 6486e06545.
2020-01-23 14:40:47 -08:00
Dana Robinson
9a97411a61 Merge pull request #2296 in HDFFV/hdf5 from ~DEROBINS/hdf5_der:develop_minor to develop
* commit '6486e06545bf637d46e18a787395542f4fca143a':
  Revert "Moved -Wunsuffixed-float-constants to the developer warnings."
  Moved -Wunsuffixed-float-constants to the developer warnings.
  Fixed a bug in testpar/t_cache.c concerning checking expected vs. actual cache entry reads and writes.
2020-01-23 16:35:52 -06:00
Dana Robinson
6486e06545 Revert "Moved -Wunsuffixed-float-constants to the developer warnings."
This reverts commit 12bc75c617.
2020-01-23 14:35:16 -08:00
Allen Byrne
bf89ea4711 Merging in latest from upstream (HDFFV/hdf5:refs/heads/develop)
* commit 'f3a4e8164f99d733e6804acddfe1b3b0dfe63634':
  remove unnecessary stuff
  squash cast warning fix
2020-01-23 16:30:17 -06:00
Kimmy Mu
f3a4e8164f Merge pull request #2300 in HDFFV/hdf5 from ~KMU/hdf5:squashed_cast to develop
* commit 'af5c33afabdae2e39bb45eb1b3e9c8366da01145':
  remove unnecessary stuff
  squash cast warning fix
2020-01-23 16:21:06 -06:00
kmu
af5c33afab remove unnecessary stuff 2020-01-23 16:15:52 -06:00
Allen Byrne
3595067621 Merging in latest from upstream (HDFFV/hdf5:refs/heads/develop)
* commit 'a9aaad9be317ed92150ccc6b4e8574e596447dba':
  Change tools debug macros to not use error stack
2020-01-23 15:29:29 -06:00
kmu
838d4ec56b squash cast warning fix 2020-01-23 15:12:00 -06:00
Dana Robinson
12bc75c617 Moved -Wunsuffixed-float-constants to the developer warnings. 2020-01-23 10:18:04 -08:00
Dana Robinson
0444f65140 Merge branch 'develop' into develop_minor 2020-01-23 10:17:40 -08:00
Allen Byrne
a9aaad9be3 Merge pull request #2299 in HDFFV/hdf5 from ~BYRN/hdf5_merge_adb:develop to develop
* commit 'ee1fa14066af158fdafafd6e051f7d5b5f79ba6a':
  Change tools debug macros to not use error stack
2020-01-23 12:12:16 -06:00
Allen Byrne
ee1fa14066 Change tools debug macros to not use error stack 2020-01-23 10:20:34 -06:00
Allen Byrne
670027bf81 Merging in latest from upstream (HDFFV/hdf5:refs/heads/develop)
* commit 'edcba1ce2e11f80d20fcce8f4cfacae1308bf839':
  more cleanup
  Max Library "index" should be 7.
  not use hdf5 private header
  fix float type cmp warning
  fix float type cmp warning
  fix missing prototype warning
  fix uninitizlized warning
  change it back
  pick up missing piece
  fix unused related warnings
  removed unused parameter
  more fix and address comments
  remove unsed var,function,macro, etc
2020-01-23 09:08:47 -06:00