Description:
With optimization enabled, gcc 4.8 inserts garbage into the padding bytes of
floating point types when assigning from a literal constant. This caused
problems when H5detect.c scanned the bits in floating point types to determine
their properties.
Modified H5detect.c to scan for padding before further analyzing the type, and
to ignore all information in the padding areas. Also removed code that
temporarily disabled optimization.
Tested: jam, koala, ostrich, platypus (h5committest)
Description:
H5Fis_hdf5 uses H5F_locate_signature to check if the file is hdf5. If it does
not locate the signature, H5F_locate_signature would issue an error and return
HADDR_UNDEF. H5Fis_hdf5 does not consider it an error if the signature is not
found, so it does not issue an error or clear the stack. The filled stack could
then cause issues later on.
Changed H5F_locate_signature to return herr_t, not issue an error if the
signature is not found, and added a parameter for a pointer to the signature
address that the function fills in.
Tested: jam, koala, ostrich (h5committest)
Clean up warnings, enable new compiler warning flag(s) and bring back
changes from Coverity branch:
r20813:
Remove the dead code as listed for coverity bug #1722. h5committested.
r20814:
Issue 69: Check return value and throw error if negative return. Also free datatype id on error
r20815:
Use HDstrncpy. --gh
r20816:
Replaced one last HDstrcat call with HDstrncat to resolve coverity issue 832.
r20817:
Use HDstrncpy and HDstrncat. --gh
r20818:
Purpose: Fix valgrind issues with h5jam
Description:
Modified h5jam to free strings strdup'd in parse_command_line before exit. Note
that they may still not be freed in case of error, due to the widespread use of
exit().
r20819:
Issue 80: change loop to use int as loop index.
r20820:
Maintenance: Fixed the bug found by coverity CID 788
There were two problems with this function:
1) it tried to unnecessary free NULL pointer
2) it tried to allocate c_name buffer that is done by H5Pget_class_name
Tested on:
Mac OSX 10.8.4 (amazon) w/gcc 4.8.1, C++ & FORTRAN
(too minor to require h5committest)
problem in H5detect.c (uninitialized buffer) and provided the solution. I checked it in yesterday. But it
turned out to be a false fix. So I'm back it out.
Tested on jam - reverse of changes.
problem in H5detect.c (uninitialized buffer) and provided the solution. Allen and I verified it.
Tested with h5committest and CMake on jam, koala, ostrich, playtus, and Allen's virtual machine.
This is needed to avoid a conflict with the Read Context object to be
introduced in another Project.
No impact on users, since this is a private module, and low for
developers as the RC module use is very sparse in the library.
Tested with h5committest.
Tested: jam, koala, ostrich (h5committest)
Log from r23939:
Fix unused variables warnings in trunk
Rename static functions in H5Adense.c, H5B2cache.c, H5Bcache.c
Switch these functions to use FUNC_ENTER_STATIC* macros
Tested: koala
Merge changes from Coverity branch to trunk:
r20768:
Switch to snprintf, HDstrncat, HDstrncpy to address coverity issue 832.
r20812:
Use HDstrncpy. --gh
Tested on:
Mac OSX/64 10.8.4 (amazon) w/debug
Linux/32 2.4 (jam) w/debug
Description:
Failure to write fill values to the user's buffer when reading unallocated
chunks from datasets that have a fill value set to H5D_FILL_VALUE_DEFAULT.
A consequence of this was the reporting of spurious data values in h5dump
and h5diff output.
Solution:
Added check for fill value of H5D_FILL_VALUE_DEFAULT whenever fill value
setting was checked to decide whether or not to fill. This effectively
treats H5D_FILL_VALUE_DEFAULT the same as H5D_FILL_VALUE_USER rather than
H5D_FILL_VALUE_UNDEFINED.
Tested:
h5committest (platypus, ostrich, jam-pp, koala) ran successfully
(fillval test was modified to reveal and check for this error)
Note: RELEASE.txt was previously changed to reflect this fix. This
checkin was of a cleaner version of the code, but mostly to get this
full log message entered.
-This line, and those below, will be ignored--
M H5Dchunk.c
Clean up warnings, switch library code to use Standard C/POSIX wrapper
macros, remove internal calls to API routines, update checkapi and checkposix
scripts.
Tested on:
Mac OSX/64 10.8.3 (amazon) w/C++ & FORTRAN
Big-Endian Linux/64 (ostrich)
Revert r23695, which breaks big-endian tests on ostrich, etc. Will
investigate and submit correction later.
Tested on:
BE & LE Linux systems (ostrich, koala, jam, emu)
