Commit Graph

22 Commits

Author SHA1 Message Date
Vailin Choi
7d124cb796 Modification based on feedback from pull request. 2019-02-05 18:13:11 -06:00
Vailin Choi
7f718e9ea2 There is performance issue when closing an object. The slow down is due to the search of
the "tag_list" to find out the "corked" status of an object.
The fix:
(1)  Add a counter "num_objs_corked" in the cache structure to track the number
of "corked" objects.
(2) Skip the search of "tag_list" if the counter is zero i.e. no "corked" objects.
2019-02-04 22:30:48 -06:00
Dana Robinson
b48686febd Normalization with vol_integration (misc internal and datatype) 2018-09-20 13:38:40 -07:00
Quincey Koziol
4a17aff408 Add API context interface and use it throughout the library. 2018-03-15 16:54:30 -05:00
Larry Knox
89fbe00dec Merge pull request #426 in HDFFV/hdf5 from ~LRKNOX/hdf5_lrk:hdf5_1_10 to hdf5_1_10
* commit '54957d37f5aa73912763dbb6e308555e863c43f4':
  Commit copyright header change for src/H5PLpkg.c which was added after running script to make changes.
  Add new files in release_docs to MANIFEST. Cimmit changes to Makefile.in(s) and H5PL.c that resulted from running autogen.sh.
  Merge pull request #407 in HDFFV/hdf5 from ~LRKNOX/hdf5_lrk:hdf5_1_10_1 to hdf5_1_10_1
  Change copyright headers to replace url referring to file to be removed and replace it with new url for COPYING file.
2017-04-25 16:05:36 -05:00
mainzer
afd8f64c29 Omnibus checkin for several relatively minor modifications:
1) Added code test/page_buffer.c to verify that page buffering is
   disabled in parallel builds.

2) Added code to test/cache_image.c to verify correct interaction
   between evict on close and cache image -- in particular management
   of a file containing a cache image containing dirty metadata that
   has been opened R/O.  Also fix for the bug exposed.

3) Added code to testpar/t_cache_image.c to verify expected procedure
   for reading cache images, and also supporting stats collection code
   needed for the test.

4) Repair of an overactive sanity check in H5C__reconstruct_cache_contents().

5) Other minor tidies in passing.

Tested serial and parallel, debug and production on Jelly.
2017-03-28 11:21:40 -05:00
Quincey Koziol
c4a36e0bb3 Minor cleanups and bring over "prefetched dirty" fixes for entries loaded from
a cache image.
2017-03-12 01:57:19 -08:00
Dana Robinson
02879bc4b2 Updated the H5FS cache code to grab the correct tag and modified
the freespace test to use dxpls that have been tagged with
the H5AC__FREESPACE_TAG global tag instead of H5AC_ind_read_dxpl_id.
The library code now expects the owner of the free space manager
to tag it so the owner-less free space managers in the freespace
tag had to be tagged with *something* to avoid cache errors.
2016-12-07 21:16:12 -05:00
Dana Robinson
16a5c7c8f3 Merge branch 'develop' into eoc_h5fs_fix 2016-12-07 17:21:07 -05:00
Quincey Koziol
64a339183f Bring SWMR support in to the main development branch. (Finally!) More tests
and the tool and API wrappers will be coming in over the weekend.
2016-12-02 08:07:04 -08:00
Dana Robinson
a046ac31d2 First cut at fixing the tagging issue with the free space managers.
* Converted the tag macros to regular ones so the parent's tag
  is used via the dxpl.

* Updated the tag sanity check logic so for free space managers.

* Turned new-style group checks back on in test/evict_on_close.c
2016-11-29 23:53:52 -05:00
Quincey Koziol
2cb2d5a533 Remove "collective write list" parameter from H5C__flush_single_entry() as it
is only used in a couple of places.  The collective write list has been moved
to be internal to the cache data structure instead.
2016-11-28 01:26:33 -06:00
Dana Robinson
4e7b19f826 Two minor cache changes:
* Evict-on-close behavior is now skipped when the file is closing.
  This fixes a potential issue discovered by Valgind on Windows
  where potentially garbage data would be availble for manipulation.

* Added brackets to some code in the tagged entry evict iterators
  so that the flag that determines if progress was made only gets
  set if things are actually evicted. This prevents an infinite
  loop (and emits an error) when pinned entries prevent eviction
  and thus progress.
2016-11-20 11:57:46 -05:00
Quincey Koziol
492eae3995 Clean up cache code to eliminate dead-ends and unify code. 2016-11-10 12:49:22 -08:00
Quincey Koziol
9504d3f337 Switch to new, more scalable, metadata cache entry tagging. 2016-11-06 23:14:10 -08:00
Quincey Koziol
bb6cb6adb0 Code style and warning cleanups, from revise_chunks branch. 2016-11-06 12:08:19 -08:00
Dana Robinson
2646f917ad Cleaned up feature for dissemination to LLNL:
- Removed support for datatypes.
    - Commented out support for groups
    - General change clean-up
    - Added a list of improvements to BRANCH.txt
2016-09-19 16:18:30 -04:00
Dana Robinson
29cb102f12 [svn-r30104] Fixes evict-on-close feature by propagating global
flush flag up the function call stack and not setting
it during H5Dclose().
2016-06-24 17:19:09 -05:00
Quincey Koziol
d3396a7953 [svn-r30075] Description:
Bring object/dataset/group/named datatype features from revise_chunks
branch to trunk.  Also CMake support for h5format_convert and a bunch of
misc. cleanups.

Tested on:
    MacOSX/64 10.11.5 (amazon) w/serial, parallel & production
    (h5committest forthcoming)
2016-06-14 18:07:03 -05:00
Quincey Koziol
7a9e13afdb [svn-r30068] Description:
Bring metadata cache corking to trunk.

Tested on:
    MacOSX/64 10.11.5 (amazon) w/serial, parallel & production
    (h5committest forthcoming)
2016-06-13 12:49:39 -05:00
Quincey Koziol
2e6ccbfff8 [svn-r30053] Description:
Create iterator routine for tagged entries and refactor current routines
to use it.

Tested on:
    MacOSX/64 10.11.5 (amazon) w/serial, parallel & production
    (h5committest forthcoming)
2016-06-07 19:50:46 -05:00
Quincey Koziol
d124a1fe47 [svn-r30035] Description:
Extract tagging routines into separate source module.

Tested on:
    MacOSX/64 10.11.5 (amazon) w/serial & parallel
    (h5committest forthcoming)
2016-06-06 01:41:16 -05:00