Commit Graph

21469 Commits

Author SHA1 Message Date
Allen Byrne
9224c7abaa Merging in latest from upstream (HDFFV/hdf5:refs/heads/develop)
* commit 'b480d0a38b1e265c55c74262bf384d255a33e07b':
  Remove path to szip header file from AM_CPPFLAGS when configure check of libsz fails. Fix for HDFFV-10830.
  HDFFV-11116 Add option for install location of Fortran MOD files
2020-07-11 12:53:11 -05:00
Larry Knox
b480d0a38b Merge pull request #2686 in HDFFV/hdf5 from ~LRKNOX/hdf5_lrk:develop to develop
* commit '800f93f7c994f88dfa716746153ded4b1e690e3a':
  Remove path to szip header file from AM_CPPFLAGS when configure check of libsz fails. Fix for HDFFV-10830.
2020-07-11 08:07:10 -05:00
Allen Byrne
e3f5f59a61 Merge pull request #2684 in HDFFV/hdf5 from ~BYRN/hdf5_adb:feature/HDFFV-11116-trilabs-mod-location to develop
* commit '07a52ecb2ffa1d8d32f06db23470833899db3deb':
  HDFFV-11116 Add option for install location of Fortran MOD files
2020-07-11 07:10:31 -05:00
Larry Knox
800f93f7c9 Merge branch 'develop' of https://bitbucket.hdfgroup.org/scm/~lrknox/hdf5_lrk into develop 2020-07-10 13:44:08 -05:00
Larry Knox
0f3fd8d53d Remove path to szip header file from AM_CPPFLAGS when configure check of libsz fails.
Fix for HDFFV-10830.
2020-07-10 13:39:59 -05:00
Allen Byrne
b63c9e81dd Merging in latest from upstream (HDFFV/hdf5:refs/heads/develop)
* commit 'f5da9b1befeb81aa9f4d97df3ec606f801807420':
  Minor changes from normalization with 1.10
2020-07-09 16:14:34 -05:00
Dana Robinson
f5da9b1bef Merge pull request #2683 in HDFFV/hdf5 from ~DEROBINS/hdf5_der:develop_normalization to develop
* commit '127d1cfdf06e9c1cd264595c496a063848358a0a':
  Minor changes from normalization with 1.10
2020-07-09 15:50:43 -05:00
David Young
69d51065d2 Merge branch 'rebased-fprintf-experiment' into fprintf-develop 2020-07-09 13:57:53 -05:00
Allen Byrne
07a52ecb2f HDFFV-11116 Add option for install location of Fortran MOD files 2020-07-09 13:03:58 -05:00
Dana Robinson
127d1cfdf0 Minor changes from normalization with 1.10 2020-07-09 08:34:01 -07:00
Allen Byrne
4b12244091 Merging in latest from upstream (HDFFV/hdf5:refs/heads/develop)
* commit '188c43b8ee78d830c22f30fb9adb802e46722fcd':
  Change load path in libhdf5_java.dylib to unversioned libhdf5.dylib for junit tests on Macs.
  Fixes Autotools builds on Solaris after monotonic timer changes
2020-07-08 07:16:03 -05:00
Dana Robinson
188c43b8ee Merge pull request #2680 in HDFFV/hdf5 from ~DEROBINS/hdf5_der:develop_minor to develop
* commit 'd9105b2fcf04f36ea348bf9726a49c05cacc0b78':
  Fixes Autotools builds on Solaris after monotonic timer changes
2020-07-07 16:38:47 -05:00
Larry Knox
c5af29321b Merge pull request #2677 in HDFFV/hdf5 from ~LRKNOX/hdf5_lrk:develop to develop
* commit 'da607fe4638c9cc08f717fbe65e799c1676c17ff':
  Change load path in libhdf5_java.dylib to unversioned libhdf5.dylib for junit tests on Macs.
2020-07-07 16:27:45 -05:00
Larry Knox
da607fe463 Change load path in libhdf5_java.dylib to unversioned libhdf5.dylib for
junit tests on Macs.
2020-07-07 10:52:58 -05:00
David Young
a8dc4bd93f Always #define HDfprintf as fprintf in this header. I believe this will fix
the Windows build error that Allen reported.
2020-07-07 10:49:55 -05:00
David Young
922e465b46 Provide an HDvasprintf implementation only if it isn't #defined. This should
fix the mingw compilation issue that Allen reported.
2020-07-07 10:49:55 -05:00
David Young
62dbb80cb6 Fix va_list usage in the vasprintf(3) implementation. 2020-07-07 10:49:55 -05:00
David Young
90466630ea Promote format-string warnings to errors. 2020-07-07 10:49:55 -05:00
David Young
f68226ed89 Use the portable -eq operator instead of the bash-ism ==. Fixes the
tests on NetBSD, where /bin/sh != bash.
2020-07-07 10:49:55 -05:00
David Young
d553bd4bf3 Restore a literal percent sign ("%%") that I accidentally deleted. 2020-07-07 10:49:55 -05:00
David Young
9159b93da6 Fix code that made GCC complain about a NULL or unsigned char * arguments for
"%s".

XXX The duplication between test/ros3.c test/s3comms.c is really annoying.
2020-07-07 10:49:55 -05:00
David Young
345443f9ad Take pains to provide UINT64_MAX in all conditions. 2020-07-07 10:49:55 -05:00
David Young
c6fcec46c9 Correct a couple of format strings. 2020-07-07 10:49:55 -05:00
David Young
23bbe96c75 Use PRIuHSIZE and PRIXHSIZE for portability. 2020-07-07 10:49:55 -05:00
David Young
4e41ca05aa Delete extra argument, there is no formatting for it. 2020-07-07 10:49:55 -05:00
David Young
ca8a73923f Fix fprintf arguments: "%p" expects a void * argument. 2020-07-07 10:49:55 -05:00
David Young
307cb5da48 Squash my changes on branch fprintf-experiment into one commit for
reapplication to my new warnings branch, `warnings-again`.  These
changes are included:

commit 915551b7bf64e777dd2007386ec77b1d117770da
Merge: 63858c2 a8892bb
Author: David Young <dyoung@hdfgroup.org>
Date:   Mon Nov 25 17:39:49 2019 -0600

    Merge remote-tracking branch 'hdf5/develop' into fprintf-experiment

commit a8892bb42d
Merge: 5c911d8 f907b51
Author: David Young <dyoung@hdfgroup.org>
Date:   Mon Nov 25 17:33:54 2019 -0600

    Merge pull request #2055 in HDFFV/hdf5 from ~DYOUNG/vchoi_fork:add-werror-and-squash-some to develop

    * commit 'f907b511d06612dafc7814a7c30f2f3d2b76d52b':
      Oops, remove more C99 designated initializers for VS 2010 compatibility.

commit 63858c22e168acaec0af8ced6641f26102cc6bb0
Merge: 20ae787 5c911d8
Author: David Young <dyoung@hdfgroup.org>
Date:   Mon Nov 25 17:04:42 2019 -0600

    Merge remote-tracking branch 'hdf5/develop' into fprintf-experiment

commit 5c911d8baf
Merge: b8a5671 62208b0
Author: David Young <dyoung@hdfgroup.org>
Date:   Mon Nov 25 16:58:27 2019 -0600

    Merge pull request #2030 in HDFFV/hdf5 from ~DYOUNG/vchoi_fork:add-werror-and-squash-some to develop

    * commit '62208b056a09c01855fbac7f75146be58ad6bfe5': (44 commits)
      Add an #include to get a function declaration.
      Don't use C99 designated initializers, they're not compatible with Visual Studio 2010.
      Quiet some more maybe-uninitialized warnings---each is a false positive, *sigh*.  This is more code that may not compile with VS2010, *sigh sigh*.
      Always warn on maybe-uninitialized.  -Wincompatible-pointer-types was not available until GCC 5, so enable it only if that's the GCC version we're using.
      Only promote maybe-uninitialized warnings to errors on GCC 8.  Even on GCC 8, there may be false positives at low optimization levels?  I need to check.
      Only use -Werror=cast-function-type with GCC 8 and later.
      Put all of the -W options back into the order I found them in so that it's easier to compare old and new config/gnu-flags.
      Add new source files to CMakeLists.txt.
      Mention the -Werror= flags in libhdf5.settings.in.
      free -> HDfree
      Promote decleration-after-statement warnings to errors.
      Quiet decleration-after-statement warnings.
      Move a statement under some declarations since some vintages of Visual Studio don't like declarations after statements.
      Document H5D__chunk_mem_xfree_wrapper().
      Undo accidental test deletion.
      Oops, delete a debug printf that snuck in here.
      Undo my changes to the HD macros, hadn't really intended those to be on this branch....
      Make errors of some more warnings.  Move disabled warnings to DEVELOPER_WARNING_CFLAGS.  Put just one warning option on a line, and sort some of the options.
      Cast to the parameter type, H5VL_token_t *, instead of to unsigned char *.
      Change hdset_reg_ref_t and H5R_ref_t from arrays of unsigned char to structs containing those arrays.  Encapsulating the arrays in this way makes it easier to write and think about pointers to these types, casts to/from these types, etc.
      ...

commit 20ae7877e33931b95e8c3502b027d6c3fe94a11f
Merge: 46f8c61 edd5297
Author: David Young <dyoung@hdfgroup.org>
Date:   Fri Nov 22 15:34:09 2019 -0600

    Merge remote-tracking branch 'origin/add-werror-and-squash-some' into fprintf-experiment

commit 46f8c613d5117a8be5bc8385a072daa0b4262f06
Author: David Young <dyoung@hdfgroup.org>
Date:   Fri Nov 22 15:29:00 2019 -0600

    GCC really wants us to use `ll` to format `long long`, so try to make that work
    before any other format modifier.  Seems like we're not compiling the autoconf
    test program with -Werror=format ?  Probably should.

commit eee35b8ef3759c391327cd48a9b3c56b6f8abc99
Author: David Young <dyoung@hdfgroup.org>
Date:   Fri Nov 22 15:28:05 2019 -0600

    It's hard to know just how wide an HDoff_t will be, and I don't think POSIX or
    C standards provide a PRI macro for it, so cast to intmax_t and format using
    PRIdMAX.

commit 86eab12df7a89b546a38e99f8178dd2adbcb3433
Author: David Young <dyoung@hdfgroup.org>
Date:   Fri Nov 22 15:26:25 2019 -0600

    URemove some casts.se the right format string for the argument.  Here and there
    stop casting a printf argument.

commit f722f7cbecbaa99449941484b014426f62f1bed5
Merge: 58e3743 6d5ec83
Author: David Young <dyoung@hdfgroup.org>
Date:   Fri Nov 22 14:44:16 2019 -0600

    Merge branch 'add-werror-and-squash-some' into fprintf-experiment

commit 58e3743b7faa9836606ee91798fe80dfc0040da7
Author: David Young <dyoung@hdfgroup.org>
Date:   Wed Nov 20 21:07:21 2019 -0600

    Remove custom HDfprintf implementation, using the standard library's,
    instead.  Take a swipe at repairing fprintf format strings, mainly
    replacing "%Hu" with "%" PRIuHSIZE, "%a" with "%" PRIuHADDR, "%Zu" with
    "%zu".

    Here and there remove an awkward cast of a printf argument to `long
    long` and use PRI[doux]8, PRI[doux]32, or PRI[doux]64, instead.

    Change occurrences of "%t" to "%s" and perform a suitable change of
    argument, `cond` -> `cond ? "TRUE" : "FALSE"`.

    Some occurrences of %Hu, %a, and %t remain, they just weren't flagged by
    the compiler because of #ifdef'age.

commit d4366909293fa970c23512ac80e5d865d76cddbf
Author: David Young <dyoung@hdfgroup.org>
Date:   Wed Nov 20 20:54:32 2019 -0600

    Promote format-string warnigns to errors.
2020-07-07 10:49:55 -05:00
Dana Robinson
d9105b2fcf Fixes Autotools builds on Solaris after monotonic timer changes
clock_gettime() wasn't being found, so some configure changes
were needed to set an appropriate POSIX level and use a C99
compiler. This required several compiler flag changes.

Autotools only
2020-07-06 19:22:26 -05:00
Allen Byrne
c80d6fe451 Merging in latest from upstream (HDFFV/hdf5:refs/heads/develop)
* commit 'd52b27ad1d8142945a92310b79ab79171e76a3c3':
  Address CMake and deprecated API build failures from monotonic timer patch.
2020-07-03 13:56:43 -05:00
Quincey Koziol
d52b27ad1d Merge pull request #2673 in HDFFV/hdf5 from monotonic_timer_fix_01 to develop
* commit '13c9b3768e6193db89d06faf59194b77d7747f45':
  Address CMake and deprecated API build failures from monotonic timer patch.
2020-07-03 11:58:55 -05:00
Quincey Koziol
13c9b3768e Address CMake and deprecated API build failures from monotonic timer patch. 2020-07-03 11:28:12 -05:00
Allen Byrne
6b66c969f5 Merging in latest from upstream (HDFFV/hdf5:refs/heads/develop)
* commit '7443e5d53d1c6f15e095de7c44bcc3a5a46d9cf7':
  Add missing '"'.
2020-07-03 09:36:16 -05:00
Larry Knox
7443e5d53d Merge pull request #2672 in HDFFV/hdf5 from ~LRKNOX/hdf5_lrk:develop to develop
* commit '870e3ba3f45e90a43ea824d67cc8562aa63a3f6f':
  Add missing '"'.
2020-07-02 18:49:36 -05:00
Larry Knox
870e3ba3f4 Add missing '"'. 2020-07-02 18:20:36 -05:00
Allen Byrne
5356fb1687 Merging in latest from upstream (HDFFV/hdf5:refs/heads/develop)
* commit '4c2071bfd3270dc3a688914b4a058147b94b7023':
  Lib files needed are now copied to a subdirectory in the java/test directory, and on Macs the loader path for libhdf5.xxxs.so is changed in the temporary copy of libhdf5_java.dylib. Fix for HDFFV-11063
2020-07-02 14:47:13 -05:00
Allen Byrne
4c2071bfd3 Merge pull request #2671 in HDFFV/hdf5 from ~BYRN/hdf5_adb:develop to develop
* commit '88e8597cdef826c1087e4ec1383657a91dcb2a43':
  Small changes discovered with mingw and windows defines moved
2020-07-02 14:46:43 -05:00
Larry Knox
68d6981156 Merge pull request #2670 in HDFFV/hdf5 from ~LRKNOX/hdf5_lrk:develop to develop
* commit 'fc69de0e8ae30e80c1c3c542b156226a75444525':
  Lib files needed are now copied to a subdirectory in the java/test directory, and on Macs the loader path for libhdf5.xxxs.so is changed in the temporary copy of libhdf5_java.dylib. Fix for HDFFV-11063
2020-07-02 14:14:53 -05:00
Allen Byrne
88e8597cde Small changes discovered with mingw and windows defines moved 2020-07-02 13:52:03 -05:00
Larry Knox
fc69de0e8a Lib files needed are now copied to a subdirectory in the java/test
directory, and on Macs the loader path for libhdf5.xxxs.so is changed
in the temporary copy of libhdf5_java.dylib.
Fix for HDFFV-11063
2020-07-02 11:29:12 -05:00
Quincey Koziol
d05b58b5d4 Merge pull request #2668 in HDFFV/hdf5 from monotonic_timer to develop
* commit '7371c83f9777b34b31909e99e052398b93c31bed':
  Remove non-existent example
  Add new source files to CMake build
  Clean up warnings
  va_arg -> HDva_arg
  Refactor code to remove remaining checks for H5_HAVE_GETTIMEOFDAY scattered around in various places.  Also clean up iopipe.c.
  Correct mistake in H5_now_usec calculation for clock_gettime.
  Remove detection for mach/mach/time.h, since we're no longer using the time routines from that header.
  Update H5_now_usec to prefer using clock_gettime.
  Changes to make timers within the library monotonic.
2020-07-02 10:36:44 -05:00
Jake Smith
7cbb5fe2d1 Merge pull request #2669 in HDFFV/hdf5 from ~JAKE.SMITH/hdf5:bugfix/HDftell_macro_typo to develop
* commit 'ef05e68c38d2086c6f262744b4087f65a6e58957':
  Fix typo in HDftell macro definition: 'ftello -> ftell'
2020-06-30 13:36:01 -05:00
Quincey Koziol
7371c83f97 Remove non-existent example 2020-06-30 08:53:17 -05:00
Quincey Koziol
c005b8f52b Merge remote-tracking branch 'origin/develop' into monotonic_timer 2020-06-30 08:52:49 -05:00
Binh-Minh Ribler
267ff9065b Merge pull request #2609 in HDFFV/hdf5 from ~BMRIBLER/hdf5-bmr:develop to develop
Fix HDFFV-11053 (CVE-2020-10810)

* commit 'b155a777629e991374fa2f8609719cb861de4cc2':
  Changed wording in comment.
  - added comment to explain a kluge - added the associated entry to release notes
  Fix HDFFV-11053
2020-06-30 01:04:24 -05:00
Binh-Minh Ribler
b155a77762 Changed wording in comment. 2020-06-30 00:57:46 -05:00
Larry Knox
23cc4ce636 Merge pull request #2667 in HDFFV/hdf5 from ~LRKNOX/hdf5_lrk:develop to develop
* commit '32c483cb86031962a09ecdb49dcb331d28dddee9':
  Copy lib files for junit.sh to temporary subdirectory of <build directory>/java/test instead of to the prefix/lib directory.  Fix for HDFFV-11063.
2020-06-29 21:18:27 -05:00
Binh-Minh Ribler
7c006fd761 - added comment to explain a kluge
- added the associated entry to release notes
2020-06-29 14:16:35 -05:00
Jacob Smith
ef05e68c38 Fix typo in HDftell macro definition: 'ftello -> ftell' 2020-06-29 12:09:07 -05:00
Binh-Minh Ribler
785a1cef0c Merging in latest from upstream (HDFFV/hdf5:refs/heads/develop)
* commit '30776671fb0a27a98b0640aa968f850241a862ce': (31 commits)
  * Fix intermittent error with Splitter VFD.     Mismatch in time of test file creation was creating false negatives.
  Added note for HDFFV-10591.
  Fix HDFFV-10591
  Reduce overhead for H5open, which is involved in the public symbols like H5T_NATIVE_INT, etc.
  Remove unnecessary version conditions for Clang compilers.
  Fix for HDFFV-10961: Couple changes to the tests' usage output files for h5clear.
  Fix for HDFFV-10961: add description to usage for --increment option.
  Add c++ to --enable-sanitize-checks option.
  Remove duplicate entries in MANIFEST.
  Make changes to CMake CompilerFlags.cmake files so extra flags are loaded for non-GNU compilers.
  Fix MANIFEST
  Add tests for all version to H5_NO_DEPRECATED_SYMBOLS section and to section for current version, with and without default API version flags.
  HDFFV-11000:  update-testh5cc.sh.in to test sample versioned functions in HDF5 1.10, 1.12 and develop.
  Remember the info for the last ID looked up for a given ID type.
  Eliminate allocating file & memory offset & length arrays when performing I/O on a single element.
  Update new clang files to not pick up clang as vendor for pgCC. Add new files to MANIFEST Temporary demotion of 2 -Werror warning flags that fail on macos 10.12 Remove Production flag unknown to Apple clang.
  Remove redundant metadata cache tagging from some low-level internal chunk functions.  The metadata cache tagging has already been done by routines further up the call stack.
  Clean up code to get clang version in config/linux-gnulibc1
  Minor normalizations with HDF5 1.10.
  Add flags from config/clang-warnings/*general files to H5 C and CXX flags for all versions of Clang and Clang++ compilers. Switched from cut to awk in testcheck_version.sh.in to avoid dependence on tab vs. " " in version definitions in H5public.h.
  ...
2020-06-29 11:53:55 -05:00
Quincey Koziol
c5258211e7 Add new source files to CMake build 2020-06-27 22:14:52 -05:00