Bug fix.
Description:
When the same dataset is opened more than once and those references to the
object are left dangling, the library would not correctly shut down the dataset
API, potentially allowing the file to be truncated.
Solution:
"force" the dataset IDs to be released when the dataset API is being shut
down by the library.
Platforms tested:
FreeBSD 4.8 (sleipnir)
h5committested
Bug fix.
Description:
If the buffer holding the list of interfaces that are attempting to be
closed down becomes full, the library stops recording that an infinite loop has
occurred when shutting down the interfaces.
Solution:
Always return the correct "pending" information.
Also added ellipsis to the string of interfaces to try to make it more
obvious that the buffer became full.
Platforms tested:
FreeBSD 4.8 (sleipnir)
h5committested
Bug fix
Description:
Added missing line for file close degree setting for this VFD.
Platforms tested:
FreeBSD 4.8 (sleipnir)
h5committested
(Unfortunately, none of these tests actually exercised this driver... :-(
Bug fix
Description:
A few groups were left open after they were used.
Solution:
Closed them. :-)
Platforms tested:
FreeBSD 4.8 (sleipnir)
h5committested
A little change for project modification
Description:
libtestD.dll for debug mode is changed to libtestDd.dll to separate
from release version.
Solution:
Platforms tested:
windows 2000
Misc. update:
Bug fix
Description:
Iterating over the attributes of an object without any attributes was
returning FAIL instead of 0 as the RM states.
Solution:
Changed return value of H5Aiterate for objects without attributes to be 0
and added regression tests for this.
Platforms tested:
FreeBSD 4.8 (sleipnir)
h5committest not needed.
Small code cleanup
Description:
Remove redundant sanity check.
Added a note about a potential bug.
Platforms tested:
FreeBSD 4.8 (sleipnir)
h5committest not necessary.
Bug Fix
Description:
Some compilers aren't happy if you specify the same library multiple
times when linking. This caused HDF5 Lite to crash during tests on
Kelgia
Solution:
Modified the script so that the shared libraries are specified only
once for the commandline.
Platforms tested:
Kelgia (small fix).
Misc. update:
Description: when a datatype element size is bigger than I/O datatype
conversion buffer(1MB), library reports failure.
Solution: adjust conversion buffer to be at least equal to one element size
Platforms tested: h5committest
Bug Fix
Description:
When doing a "configure" using the h5cc script as the compiler, it
would fail to accept the "-E" flag as running the preprocessor. The
problem was that it was trying to link the file afterwards. Of
course, the file wouldn't be there, so it would fail.
Solution:
Changed it so that if the -E flag is used, then we don't try to link
(this is how it's done in mpicc...I must have copied it wrongly).
Platforms tested:
Linux & Kelgia (small change not needing full testing)
Misc. update:
Bug Fix
Description:
The newly added H5TEST_DLL{VAR} macros weren't defined if it wasn't
a Windows environment.
Solution:
"#define" them to "" and "extern" if not a WIN32 environment.
Platforms tested:
Linux (small change not needing full testing)
Misc. update:
Feature
Description:
Sometimes the total build process take a long time, especially in
parallel systems. Need some idea if some times are taking way
too long to process.
Solution:
Added timestamps marking the beginning and ending of tests in
one directory. This gives a rough idea of how much time the
tests use.
Platforms tested:
Tested only in Eirene since this is just a makefile thing and only
involve a simple command like echo and date.
Misc. update:
Add decriptions to use libtestD.dll.
Description:
libtestD.dll should be placed to a place that the user can find in order to
test HDF5 DLL within HDF5 workspace.
Solution:
Explained in document.
Platforms tested:
No need
Misc. update:
Add windows specified macro H5_TESTDLL for test routines.
Description:
See the previous CVS message.
Solution:
Platforms tested:
windows2000(will not affect other platforms)
Misc. update:
To add macro HDF5TESTDLL for windows libtest library.
Description:
Many HDF5 tests will use h5test.c.
So we create a libtest library to
1) make tests more organized and
2) make tests more consistent with other platforms
3) reduce compiling times
4) reduce dumplicated warnings possibily generated by h5test.c
However, we didn't create the corresponding libtest DLL correctly,
now, some warnings are generated because of this; so for this release,
we follow exactly DLL-DLL rules, to create an internal libtest DLL for
our test suites.
The application who used HDF5DLL will not have extra burdens to add
HDF5TESTDLL and this will reflect in the release.txt
Solution:
USE DLL import and export library by defining macro HDF5TESTDLL and HDF5TESTUSEDLL
Platforms tested:
Windows 2000(the macro will not affect on non-WIN32 platforms).
Misc. update:
Windows project-rearrangements, shut off warnings
Description:
1. H5Farray.c is no longer used, removed it from hdf5.dsp.
2. libtestD is supposed to be a windows DLL; however it is treated as static library in the past.
change it back to DLL and add HDF5TESTDLL and HDF5USETESTDLL.
Solution:
1. see above.
2. change h5api_adpt.h and h5test.h, add macro HDF5TESTDLL and HDF5TESTUSEDLL.
These changes will not affect other platforms.
Platforms tested:
windows 2000
Misc. update:
changed algorythm
Description:
changed the array_diff function to increment the read buffer with a size selected
by an appropriate native data type.
previously it was assumed, e.g. int size = 4 bytes
Solution:
Platforms tested:
Linux 2.4 (rockaway)
SunOS 5.7 (arabica, 64bit mode)
IRIX 6.5 (modi4)
Misc. update:
code warrior update
Description:
changed the project file to include the new H5Dio.c and remove the old H5Farray.c files
updated install instructions
Solution:
Platforms tested:
code warrior
Misc. update:
Bug fix
Description:
The tests would just segmentation fault in Tflops because the
compiled code were launched without using the $RUNSERIAL to launch
them. This may fail in some batch systems like Tflops.
Solution:
Used $RUNSERIAL to launch the compiled code.
Also fixed a typo of the script command line.
Platforms tested:
Only tested in Tflops since the modified code resided there.
Misc. update:
bug fix
Description:
datasets with different storage datatypes where not read to memory to same size types
Solution:
obtain the memory type and size, for the TWO datasets ,
with the "fixtype" function
"upgrade" the smaller size to the larger if they are different
added H5DIFF_DEBUG flag for print information
Platforms tested:
Linux 2.4 (rockaway)
SunOS 5.7 (arabica, 64bit mode)
IRIX 6.5 (modi4)
Misc. update:
Code cleanup
Description:
Clean up warnings exposed by compiling on O2K. Also, revert some of Bill
and my changes to the H5S_mpi_opt_types_g, etc. and settle them back into their
original location.
Platforms tested:
h5committested.
Code Cleanup
Description:
Warning messages were being produced by the "make" program because
the "docdir" was being specified twice as a target in the generated
Makefiles. This is because the "EXAMPLESDIR" was also defined as
"docdir".
Solution:
Made "EXAMPLESDIR" unique for C, Fortran, and C++ in the commence.in
file and removed EXAMPLESDIR from the Makefile.ins
Platforms tested:
Dangermouse (only affects make system, not code).
Misc. update:
Bug Fix
Description:
A variable wasn't declared in this file.
Solution:
Put the extern declaration of the variable in this file. It's defined
in the H5S.c module.
Platforms tested:
Modi4 (This affects only parallel platforms)
Misc. update:
Description: H5Sselect_hyperslab and H5Sselect_elements didn't check scalar
dataspaces.
Solution: put error detection in those functions.
Platforms tested: eirene(simple change).
Code cleanup.
Description:
Move many package or internal function prototypes and macro definitions
into tighter scope according to their current use.
Added more comments where appropriate.
Eliminate ancient, unused functions.
Added a couple "accessor" functions to get parts of data structures which
were moved out of scope.
Platforms tested:
h5committested
Purpose: Maintenance
Description: I changed release version to 1.5.54.
Email about tetsing of 1.5.53 will be send after this checkins.
Solution: used bin/h5vers -s to change the version number
Platforms tested: Done on arabica
Misc. update:
Feature change
Description:
HDF5_PARAPREFIX has been default to various values like /tmp,
/var/tmp, ... None of these solve all problems and all of them
created new problems. For LLNL GPFS, '.' is more appropriate since
they can do the build right inside gpfs. Same for NCSA Copper.
The special setting for Janus is still retained since that is a
one of a kind machine and the uses could use all the help.
Platforms tested:
h5committested (using sol instead of arabica) plus eirene(pp).
Misc. update:
Improvement
Description:
Added an explanation of using $HDF5_PARAPREFIX for Parallel tests.
Platforms tested:
h5committested (using sol instead of arabica) plus eirene(pp).
Misc. update:
Bug fix
Description:
New external file double-vectorized I/O routines were checking an assertion
on the wrong variable (essentially a typo :-).
Solution:
Check correct variable.
Platforms tested:
FreeBSD 4.8 (sleipnir)
Triple check not needed.
Bug fix
Description:
Dataspace selections created for individual chunks during chunk dataset
I/O were leaking memory.
Solution:
Properly set reference count on selection, so they get free'd when the
dataspace is closed.
Platforms tested:
FreeBSD 4.8 (sleipnir)
Triple check not needed.
Code cleanup.
Description:
Cleaned up an unusued variable and some commented out code.
Platforms tested:
FreeBSD 4.8 (sleipnir)
Triple check not needed.
Description: H5T_XXX_init_interface calls H5T_init_interface causing
datatype not closed after file is closed.
Solution: changed H5T_init_interface to H5T_init
Platforms tested: h5committest
added new test files for h5diff
bug fix
Description:
the criteria for determining the correct switch case cast to void* to type* was the data size read from disk.
this was causing problems on Cray T3E, where all integer except char are 8 bytes long
Solution:
changed the criteria for using the memory size instead, which is determined by the same function
that reads the data into memory
the messages " using memory NATIVE_TYPE_X" were removed, because they might not coincid on different
platforms.
Platforms tested:
Linux 2.4 (rockaway)
SunOS 5.7 (arabica)
IRIX 6.5 (modi4)
Misc. update:
New feature/enhancement
Description:
Chunked datasets are handled poorly in several circumstances involving
certain selections and chunks that are too large for the chunk cache and/or
chunks with filters, causing the chunk to be read from disk multiple times.
Solution:
Rearrange raw data I/O infrastructure to handle chunked datasets in a much
more friendly way by creating a selection in memory and on disk for each chunk
in a chunked dataset and performing all of the I/O on that chunk at one time.
There are still some scalability (the current code attempts to
create a selection for all the chunks in the dataset, instead of just the
chunks that are accessed, requiring portions of the istore.c and fillval.c
tests to be commented out) and performance issues, but checking this in will
allow the changes to be tested by a much wider audience while I address the
remaining issues.
Platforms tested:
h5committested, FreeBSD 4.8 (sleipnir) serial & parallel, Linux 2.4 (eirene)
Code Improvements/Bug Fixes
Description:
Comparison of equality of a double/float variable to 0.0 is not
guaranteed to work and is bad practice.
In H5Fcontig.c, a warning was given by a statement like:
x = (++x) % y;
This could be confusing to a compiler I suppose.
In H5RS.c, a typedef of a structure was being tagged by the compiler
as "useless" because it had the form:
typedef struct foo {
int var1;
/* ... */
}; /* <--- note no name for this typedef */
The statement "typedef struct foo foo" is already in the header file.
Solution:
Test that the absolute value of the variable is < a very small
positive number.
Changed "x = (++x) % y" to "++x; x %= y;" instead.
Removed the "typedef" from the structure in the H5RS.c file.
Platforms tested:
Modi4 (Parallel & Fortran)
Verbena (C++ & Fortran)
Arabica (Fortran)
Misc. update:
Code Improvements/Bug Fixes
Description:
Comparison of equality of a double/float variable to 0.0 is not
guaranteed to work and is bad practice.
Solution:
Test that the absolute value of the variable is < a very small
positive number.
Platforms tested:
Modi4 (Parallel & Fortran)
Verbena (C++ & Fortran)
Arabica (Fortran)
Misc. update:
Purpose: Cray T3E maintenance with Raymond's help
Description: fillval test failed for compact dataset since the
size of the dataset was bigger than 64K.
Solution: Reduced the dataspace of the compact dataset to 1024 elements.
Platforms tested: T3E; it was also tested with semi-manual h5committest.
(I had to built and test manually on modi4 parallel because
of some weird failure of h5committest on modi4)
Misc. update:
Purpose: Fortran updtae
Description: Created new functions h5pset(get)_fapl_mpiposix_f
Platforms tested: Compilation was tested with semi-manual h5committest.
(I ahd to built and test manullay on modi4 parallel because
of some weird failure of h5committest on modi4)
There are no tests yet for those functions. Kent was
going to use them in the MEAD project to test
the performance.
Misc. update:
Purpose: Maintenance for T3E
Description: Cray updated T3E to run unicosmk2.0.6.X
Configuration failed.
Solution: Created new unicosmk2.0.6.X files in the config and fortran/config
directories and added them to MANIFEST. I had to disable warning
# 412 for fortran compilation. The warning would prevent creation
of executable programs.
Platforms tested: Cray T3E
Misc. update:
Purpose: Maintenance for T3E
Description: Cray updated T3E to run unicosmk2.0.6.X
Configuration failed.
Solution: Created new unicosmk2.0.6.X files in the config and fortran/config
directories and added them to MANIFEST
Platforms tested: Cray T3E
Misc. update:
