Commit Graph

168 Commits

Author SHA1 Message Date
Leon Arber
82b3a0ca4a [svn-r10206]
Purpose:
Bug fix.

Description:
ph5diff fails on modi4 due to the way snprintf works on IRIX.

Solution:
The C99 standard says that, if there isn't enough room in the string,
 snprintf should return the number of characters that
would have been written to the output string if there were enough room.

The snprintf on modi4 would return the number of characters that is was able to write
succesfully to the string if space ran out. The ph5diff logic that checks if
the output buffer was full did not handle this sort of return value correctly.

Used  VSNPRINTF_WORKS from configure test to check how snprintf works and do
the logic accordingly.

Platforms tested:
modi4

Misc. update:
2005-03-13 18:38:11 -05:00
Leon Arber
15e0a2331e [svn-r10170] Purpose:
Bug Fixes

Description:
Fixes for several bugs, including dumping of excess output to a temporary file, fix for printing
hsize_t datatype, and the long awaited fix for intermixed output.

Solution:
Fix 1:  Overflow file
Previously, any output that a worker task made was buffered locally in memory, up to a point.  Any
output beyond the size of the buffer (used to be 10k) was discarded.  Now, the memory buffer size has been
changed to 1k and any output beyond this amount is sent a temporary file.  This way, no output is lost
and memory usage is kept under control.  The temporary file is deleted as soon as a worker task finishes
sending its contents to the manager.

Fix 2:  hsize_t printing
Printing of the hsize_t datatype used to be handled by %Hu passed to HDfprintf.  However, there is no corresponding HDvsnprintf that
is able to print hsize_t types.  These are now printed with the aid of H5_PRINTF_LL_WIDTH.

Fix 3:  Intermixed output fix
Intermixed output would occur on some machines (although I haven't seen it happen for a while) due to the unpredictability of the underlying network
and the speed at which various message would travel.  This has been fixed by having all output send to the manager
for printing.  The worker tasks no longer print the output themselves upon receipt of a token, but instead
send that data to the manager.



Platforms tested:
heping, eirene, tg-login (the only place that seems to still experience intermixed output every now and then)

Misc. update:
2005-03-09 13:38:36 -05:00
James Laird
25df1908bc [svn-r10158] Purpose:
Automake version upgrade

Description:
Upgraded automake version from 1.6.2 to 1.9.5.
Changed bin/reconfigure script to use automake 1.9.5.
Changed configure.in and Makefiles to use new FCFLAGS and FC variables
instead of FFLAGS and F9X.
Automake and configure should now do the lion's share of the work
supporting Fortran 9X; macros in acsite.m4 are now mostly unused (will
be cleaned later).
Altered how configure handles pmake; now root-level Makefile.in is
processed by bin/reconfigure to have a .MAKEFLAGS target, since
automake no longer allows us to define unused variables.
Configure now always checks for C++ compiler even if it is not
used, since automake thinks this is the Right Thing To Do and
will break otherwise.

Platforms tested:
Sol, copper, heping, mir, sleipnir, eirene, pommier, kelgia, modi4.
2005-03-07 12:57:27 -05:00
Quincey Koziol
afdf7fcfa6 [svn-r10144] Purpose:
Bug fix

Description:
    The GASS VFL driver header file was bringing in the <string.h> header file,
which several other source code modules needed also, but weren't including
explicitly themselves.

Solution:
    Add includes for <string.h> to files which actually need them.

Platforms tested:
    FreeBSD 4.11 (sleipnir) w/C++ as CC
    Configuration not tested by h5committest...
2005-03-04 12:01:02 -05:00
Albert Cheng
5c990d854e [svn-r10136] Purpose:
Bug fix.

Description:
MPI_LONG_LONG, which is not standard yet, was used to pass the
nubmer of differences found.  This was needed because number of
differences is defined as type hsize_t which can be arbitary large
such that there is no MPI type that matches it. The value is passed
between processes as an array of bytes in order to be portable.  But this
may not work in non-homogeneous MPI environments.
This fix was actually Leon's idea.

Platforms tested:
Tested in QSC in which this failed.
2005-03-03 17:29:07 -05:00
Albert Cheng
0d514907a9 [svn-r10123] Purpose:
Removed GASS configuration and software packages associated with
it.  The following software are no longer configurable.

checking for main in -lcrypto... yes
checking for SSL_get_version in -lssl... yes
checking globus_common.h usability... yes
checking globus_common.h presence... yes
checking for globus_common.h... yes
checking for globus_module_activate in -lglobus_common... yes
checking for main in -lglobus_gass_cache... yes
checking for main in -lglobus_gaa... yes
checking for main in -lglobus_gss... yes
checking for main in -lglobus_gss_assist... yes
checking for main in -lglobus_io... yes
checking for main in -lglobus_gass_transfer_assist... yes
checking for main in -lglobus_gass_transfer... yes
checking for globus_gass_open in -lglobus_gass_file... yes

Platforms tested:
h5committested (but copper was down.) tested in modi4 too.
2005-03-02 15:02:55 -05:00
James Laird
0b83fea125 [svn-r10066] Purpose:
Libtool upgrade

Description:
HDF5 was using libtool 1.4.2.  Upgraded to libtool 1.5.14.

Platforms tested:
verbena, heping, pommier, copper, modi4, arabica
2005-02-23 11:47:00 -05:00
Albert Cheng
4d64b08030 [svn-r10029] Purpose:
bug fix.

Description:
When MPE library is used, it prints two extra message lines that
interfere with the expected output.

Solution:
Filter out those two lines of text from stderr.
Also added a provision to print the whole generated output when failure
is detected.

Platforms tested:
Tested in copper, serial, parallel and parallel with MPE.

Misc. update:
2005-02-17 11:14:20 -05:00
Xiaowen Wu
e358c94649 [svn-r10027] Purpose:
New feature.

Description:
    Add the scaleoffset internal library filter.

Solution:

Platforms tested:
     heping, copper, arabica

Misc. update:
2005-02-16 22:17:48 -05:00
Albert Cheng
489f234316 [svn-r10017] Purpose:
bug fix/new feature.

Description:
(committing changes made by Leon.)
ph5diff now is a real program by itself.  It has its
own main (ph5diff_main.c).
Codes common to h5diff and ph5diff are in h5diff_common.c.

Removed the hack that hide failures from testh5diff.sh.

Platforms tested:
heping(serial, pp), sol (pp), copper(pp).

Misc. update:
2005-02-16 15:20:40 -05:00
James Laird
8ed95c0011 [svn-r10016]
Purpose:
Bug fix

Description:
modi4 dies during build with strange errors.
The root cause of these is a two-year-old hack in HDF5's libtool
script that only takes effect on IRIX.

Solution:
Edited the libtool hack (by editing ltmain.sh) to correct a bug in
the hack.
Also made sure that compiler-specific DEFAULT_LIBS are used
when linking.

Platforms tested:
sleipnir, copper, modi4, sol
2005-02-16 14:27:27 -05:00
Albert Cheng
ee61bd3c0f [svn-r10007] Purpose:
Bug fix.

Description:
ph5diff is still being fixed.
Changed this to report all failures but will not flag them as
errors so that daily tests can continue.  Will be fixed soon.

Platforms tested:
Tested in sol (pp) where it has most failures.

Misc. update:
2005-02-15 13:03:04 -05:00
Leon Arber
e1ffee4e4e [svn-r9998]
Purpose:
Bug fix

Description:
Fixed the error on copper where output would match, except the worker tasks are forcefuly terminated at the end.

Solution:
If an exit code other than 0 was returned, the
parallel environment would assume that there
was an error and would terminate all other
tasks.  Because h5repack relies on the return
value of h5diff, it was necessary to return
values other than 0.  Fixed by having parallel
runs of h5diff always return 0, whereas the
return value of serial runs is unchanged.


Platforms tested:
copper

Misc. update:
2005-02-13 18:47:54 -05:00
James Laird
b96f342722 [svn-r9993] Purpose:
Bug fix

Description:
Arabica exhibited strange errors when linker found wrong versions of
header files.  This happened because include directories were
given to linker in the wrong order.

Solution:
Move include directories from AM_CFLAGS variable to INCLUDES
variable to put them before CPPFLAGS variable.  Trust me, it works.
This bug may also have contributed to strange errors on other platforms
(kelgia?).

Platforms tested:
copper, sleipnir, arabica.
	(h5dump broke while building on arabica, but this happened in
	a clean checkout, too).
2005-02-11 16:32:22 -05:00
James Laird
3f0a35a4ea [svn-r9988] Purpose:
Bug fix

Description:
pmake (on modi4, for instance) complains about undefined variables
if it is run without the -V flag, which turns those errors to warnings.

Solution:
Added test to configure.in to see if $MAKE will allow Makefiles
with undefined variables.  If not, sets -V flag in AM_MAKEFLAGS.
Ensured that all custom make targets use AM_MAKEFLAGS.
Also defined all variables that caused errors in top-level Makefile.am.
This means that pmake can be used to build hdf5 *from the top level
only*.  To run make from a subdirectory, still need to use -V flag
(or use make or gmake).

Platforms tested:
modi4, heping, copper, sleipnir
2005-02-11 12:40:52 -05:00
Albert Cheng
9825b4b57b [svn-r9980] Purpose:
bug fix.

Description:
Need eval before the RUNCMD command because some machines like
AIX, has RUNPARALLEL in the style as
   MP_PROCS=3 MP_TASKS_PER_NODE=3 poe ./a.out
that throws the shell script off.

Platforms tested:
Tested in copper (pp) where it failed before.
Tested in heping pp too.

Misc. update:
2005-02-10 15:31:18 -05:00
Albert Cheng
2065c392ab [svn-r9979] Purpose:
Bug fixed.

Description:
Heping used to have a network limit that if too many rsh connections
occurred in a second, it stopped accepting connections for 30 seconds.
That caused testph5diff to fail when too many mpi jobs are executed
repidly.  A sleep 2 was in to go around this problem.  Heping's limit
has been raised, thus no more need for this hack.  Sleep 2 is removed.

Platforms tested:
Tested in heping (pp).

Misc. update:
2005-02-10 13:55:47 -05:00
Leon Arber
c7f2d5c41e [svn-r9969] Purpose:
Correction to previous print_manager_output bugfix

Description:
Although the previous bugfix did fix all the errors, it was not the correct way
to fix the problem.  Since the manager will only buffer output when run in
parallel mode, in serial mode this function should not even be called.

Solution:
Wrapped print_manager_output in #define's to prevent it from being included in
serial builds.


Platforms tested:
heping (serial + parallel)

Misc. update:
2005-02-09 13:19:54 -05:00
Pedro Vicente Nunes
81cfafde89 [svn-r9968]
Purpose:
bug fix

Description:
a string with 2 characters was declared as having size 2. changed to size 3 (+ null character)
this was causing compiler warnings with g++

Solution:

Platforms tested:
linux
free bsd (g++)






Misc. update:
2005-02-09 11:01:53 -05:00
Leon Arber
2183c5971a [svn-r9956] Purpose:
Fixed numerous ph5diff bugs.

Description:
Fixed manager output printing
Fixed out of order output printing
Fixed test script execution problem
Temporary fix for large amounts of output overflowing buffer.

Solution:
The manager task buffers its output.  However, since the manager task
never gets a print token, this output was lost.  Solution: new function called
print_manager_output that prints buffered output is called in places where the
manager buffers its output.

printf was apparently buffering output.  This means that a task would sometimes
print even after it had given up its print token.  Added fflush() call after
printf() calls, which seems to have fixed the problem.

calling rsh multiple times in succession seems to overwhelm something in Linux,
as it begins to refuse new connections until the old ones reset.  Since each
call to mpirun in the test script starts up 4 rsh sessions, the test script
eventually is unable to run any further tests.  Solution: Added a short delay in the
testscript between successive calls to mpirun to allow old connections to reset.

The 10k output buffer was of insufficient size to hold the large amounts of
output generated by some of the tests.  Since code to buffer to a file has not
been implemented yet, a temporary fix was to increase the size of the output
buffer to 50k.

Platforms tested:
heping

Misc. update:
2005-02-08 00:42:49 -05:00
Albert Cheng
6a7a80135d [svn-r9949] Purpose:
Bug fix

Description:
h5diff sometimes will 'exit(status)' but if it is in parallel mode,
it needs to close up the workers and the MPI environment before exit(..).

Solution:
Created h5diff_exit() that will just exit in serial mode but does all
the shutdown properly if in parallel mode.

Platforms tested:
tested in heping, serial and parallel.

Misc. update:
2005-02-06 21:11:31 -05:00
Albert Cheng
70f7afdb36 [svn-r9945] Purpose:
Bug fix

Description:
h5diff_main.c contained some debug printf statment that produced
unexpected output. Commented them out.

testh5diff.sh: implemented code to test ph5diff tests but
ph5diff has some errors that generated unexpected output.
Temporary hacked to skip tests if run by daily test account.

Platforms tested:
Tested in heping, serial and parallel.
2005-02-05 23:16:08 -05:00
Albert Cheng
d9c9a573fb [svn-r9931] Purpose:
new features

Description:
Added a parallel option to testh5diff.sh to do parallel h5diff tests.
Added testph5diff.sh to invoke testh5diff.sh with parallel mode.

Platforms tested:
Tested in heping (serial and pp).
2005-02-03 23:13:37 -05:00
Albert Cheng
5186398930 [svn-r9929] Purpose:
Features

Description:
Added the option to build ph5diff and run testphdf5.sh when
parallel mode is enabled.

Platforms tested:
tested in heping, both serial and parallel.

Misc. update:
2005-02-03 16:03:24 -05:00
Quincey Koziol
0b332ace5e [svn-r9928] Purpose:
New feature

Description:
    Add basic code for new B-tree implementation.  They don't do much yet,
aren't hooked up to anything yet and the format may change, but I'd like to
start getting them into the daily tests.

Platforms tested:
    FreeBSD 4.11 (sleipnir) w/parallel
    Too minor to require h5committest
2005-02-03 14:59:05 -05:00
Leon Arber
8af1385939 [svn-r9925] Purpose:
Bug Fix

Description:
Permanent fix for the incompatibilities between h5diff and h5repack.

Solution:
h5diff now contains the code to run both parallel and serial diffs.
Depending on how the binary is called, it will run either the serial or
the parallel versions respectively.


Platforms tested:
heping(serial + parallel), copper.


Misc. update:
2005-02-02 18:01:42 -05:00
James Laird
ab243bf369 [svn-r9920] Purpose:
Bug fix

Description:
Found the permanant fix to automake/CVS dependency problem

Solution:
Added AM_MAINTAINER_MODE macro to configure.in.
Now automake will never try to regenerate Makefiles, Makefiles.in,
configure, H5config.h, etc. when they are out of date, nor will it
print any warnings.
Developers should  be very very careful to use reconfigure script,
and can add --enable-maintainer-mode flag to configure on heping
to regenerate these files correctly.

Platforms tested:
heping sleipnir copper
2005-02-02 15:59:46 -05:00
James Laird
ed8685acd2 [svn-r9915] Purpose:
Bug fix

Description:
Configuration files' timestamps were incorrect.

Solution:
Update Makefiles.in.  Also added correct paths to autotools on heping,
so heping build should be able to re-generate configuration files even
if they are still broken.

Platforms tested:
sleipnir
2005-02-02 11:00:36 -05:00
James Laird
e3dacb31be [svn-r9912] Purpose:
Bug fix

Description:
Dependencies between configure files (aclocal, configure.in, configure,
Makefiles.am and .in) are still causing Makefiles to try to run autotools
during build.

Solution:
Committed all Makefiles.in to update their timestamps.
As a temporary measure, forcibly prevented automake from running
autotools during build by redefining the variables it uses.

Platforms tested:
sleipnir (No changes to Makefile content)
2005-02-01 16:05:33 -05:00
James Laird
30bfb1e0ea [svn-r9907] Purpose:
Bug fix

Description:
Different compilers use different flags to include Fortran module files

Solution:
Changed boilerplate to use configure variable rather than hardcoded -M flag.

Platforms tested:
sleipnir, sol, copper
2005-02-01 10:27:37 -05:00
James Laird
26303241fe [svn-r9902] Purpose:
Configuration feature

Description:
HDF5 now uses automake to generate Makefiles

Solution:
Makefile.in files are now generated from Makefile.am files.
To reconfigure (after chaning a Makefile.am or configure.in):
/bin/sh bin/reconfigure.sh

Platforms tested:
Many
2005-01-31 22:17:02 -05:00
Albert Cheng
9a0ecd6f74 [svn-r9893] Purpose:
Temporary daily tests fix.

Description:
The newly added ph5diff is not quite compatible with the h5repack tool.
Disabled the ph5diff build (reverted back to building serial h5diff)
to allow daily tests to work while ph5diff is fixed.

Platforms tested:
Tested in heping both serial and parallel modes.

Misc. update:
2005-01-31 00:04:19 -05:00
Leon Arber
839f1092da [svn-r9877] Purpose:
Bug fix: Temporary fix for h5repack failures in all parallel builds.

Description:
The parallel additions to h5diff interfered with h5repack.

Solution:
Added a second set of "parallel" functions to h5diff.c.  h5repack uses the serial versions, whereas h5diff will use the parallel versions.

Also, h5diff will now be smart about when to enter parallel mode.  If is run with mpirun with more than 1 task, it will enter parallel mode.  Otherwise, it will stay in serial mode as before.

Platforms tested:
heping (serial and parallel)

Misc. update:
2005-01-27 18:21:05 -05:00
Albert Cheng
42754e6246 [svn-r9872] Purpose:
New feature.

Description:
Added new tool ph5diff. (Code done by Leon Arber.)
Code is changed but test is not working yet. For now,
it skipped all tests.

Platforms tested:
Tested in heping, serial and parallel modes.
2005-01-26 18:03:29 -05:00
Quincey Koziol
084ed88137 [svn-r8983] Purpose:
Update dependencies

Description:
    Update dependencies after config/depend1.in bugfix

Platforms tested:
    FreeBSD 4.10 (sleipnir) w/parallel
    IRIX64 6.5 (modi4)
    h5committested
2004-08-02 09:06:07 -05:00
Pedro Vicente Nunes
4cb6c01d7f [svn-r8904] Purpose:
h5diff and h5repack changes

Description:
h5diff
introduced the following four modes of output:
 Normal mode: print the number of differences found and where they occured
  Report mode: print the above plus the differences
   Verbose mode: print the above plus a list of objects and warnings
    Quiet mode: do not print output (h5diff always returns an exit code of 1 when differences are found)

    h5repack
     added an extra parameter for SZIP filter (coding method)
     the new syntax is
     -f SZIP=<pixels per block,coding>
     (pixels per block is a even number in 2-32 and coding method is 'EC' or 'NN')
     Example of use:
     ./h5repack -i file1 -o file2 -f SZIP=8,NN -v

     updated usage messages, test scripts and files accordingly




Solution:

Platforms tested:
linux
AIX
solaris

Misc. update:
2004-07-20 14:21:03 -05:00
Raymond Lu
dd03ef3f27 [svn-r8581] Purpose: new test
Description:  Add test of null dataspace for dataset and attribute in h5repack.


Platforms tested:  RH8(fuss).  Simple change, only h5repack is involved.
2004-05-26 14:43:42 -05:00
Raymond Lu
8ea1793569 [svn-r8578] Purpose: new test
Description:  Add null dataspace test for dataset and attribute to h5diff


Platforms tested:  RH 8(fuss).  Simple change, only h5diff is involved.
2004-05-26 10:46:19 -05:00
Quincey Koziol
583bdf994c [svn-r8495] Purpose:
Bug fixes

Description:
    Updated dependencies

    Fixed error with C++ compiler builds of main library

    Added H5Pset_data_transform to MPE info

Platforms tested:
    FreeBSD 4.9 (sleipnir)
2004-05-08 09:48:42 -05:00
Quincey Koziol
0a29514b9d [svn-r8383] Purpose:
Code cleanup

Description:
    Clean up lots of warnings based on those reported from the SGI compilers
as well as gcc.

Platforms tested:
    SGI O3900, IRIX64 6.5 (Cheryl's SGI machine)
    FreeBSD 4.9 (sleipnir) w/ & w/o parallel
    h5committest
2004-04-17 23:10:09 -05:00
Pedro Vicente Nunes
8eb5f818ba [svn-r8286] Purpose:
bug fix continuation

Description:
the atof return value on a hexadecimal input is different
 on some systems; before checking for the atof return value
 do  a character check for the first 2 characters of the string input



Solution:

Platforms tested:
linux
solaris

Misc. update:
2004-03-29 11:53:52 -05:00
Pedro Vicente Nunes
2e44c48936 [svn-r8283] Purpose:
bug fix (sort of)

Description:
apparently linux and other systems (solaris) return a different value from atof if the
argument is in  hexadecimal .
this return value was used to test if the argument to -p and -d was a valid floating point
number
for now , commented the calls in the script with -p <hexa> until we find a portable solution

Solution:

Platforms tested:
linux
solaris
windows

Misc. update:
2004-03-26 11:20:48 -05:00
Pedro Vicente Nunes
1b008c03aa [svn-r8282] Purpose:
bug fix

Description:
the -p option was not parsing correctly if the input was in the exponential format

Solution:
add a new parse test for floating point numbers

Platforms tested:
linux

Misc. update:
2004-03-25 15:27:47 -05:00
Pedro Vicente Nunes
a9c0f6f616 [svn-r8226] Purpose:
removed a print of a new line

Description:

Solution:

Platforms tested:
linux

Misc. update:
2004-03-01 16:00:40 -05:00
Quincey Koziol
2d8964517b [svn-r8128] Purpose:
Update dependencies after restructuring of MPI stuff
2004-01-30 21:32:19 -05:00
Albert Cheng
aaff647518 [svn-r7914] Purpose:
Regenerate the Dependencies files if needed.

Description:

Solution:

Platforms tested:

Misc. update:
2003-12-05 10:39:53 -05:00
Pedro Vicente Nunes
967a04fdec [svn-r7912] Purpose:
code clean, bug fix

Description:
the attributes of the root group were not being compared
removed compiler warnings on IRIX and solaris

Solution:
added a special function to compare the attributes of the root group

Platforms tested:
linux
IRIX 6.5
solaris 2.7

Misc. update:
2003-12-04 10:31:05 -05:00
Pedro Vicente Nunes
2d011283a3 [svn-r7908] Purpose:
code clean, bug fix

Description:
cleaned warnings on IRIX
fixed bug in parse command line

Solution:

Platforms tested:
linux
IRIX 6.5 64

Misc. update:
2003-12-03 10:35:32 -05:00
Pedro Vicente Nunes
486c13d307 [svn-r7904] Purpose:
h5diff new features

Description:
added comparison for attributes
adeded comparison for all dataset datatypes
added tests for the new features
changed the output format

Solution:

Platforms tested:
linux
solaris 5.7
IRIX 6.5 (64)

Misc. update:
2003-12-02 18:13:27 -05:00
Pedro Vicente Nunes
75a5e8a0e6 [svn-r7813] Purpose:
h5diff new feature


Description:

added compare for attributes
a new options flag (-a) was added to the options structure. it is 0 by default (no compare )
the output of the compare is the same that for datasets, and all the other flags also apply for attributes
(the memory compare is done in the same function diff_array)
all the other requirements for compare of datasets (type, space) are identical too




Platforms tested:
linux
solaris 2.7
IRIX


Misc. update:
2003-11-03 17:10:57 -05:00
Pedro Vicente Nunes
61d964625e [svn-r7804] Purpose:
h5diff new feature

Description:
added diff for the class ENUM

Solution:

Platforms tested:
linux
solaris 2.7
IRIX

Misc. update:
2003-10-31 16:18:09 -05:00
Pedro Vicente Nunes
8b45b9a5f0 [svn-r7785] Purpose:
h5repack new features


Description:
added a copy routine for all types
added a copy routine for attributes
commnented some debug messages in h5trav
added the verbose option to some h5diff messages


Platforms tested:
linux
solaris 2.5
IRIX


Misc. update:
2003-10-29 12:46:11 -05:00
Bill Wendling
0a2a91f24a [svn-r7777] Purpose:
Regenerated

Description:
    Regenerated Dependencies files because of changes to the h5diff and
    tools library.

Platforms tested:
    Linux (small change and just needed to be checked once).
2003-10-28 15:52:00 -05:00
Pedro Vicente Nunes
5bcb1054d1 [svn-r7774] Purpose:
changed the name of one struct in this file



Platforms tested:
linux,
solaris
IRIX

Misc. update:
2003-10-28 13:22:05 -05:00
Pedro Vicente Nunes
f2b52777f4 [svn-r7769] Purpose:
moved h5diff "public API" routines to tools/lib folder



Platforms tested:
linux
solaris 2.7
IRIX

Misc. update:
2003-10-28 12:40:05 -05:00
Pedro Vicente Nunes
ac104ba0a7 [svn-r7706] Purpose:
h5diff now has a .h file. which I forgot to CVS add previously






Misc. update:
2003-10-22 16:56:21 -05:00
Pedro Vicente Nunes
ce5c245a95 [svn-r7702] Purpose:
h5diff maitainance


Description:
separated the h5diff source between several modules
there is a public module with a new function "h5diff" that can be called by an application
program (h5repack will use it )
added a new verbose option that can turn off all printf



Platforms tested:
linux
solaris
IRIX


Misc. update:
2003-10-22 16:30:19 -05:00
Quincey Koziol
e2518919c9 [svn-r7626] Purpose:
Update dependencies and tracing information

Platforms tested:
    Linux 2.4 (verbena) w/FORTRAN
    too minor for h5committest
2003-10-14 10:46:38 -05:00
Quincey Koziol
c58d85f10e [svn-r7527] Purpose:
Code cleanup

Description:
    Clean up a few loose ends and warnings for the 1.6 compatibility changes
to the error API.

Platforms tested:
    FreeBSD 4.9 (sleipnir)
    too minor to require h5committest
2003-09-30 11:20:46 -05:00
Albert Cheng
6d647e5406 [svn-r7418] Purpose:
bug fix

Description:
h5diff would incur a segmentation fault in Alpha clusters when
the percentage option is used.  This was due to memory aliagment
issue when the options variable is declared as a local variable
in main().

Moved the declaration to a global declaration.

Platforms tested:
"h5committested"
And tested at cluster QT of SNL.

Misc. update:
2003-08-27 10:27:56 -05:00
Quincey Koziol
32220914a5 [svn-r7401] Purpose:
Code cleanup

Description:
    Remove various "fixtype" routines which duplicate (and actually pre-date)
    the functionality in H5Tget_native_type in favor of having the tools call
    H5Tget_native_type().  This provides the same functionality (actually better
    functionality, since the old "fixtype" routines didn't handle alignment of
    compound fields correctly) and reduces the amount of code to maintain.

    Add additional tests to dump out a "complex" compound datatype which
    exercises more code in the library for aligning compound fields correctly.

Platforms tested:
    FreeBSD 4.8 (sleipnir)
    h5committest
2003-08-25 15:00:56 -05:00
Quincey Koziol
500b5f904f [svn-r7389] Purpose:
Code cleanup

Description:
    Return -1 for failed group iteration instead of 1

Platforms tested:
    FreeBSD 4.8 (sleipnir)
    h5committest
2003-08-22 08:45:40 -05:00
Albert Cheng
374ad0ef30 [svn-r7361] Description:
Updated the copyright notice--mostly by rearranging
some text to make them consistent.

Solution:

Platforms tested:
"h5committested"--sol is down, so, no SUn test.

Misc. update:
2003-08-13 23:58:29 -05:00
Quincey Koziol
7f119036d3 [svn-r7352] Purpose:
Updated dependencies

Platforms tested:
    h5committested
2003-08-12 20:50:11 -05:00
Quincey Koziol
a91e5a22c4 [svn-r7323] Purpose:
Refactored code

Description:
    Added 'unsigned flags[2]' field and changed 'objno' field from 'unsigned
long[2]' to 'haddr_t' (to reflect changes in H5G_stat_t)

Platforms tested:
    h5committested
2003-08-08 14:31:37 -05:00
Quincey Koziol
64b045691c [svn-r7322] Purpose:
Refactored code

Description:
   Use H5E_BEGIN_TRY/H5E_END_TRY macros around blocks where errors shouldn't
be printed, instead of managing 'automatic error' information.

    Use new 'flags' field in table objects where appropriate

    Chase changes to 'fileno' and 'objno' fields of H5G_stat_t

Platforms tested:
    h5committested
2003-08-08 14:30:19 -05:00
Quincey Koziol
21c1f05808 [svn-r7321] Purpose:
Code cleanup & refactoring

Description:
    Use H5E_BEGIN_TRY/H5E_END_TRY macros around blocks where errors shouldn't
be printed, instead of managing 'automatic error' information.

    Changes to use new 'flags' fields in the table of objects, since the 'objno'
field can't be [ab]used any longer.

Platforms tested:
    h5committested
2003-08-08 14:27:54 -05:00
Raymond Lu
0d22a663df [svn-r7265] *** empty log message *** 2003-07-25 21:55:47 -05:00
Pedro Vicente Nunes
77f6e46b81 [svn-r7257] Purpose:
bug fix

Description:
if the user incorrectly put the option -n20 (instead of -n 20) as the last argument
h5diff tried to parse the 20 as an extra argument, causing a failure

if ('-' !=argv[i+1][0] )


Solution:
add an extra test for the case that option is the last argument

if ( i<argc-1 && '-' !=argv[i+1][0] )


Platforms tested:
linux . this is too trivial for all platforms test




Misc. update:
2003-07-23 13:52:18 -05:00
Bill Wendling
3e297166b8 [svn-r7124]
Purpose:
	Bug Fix

Description:
	LIBTOOLS macro was being used but not defined.

Solution:
	Removed the LIBTOOLS macro as it wasn't necessary

Platforms tested:
	Modi4 (small fix)

Misc. update:
2003-06-30 11:59:27 -05:00
Bill Wendling
6c41212cc4 [svn-r7123] Purpose:
Bug Fix

Description:
    The SUBDIRS macro is now defined as "" in the config/commence.in
    file. We shouldn't have definitions of this macro before the
    inclusion of config/commence.in.

Solution:
    Placed all definitions of SUBDIRS after config/commence.in inclusion.

Platforms tested:
    Modi4 (Small fix yet again).

Misc. update:
2003-06-30 11:26:46 -05:00
Quincey Koziol
2629b6e4d3 [svn-r7109] Purpose:
Code cleanup

Description:
    Clean up varios compiler warnings flagged by SGI compiler and gcc 3.3

Platforms tested:
    FreeBSD 4.8 (sleipnir)
    h5committest
2003-06-25 21:10:33 -05:00
Quincey Koziol
df5ca0fa1d [svn-r7002] Purpose:
Code cleanup

Description:
    Clean up warnings about unused stuff...

Platforms tested:
    FreeBSD 4.8 (sleipnir)
    h5committest
2003-06-09 14:18:47 -05:00
Quincey Koziol
bdf3620e62 [svn-r6962] Purpose:
Code cleanup

Description:
    Update dependencies and tracing information

Platforms tested:
    h5committested
2003-06-04 15:25:43 -05:00
Pedro Vicente Nunes
12b00a5dd4 [svn-r6947] Purpose:
added some comments

Description:

Solution:

Platforms tested:
linux

Misc. update:
2003-06-03 10:50:19 -05:00
Pedro Vicente Nunes
6273d8beee [svn-r6943] Purpose:
bug fix

Description:
unsigned integers were not printed out correctly

Solution:
added %u and %lu to the list of formats

Platforms tested:

Windows 2000 (octopus)
Linux 2.4 (rockaway)
SunOS 5.7 (arabica)
IRIX 6.5 (modi4)




Misc. update:
2003-06-02 11:30:40 -05:00
Pedro Vicente Nunes
614490a83a [svn-r6928] Purpose:
h5diff support for long_long

Description:
added h5diff support for long_long;

No automatic test was added because
it seems that the printf format of long_long is  slightly different in Linux and IRIX(modi4),
because the diff command complained about a difference in the 2 test files for long_long;
visually, it seems that in IRIX an extra space is added after the print (or maybe it is
just me that is seeing extra spaces :=)
this test is test 5.8,  commented in testh5diff.sh





Platforms tested:
Windows 2000 (octopus)
Linux 2.4 (rockaway)
SunOS 5.7 (arabica)
IRIX 6.5 (modi4)




Misc. update:
2003-05-30 17:38:46 -05:00
Pedro Vicente Nunes
4eb8aa7d83 [svn-r6925] Purpose:
bug fix

Description:
the signed / unsigned comparison was not properly handled.
the fixtype function sets the sign for the memory type the same sign as found on disk
and the array_diff function only handled signed cases

Solution:
addded for each INTEGER size type an OR condition with the unsigned version
if the datatypes have different signs , comparison is NOT supported


Platforms tested:

Windows 2000 (octopus)
Linux 2.4 (rockaway)
SunOS 5.7 (arabica)
IRIX 6.5 (modi4)


Misc. update:
2003-05-29 16:53:46 -05:00
Elena Pourmal
6790a626c8 [svn-r6915]
Purpose: bug fix for Tru64 and test of the latest szip library.

Description: h5diff uses basename function that also is defined
             in the system string.h file. That caused compilation to
             fail.

Solution:  renamed basename to h5diff_basename

Platforms tested: verbena, arabica, arabica-64,
                  and PSC Compaq machine.

Misc. update:
2003-05-22 17:41:27 -05:00
Pedro Vicente Nunes
68caabdfd5 [svn-r6911] Purpose:
made the test file to compare be created if it does not exist

Description:

Solution:

Platforms tested:

Misc. update:
2003-05-22 17:22:02 -05:00
Pedro Vicente Nunes
eaf0b25546 [svn-r6897] Purpose:
fixed a typo on the usage message, redone the test files that deal with with

Description:

Solution:

Platforms tested:
Windows 2000 (octopus)
Linux 2.4 (rockaway)
SunOS 5.7 (arabica)
IRIX 6.5 (modi4)




Misc. update:
2003-05-19 11:14:26 -05:00
Pedro Vicente Nunes
17d0b72815 [svn-r6894] Purpose:
changes of input/ output  format

Description:
on web page /RFC/h5diff

Solution:

Platforms tested:

Windows 2000 (octopus)
Linux 2.4 (rockaway)
SunOS 5.7 (arabica)
IRIX 6.5 (modi4)


Misc. update:
2003-05-19 00:09:08 -05:00
Pedro Vicente Nunes
a23049f488 [svn-r6849] Purpose:
changed algorythm

Description:
changed the array_diff function to increment the read buffer with a size selected
by an appropriate native data type.
previously it was assumed, e.g. int size = 4 bytes

Solution:

Platforms tested:

Linux 2.4 (rockaway)
SunOS 5.7 (arabica, 64bit mode)
IRIX 6.5 (modi4)


Misc. update:
2003-05-12 12:10:27 -05:00
Pedro Vicente Nunes
f2c1d0e162 [svn-r6844] Purpose:
bug fix

Description:
datasets with different storage datatypes where not read to memory to same size types

Solution:
obtain the memory type and size, for the TWO datasets ,
with the "fixtype" function
"upgrade" the smaller size to the larger if they are different
added H5DIFF_DEBUG flag for print information

Platforms tested:
Linux 2.4 (rockaway)
SunOS 5.7 (arabica, 64bit mode)
IRIX 6.5 (modi4)



Misc. update:
2003-05-10 14:38:57 -05:00
Pedro Vicente Nunes
401c1bc318 [svn-r6827] Purpose:
added new test files for h5diff
bug fix

Description:
the criteria for determining the correct switch case cast to void* to type* was the data size read from disk.
this was causing problems on Cray T3E, where all integer except char are 8 bytes long

Solution:
changed the criteria for using the memory size instead, which is determined by the same function
that reads the data into memory

the messages " using memory NATIVE_TYPE_X" were  removed, because they might not coincid on different
platforms.

Platforms tested:
Linux 2.4 (rockaway)
SunOS 5.7 (arabica)
IRIX 6.5 (modi4)


Misc. update:
2003-05-07 17:28:09 -05:00
Quincey Koziol
43e3b45021 [svn-r6825] Purpose:
New feature/enhancement

Description:
    Chunked datasets are handled poorly in several circumstances involving
certain selections and chunks that are too large for the chunk cache and/or
chunks with filters, causing the chunk to be read from disk multiple times.

Solution:
    Rearrange raw data I/O infrastructure to handle chunked datasets in a much
more friendly way by creating a selection in memory and on disk for each chunk
in a chunked dataset and performing all of the I/O on that chunk at one time.

    There are still some scalability (the current code attempts to
create a selection for all the chunks in the dataset, instead of just the
chunks that are accessed, requiring portions of the istore.c and fillval.c
tests to be commented out) and performance issues, but checking this in will
allow the changes to be tested by a much wider audience while I address the
remaining issues.


Platforms tested:
    h5committested, FreeBSD 4.8 (sleipnir) serial & parallel, Linux 2.4 (eirene)
2003-05-07 16:52:24 -05:00
Pedro Vicente Nunes
180b83bbbe [svn-r6801] Purpose:
h5diff update

Description:
removed the -l , list, option
this feature will be part of a different tool

Solution:

Platforms tested:
Windows 2000 (octopus)
Linux 2.4 (rockaway)
SunOS 5.7 (arabica)
IRIX 6.5 (modi4)




Misc. update:
2003-05-05 22:29:39 -05:00
Pedro Vicente Nunes
b0880f9331 [svn-r6789] Purpose:
new feature

Description:
during the sequencial match list, by default the differences between matched datasets were printed.
added an -m option that allows to turn this off, just printing the file differences

Solution:

Platforms tested:
Linux 2.4 (rockaway)
SunOS 5.7 (arabica)
IRIX 6.5 (modi4)



Misc. update:
2003-05-01 14:57:56 -05:00
Pedro Vicente Nunes
c37bcc12fc [svn-r6771] Purpose:
added more tests, described in the test matrix

Description:
test -r
test -l
expanded -d, -p and -n tests
test different types to include links and named types
test for non supported classes, e.g bitfield, opaque , etc

Platforms tested:
 Linux 2.4 (rockaway)
 SunOS 5.7 (arabica)
 IRIX 6.5 (modi4)

Misc. update:
2003-04-28 18:56:32 -05:00
Pedro Vicente Nunes
4147628137 [svn-r6700] Purpose:
added tests 1.7, 1.8, 1.9 described in the test matrix

Description:

Solution:

Platforms tested:

Linux/rockaway(C)
SunOS/arabica (C)
SGI/modi4 (C)


Misc. update:
2003-04-17 15:53:06 -05:00
Pedro Vicente Nunes
3bff6431c7 [svn-r6694] Purpose:
added some niceties and utilities, and more tests

Description:
some niceties: more error messages on cases of bad input
utilities: some functions to more human readable output
more tests: described in the test matrix


Platforms tested:

Linux/rockaway(C)
SunOS/arabica (C)
SGI/modi4 (C)
2003-04-17 11:50:56 -05:00
Pedro Vicente Nunes
2596820e38 [svn-r6626] Purpose:
added new tests
removed compiler warnings from unix platforms
changed usage message

Description:

Solution:

Platforms tested:
w2000, linux, arabica, modi4

Misc. update:
2003-04-09 22:16:17 -05:00
Pedro Vicente Nunes
7e723792ba [svn-r6599] Purpose:
code warrior port

Description:
replaced strdup with HDstrdup  for CW portability

Solution:

Platforms tested:
w2000(CW , MS)
linux
arabica
modi4

Misc. update:
2003-04-08 15:27:27 -05:00
Quincey Koziol
5d20142327 [svn-r6596] Purpose:
Code cleanup/bug fix

Description:
    Clean up files created during testing.

Solution:

Platforms tested:
    FreeBSD 4.8 (sleipnir)
    Linux 2.4 (eirene)

Misc. update:
2003-04-08 14:50:17 -05:00
Pedro Vicente Nunes
3bd39f60e0 [svn-r6588] Purpose:
added more tests to automatic testing

Description:
added test for an invalid option letter
added test for -h option
added test for an invalid option -d
added test for an invalid option -d number

Solution:

Platforms tested:
linux, solaris, sgi

Misc. update:
2003-04-04 14:42:26 -05:00
Pedro Vicente Nunes
d6f94bf8bd [svn-r6587] Purpose:
typo in usage message

Description:

Solution:

Platforms tested:
linux
Misc. update:
2003-04-04 13:54:37 -05:00
Quincey Koziol
a3a391d457 [svn-r6576] Purpose:
Cleanup

Description:
    Update dependencies.

Solution:

Platforms tested:
    Linux 2.4 (eirene)

Misc. update:
2003-04-03 08:46:11 -05:00
Pedro Vicente Nunes
febe7d0bd9 [svn-r6563] Purpose:
added test script for h5diff
code cleaning for alpha release
makefile now generates the h5difftst.c program that generates 2 .h5 files for testing

Description:
the .sh script runs several runs of h5diff and compares the output
with a predifined output located in /tools/testfiles (.txt files)
righ now it has only one test


Solution:

Platforms tested:
linux (other platforms later , ok !? )

Misc. update:
2003-04-02 13:44:12 -05:00
Bill Wendling
48eb3267ca [svn-r6541] Purpose:
Update

Description:
    Updated Copyright statements

Platforms tested:
    None needed...

Misc. update:
2003-03-31 13:06:44 -05:00
Pedro Vicente Nunes
5d51e5adeb [svn-r6526] Purpose:
update

Description:
clean code , removed empty spaces, tested on solaris

Solution:

Platforms tested:
w2000, linux, solaris

Misc. update:
2003-03-27 13:03:00 -05:00