Code cleanup.
Description:
Cleaned up an unusued variable and some commented out code.
Platforms tested:
FreeBSD 4.8 (sleipnir)
Triple check not needed.
Description: H5T_XXX_init_interface calls H5T_init_interface causing
datatype not closed after file is closed.
Solution: changed H5T_init_interface to H5T_init
Platforms tested: h5committest
added new test files for h5diff
bug fix
Description:
the criteria for determining the correct switch case cast to void* to type* was the data size read from disk.
this was causing problems on Cray T3E, where all integer except char are 8 bytes long
Solution:
changed the criteria for using the memory size instead, which is determined by the same function
that reads the data into memory
the messages " using memory NATIVE_TYPE_X" were removed, because they might not coincid on different
platforms.
Platforms tested:
Linux 2.4 (rockaway)
SunOS 5.7 (arabica)
IRIX 6.5 (modi4)
Misc. update:
New feature/enhancement
Description:
Chunked datasets are handled poorly in several circumstances involving
certain selections and chunks that are too large for the chunk cache and/or
chunks with filters, causing the chunk to be read from disk multiple times.
Solution:
Rearrange raw data I/O infrastructure to handle chunked datasets in a much
more friendly way by creating a selection in memory and on disk for each chunk
in a chunked dataset and performing all of the I/O on that chunk at one time.
There are still some scalability (the current code attempts to
create a selection for all the chunks in the dataset, instead of just the
chunks that are accessed, requiring portions of the istore.c and fillval.c
tests to be commented out) and performance issues, but checking this in will
allow the changes to be tested by a much wider audience while I address the
remaining issues.
Platforms tested:
h5committested, FreeBSD 4.8 (sleipnir) serial & parallel, Linux 2.4 (eirene)
Code Improvements/Bug Fixes
Description:
Comparison of equality of a double/float variable to 0.0 is not
guaranteed to work and is bad practice.
In H5Fcontig.c, a warning was given by a statement like:
x = (++x) % y;
This could be confusing to a compiler I suppose.
In H5RS.c, a typedef of a structure was being tagged by the compiler
as "useless" because it had the form:
typedef struct foo {
int var1;
/* ... */
}; /* <--- note no name for this typedef */
The statement "typedef struct foo foo" is already in the header file.
Solution:
Test that the absolute value of the variable is < a very small
positive number.
Changed "x = (++x) % y" to "++x; x %= y;" instead.
Removed the "typedef" from the structure in the H5RS.c file.
Platforms tested:
Modi4 (Parallel & Fortran)
Verbena (C++ & Fortran)
Arabica (Fortran)
Misc. update:
Code Improvements/Bug Fixes
Description:
Comparison of equality of a double/float variable to 0.0 is not
guaranteed to work and is bad practice.
Solution:
Test that the absolute value of the variable is < a very small
positive number.
Platforms tested:
Modi4 (Parallel & Fortran)
Verbena (C++ & Fortran)
Arabica (Fortran)
Misc. update:
Purpose: Cray T3E maintenance with Raymond's help
Description: fillval test failed for compact dataset since the
size of the dataset was bigger than 64K.
Solution: Reduced the dataspace of the compact dataset to 1024 elements.
Platforms tested: T3E; it was also tested with semi-manual h5committest.
(I had to built and test manually on modi4 parallel because
of some weird failure of h5committest on modi4)
Misc. update:
Purpose: Fortran updtae
Description: Created new functions h5pset(get)_fapl_mpiposix_f
Platforms tested: Compilation was tested with semi-manual h5committest.
(I ahd to built and test manullay on modi4 parallel because
of some weird failure of h5committest on modi4)
There are no tests yet for those functions. Kent was
going to use them in the MEAD project to test
the performance.
Misc. update:
Purpose: Maintenance for T3E
Description: Cray updated T3E to run unicosmk2.0.6.X
Configuration failed.
Solution: Created new unicosmk2.0.6.X files in the config and fortran/config
directories and added them to MANIFEST. I had to disable warning
# 412 for fortran compilation. The warning would prevent creation
of executable programs.
Platforms tested: Cray T3E
Misc. update:
Purpose: Maintenance for T3E
Description: Cray updated T3E to run unicosmk2.0.6.X
Configuration failed.
Solution: Created new unicosmk2.0.6.X files in the config and fortran/config
directories and added them to MANIFEST
Platforms tested: Cray T3E
Misc. update:
Purpose:
Update H5Zregister to describe new approach to filter management.
Description:
H5Zregister -- heavy revisions to reflect new filter-handling approach.
Added H5Z_class_t struct,
H5Z_can_apply_func_t callback function, and
H5Z_set_local_func_t callback function,
and rewrote much of the rest.
Platforms tested:
IE 5, Safari
Purpose:
Correction of a misleading comment.
Description:
h5cc & h5fc
Corrected the same spot in each "Description" where the text,
literally interpreted, implied that HDF5 could be used as a compiler.
Platforms tested:
IE 5, Safari
Purpose:
New feature -- h5fc
Description:
Added h5fc entry.
Took the opportunity to make some relatively minor copy edits and
grammatical corrections in h5cc entry.
Platforms tested:
Safari, IE 5
Update
Description:
Some of the TRACE macros were updated to reflect a new parameter.
Platforms tested:
Linux
Solaris w/ zlib
Irix w/ zlib
Misc. update:
Bug Fix
Description:
The "mkstemp()" function isn't as portable as I hoped it would be (it
fails on Crays and other beasts).
Solution:
Removed and just use a fixed filename instead.
Platforms tested:
Linux
Solaris w/ zlib
Irix w/ zlib
Misc. update:
code warrior fix
Description:
eliminate the CW failure on getname.c
restrict the H5_NO_FILE_SHARING just to the test file_close of testhdf5 test
Solution:
the CW failure on getname.c can be eliminated if a unmount of the file is made before closing it
on tfile.c the failure is due to the file sharing flag of CW, and the test is maintained as before
Platforms tested:
Windows 2000 (octopus)
Linux 2.4 (rockaway)
SunOS 5.7 (arabica)
IRIX 6.5 (modi4)
Misc. update:
Change
Description:
Instead of using the "USE_GPFS" macro, use the "H5_HAVE_GPFS" macro
which is defined during configuration and then use the new parameter
to the H5P{get,set}_fapl_mpiposix functions to control if GPFS is
enabled or not.
Platforms tested:
Modi4 (only affects the parallel stuff, so no need for full testing).
Misc. update:
Bug Fix
Description:
When I changed the H5P{set,get}_fapl_mpiposix functions to accept
another parameter, I didn't change it in these files.
Solution:
Added the new "use_gpfs" parameter.
Platforms tested:
Modi4 (only affects the parallel stuff, so no need for full testing).
Misc. update:
Revert last change (at least temporarily)
Description:
Revert last "NO_SHARED_WRITING" ifdefs after reviewing the tests that were
ifdef'ed out. I don't think that these tests should cause a problem, so I
would like them reviewed again to see if there is a file handle leak in the
library (or test).
Platforms tested:
FreeBSD 4.8 (sleipnir)
Triple check not needed.
Code restructure.
Description:
Restructured tests so they shouldn't depend on shared open()'s and can be
tested with CodeWarrior
Platforms tested:
FreeBSD 4.8 (sleipnir)
Triple check not needed.
h5diff update
Description:
removed the -l , list, option
this feature will be part of a different tool
Solution:
Platforms tested:
Windows 2000 (octopus)
Linux 2.4 (rockaway)
SunOS 5.7 (arabica)
IRIX 6.5 (modi4)
Misc. update:
code warrior port
Description:
added H5pubconf.h with H5_NO_SHARED_WRITING and new code warrior project without the fix
to enable shared writing in the open CW function
Solution:
Platforms tested:
CW
Misc. update:
code warrior port
Description:
added a flag H5_NO_SHARED_WRITING, it is defined only for CW in the H5pubconf.h
this avoids doing some tests for CW that fail on shared writing
Solution:
Platforms tested:
windows (cw and ms)
Linux 2.4 (rockaway)
SunOS 5.7 (arabica)
IRIX 6.5 (modi4)
Misc. update:
Feature
Description:
Added new flag to the H5pubconf.h file --- NO_SHARED_WRITING
(H5_NO_SHARED_WRITING). It's only defined for CodeWarrior and should
never be defined for other platforms unless the "open()" bug that CW
has shows up on other platforms.
Platforms tested:
Verbena. Configure only, so no need for full tests.
Misc. update:
Fix
Description:
Fortran's configure was trying to read the "README.txt" file from the
"$srcdir", where it won't be.
Solution:
Changed it to look in "$srcdir/.." for the "README.txt" file.
Platforms tested:
Verbena. Configure only, so no need for full tests.
Misc. update:
Feature Add
Description:
Added knob so that the programmer can enable or disable GPFS
hints during runtime instead of having it only enabled at
configure/compile time. Some of the public APIs were changed
to add an extra parameter for this option...
Platforms tested:
Blue (LLNL). It only affects the MPI/POSIX driver, so no need
to test it on non-GPFS platforms.
Misc. update:
Initial pass for gcc3.3 support
Description:
Added section for gcc 3.3+ and cleaned up the gcc 3.2+ section a little.
Platforms tested:
FreeBSD 4.8 (sleipnir) w/gcc 3.3 snapshot
Triple check unneeded.
Purpase: Fortran Windows DLL support
Description: Fortran test uses functions h5_fixname and h5_cleanup from h5test.c.
Those were not exported, and Fortran could not link while using DLLs.
Solution: Added H5_DLL to functions prototype to export them from C DLL.
Platforms tested: Windows, h5committested.
Misc. update:
Purpose: Maintenance/code cleanup/fight with Windows Fortran DLLs
Description: While strugling with Fortran DLLs on Windows I noticed
some missing export definitions that are necessary
for exporting correctly data and functions.
Solution: Added missing definitions
Platforms tested: h5committested; Windows with MSVC++ and Visual Fortran
on Windows. Fortran DLLs partially work, only 2 tests
fail, but failure doesn't make any sense. To make
things worse, most of the C DLL tests start to fail when
Fortran is built. I am still investigating...
Misc. update:
new feature
Description:
during the sequencial match list, by default the differences between matched datasets were printed.
added an -m option that allows to turn this off, just printing the file differences
Solution:
Platforms tested:
Linux 2.4 (rockaway)
SunOS 5.7 (arabica)
IRIX 6.5 (modi4)
Misc. update:
Update
Description:
Fixed description. Should be 1-byte instead of 1-bytes
Platforms tested:
Linux (Small change, no need for full checking)
Misc. update:
Feature Add
Description:
It's now possible to print out characters as actual characters
instead of their decimal equivalent numbers. It's the same thing that
h5ls does. The flag to do this is "--string" or "-r".
Platforms tested:
Verbena (Fortran & C++)
Arabica (Fortran)
Modi4 (Fortran & Parallel)
Misc. update:
Bug fix
Description:
"$@" was used to represent all argument provided. This has the
unfortunate effect as one argument of "" when actually no argument
was given. Some machines throw the "" away but some like Tflops
and Alpha Q, retains them as a single argument of "". This caused
the no filename given test to fail.
Solution:
Replaced "$@" with a plain $@.
Platforms tested:
h5committested
Misc. update:
Add a little more comments on where to put DLL.
Description:
User can put HDF5DLL in the place where the application can find.
It doesn't have to be at system directory.
Solution:
Add comments to "only suggest the user to use system directory".
Platforms tested:
text file, no need to be tested.
Misc. update:
Update stdio driver supported on windows
Description:
To tell users how to set and use stdio driver.
Solution:
Platforms tested:
Text file doesn't have to be tested.
Misc. update:
A bug fix for windows.
Description:
Many tests failed on windows when stdio driver is on.
I suspect it is the compiler bug.
After some investigation, the symptom is:
The signature of HDF5 file cannot be found.
The real problem is the signature was appended at the end of the whole
file instead of inserting at the starting of the file.
It seems when the file pointer(signature) is reset to the starting of the file,
windows mis-placed it to the end of the file after finding the file is close to
the end.
Solution:
Fortuately, ftell and fseek still function well on windows,
so I use ftell and fseek to force the file pointer to go to the position it is supposed
to go.
Platforms tested:
since the only change in this file is within ifdef WIN32 macro; it won't
affect the mainstream platforms, so I don't have to three platforms.
Platforms to confirm(test with basic function): Linux 2.4
Platforms to throughly test: windows 2000 with VS6.0
test on three different
Misc. update:
