Commit Graph

1772 Commits

Author SHA1 Message Date
Scot Breitenfeld
545484c743
fixed GNU 4.8.5 compilation issue with C_LOC and strings (#2996) 2023-05-23 11:16:43 -05:00
Scot Breitenfeld
a888742959
Updated H5Ovisit_f and H5Ovisit_by_name_f wrappers internals. (#2987)
* * Removed C wrappers for H5Ovisit_f and H5Ovist_by_name_f, modifying the Fortran source accordingly.

* The intent for op_data was declared INOUT, even though the pointer address INTENT is, in actuality, IN. gfortran was optimizing out op_data in tests where the values were repeatedly reset to the same value. The values were reset in the test because the data the pointer targeted was updated in the callback.

* Made use of the 'verify' function to check value correctness.

* changed to useing INTEGER(C_INT) instead of C_BOOL, updated the documentation
2023-05-22 16:17:14 -07:00
Dana Robinson
5c2e434dc6
Fix 'datatype' misspellings ('dataype') (#2984) 2023-05-19 09:05:23 -07:00
Scot Breitenfeld
482920808f
Fixes failures with gfortran 4.8 (#2979) 2023-05-18 16:07:24 -05:00
Scot Breitenfeld
560e7d6728
Updated INTENT to IN for C_PTR types dummy args. (#2961)
* Changed to INTENT(IN) for C_PTR dummy args since it refers to whether C_PTR can be changed and does not relate to the INTENT state of the target.
2023-05-17 10:38:31 -05:00
Scot Breitenfeld
e1f346377f
added missing H5ES function DLLs (#2969) 2023-05-17 10:34:10 -05:00
Scot Breitenfeld
20e72f98b2
addresses gfortran issue https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109861 (#2957) 2023-05-15 13:29:51 -05:00
Allen Byrne
4b228ec6af
Fix CMake generator expression syntax (#2909) 2023-05-05 15:57:40 -05:00
jhendersonHDF
44fafa4a84
Remove references to old MANIFEST file (#2890) 2023-05-03 13:24:14 -07:00
Scot Breitenfeld
41fd8e66a9
Fixed test failure for when REAL is promoted via a compiler flag (#2873) 2023-05-02 09:56:52 -07:00
Scot Breitenfeld
a0340338e5
Add Fortran Selection IO APIs (#2864)
new selection IO fortran APIs with tests
2023-05-01 15:21:47 -07:00
Dana Robinson
265494b5b9
Remove "the the" from comments and docs (#2865) 2023-05-01 09:06:39 -07:00
H. Joe Lee
443ef49ab6
Remove unused variable warning (#2828)
Polaris FORTRAN compiler reported the unused variable warning.
2023-04-28 09:08:59 -07:00
Scot Breitenfeld
def21b1e33
Added Fortran Async APIs (#2715)
H5A, H5D, H5ES, H5G, H5F, H5L and H5O async APIs were added.
2023-04-21 11:07:48 -05:00
Quincey Koziol
49a71463a0
Comment cleanup (#2689)
* Clean up content and redundant logging in comments.
2023-04-11 09:41:32 -05:00
Allen Byrne
cb679af19d
Make sure that ONLY_SHARED_LIBS option is correctly set (#2544) 2023-03-13 16:24:49 -05:00
Mark Kittisopikul
5d3d43b1ee
Fix new codespell issues (#2521)
* Fix new codespell issues

* Have codespell ignore ./config/sanitizer/sanitizers.cmake
2023-03-08 14:42:47 -06:00
Allen Byrne
32a54c0e2e
CMake generated pkg-config file is incorrect #2259 (#2476)
* CMake generated pkg-config file is incorrect #2259

* Fix fortran pc template

* hdf5.pc is incorrect for debug builds #1546

* Correct pkg name and lib name

* Fix typo

* Fix missing space
2023-02-17 14:17:17 -08:00
Quincey Koziol
06c12f97cd
Pass-through connector testing flexibility (#2399)
* Correct concurrency bugs when running tests, along with a bugfix & small
warning cleanup.

* Committing clang-format changes

* Allow spaces (and tabs) in VOL connector info string from environment variable.

* Parse connector name from HDF5_PLUGIN_PATH environment variable better

* Correct H5VLquery_optional to use H5VL routine instead of H5I.  Also add an
error message to the failure return value from not finding a plugin.

* Play nice with existing plugin paths

* Use API routine to determine if native connector is terminal.

* Committing clang-format changes

* Make string size larger, to allow for connectors with longer names.

* Be more flexible about testing external pass through connectors, especially if
they have registered new optional operations.

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: AWS ParallelCluster user <ec2-user@ip-10-0-0-65.us-east-2.compute.internal>
Co-authored-by: Koziol <qkoziol@88665a374c70.ant.amazon.com>
2023-01-09 17:18:28 -06:00
Quincey Koziol
337a882af8
Update FORTRAN VOL connector test for external pass-through testing (#2393)
* Correct concurrency bugs when running tests, along with a bugfix & small
warning cleanup.

* Committing clang-format changes

* Allow spaces (and tabs) in VOL connector info string from environment variable.

* Parse connector name from HDF5_PLUGIN_PATH environment variable better

* Correct H5VLquery_optional to use H5VL routine instead of H5I.  Also add an
error message to the failure return value from not finding a plugin.

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: AWS ParallelCluster user <ec2-user@ip-10-0-0-65.us-east-2.compute.internal>
Co-authored-by: Koziol <qkoziol@88665a374c70.ant.amazon.com>
2023-01-05 15:42:33 -08:00
Allen Byrne
c1e44d32e6
Fix doxygen warnings and remove javadocs (#2324)
* Fix doxygen warnings and remove javadocs

* fix typo
2022-12-20 16:59:40 -06:00
Scot Breitenfeld
4a8be219e0
fixed unclosed objects in test (#2290) 2022-12-09 21:30:42 -06:00
Allen Byrne
dcccc35526
Correct requires setting for pkgconfig files (#2280)
* Correct requires setting for pkgconfig files

* Add issue number
2022-12-07 16:05:51 -06:00
Larry Knox
11dfa25910
Update copyright headers (#2184)
* Updated source file copyright headers to remove "Copyright by the Board of Trustees
of the University of Illinois", which is kept in the top-level COPYING file.
2022-11-01 16:02:27 -05:00
Scot Breitenfeld
7d1997ff7b
Removed the file, func, line args in the _async APIs fpr doxygen (#2179)
* Removed the: file, func, line args in the _async APIs from the doxygen arguments. Documented H5ESclean.

* format fixes

* fixed DOXYGEN_PREDEFINED

* Fixed the #ifdet logic for doxygen, added missing multi-dataset va_args

* format fixes

* Use H5_DOXYGEN instead of H5_DOXYGEN_FORTRAN

* reordered multidataset declarations

* alt. for H5Aclose_async and H5Acreate_async

* made doxgyen API into seperate blocks

* updated codespell

* Committing clang-format changes

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2022-10-25 10:41:38 -07:00
Allen Byrne
ea902f9ace
Implement option for using CMake GNUInstallDirs (#2175)
* Implement option for using CMake GNUInstallDirs

* Add release notes
2022-10-25 08:50:43 -07:00
Neil Fortner
93754cae33
Multi Dataset (#2120)
* Fix bug with cross platform compatibility of references within vlens.
No testing yet.

* Merge from multi_rd_wd_coll_io to a more recent branch from develop.
Untested, probably does not work yet.

* Committing clang-format changes

* Committing clang-format changes

* Fix many bugs in multi dataset branch.  Mostly works, some issues in
SWMR tests.

* Committing clang-format changes

* Disable test in swmr.c that was failing due to bug in HDF5 unrelated to
multi dataset.

* Committing clang-format changes

* Fixed fortran multi-dataset tests

* Fixed xlf errors

* Added benchmark code for multi-datasets

* loops over datasets

* added missing error arg.

* Added gnuplot formatting

* Jonathan Kim original MD benchmarking code

* updated MD benchmarking code

* code clean-up

* Only make files in feature test mode

* misc clean-up

* removed TEST_MDSET_NO_LAST_DSET_2ND_PROC option

* Committing clang-format changes

* Change multi dataset API to use arrays of individual parameters instead
of the parameter struct.

* Committing clang-format changes

* Update to new multi dataset Fortran API and tests. (#1724)

* Update to new multi dataset Fortran API and tests.
* Sync Fortran with develop.
* skipping h5pget_mpio_actual_io_mode_f for now

* Fixed issue with dxpl_id, changed to variable size dim. (#1770)

* Remove "is_coll_broken" field from H5D_io_info_t struct

* Committing clang-format changes

* Minor cleanup in multi dataset code.

* Committing clang-format changes

* Clean up in multi dataset code.

* Committing clang-format changes

* Committing clang-format changes

* Fix speeling

* Fix bug in parallel compression. Switch base_maddr in io_info to be a
union.

* Committing clang-format changes

* Implement selection I/O support with multi dataset.  Will be broken in
parallel until PR 1803 is merged to develop then the MDS branch.

* Committing clang-format changes

* Spelling

* Fix bug in multi dataset that could cause errors when only some of the
datasets in the multi dataset I/O used type conversion.

* Committing clang-format changes

* Integrate multi dataset APIs with VOL layer.  Add async versions of
multi dataset APIs.

* Committing clang-format changes

* Spelling fixes

* Fix bug in non-parallel HDF5 compilation.

* Committing clang-format changes

* Fix potential memory/free list error. Minor performance fix. Other minor
changes.

* Committing clang-format changes

* Fix memory leak with memory dataspace for I/O.

* Committing clang-format changes

* Fix stack variables too large.  Rename H5D_dset_info_t to
H5D_dset_io_info_t.

* Committing clang-format changes

* Remove mem_space_alloc field from H5D_dset_io_info_t.  Each function is
now responsible for freeing any spaces it adds to dset_info.

* Committing clang-format changes

* fixed _multi Fortran declaration

* Refactor various things in (mostly) the serial I/O code path to make
things more maintainable.

* Committing clang-format changes

* updated to array based, doxygen, and examples

* Reinstate H5D_chunk_map_t, stored (via pointer) inside
H5D_dset_io_info_t.

* Change from calloc to malloc for H5D_dset_io_info_t and H5D_chunk_map_t.
Switch temporary dset_infos to be local stack variables.

* Committing clang-format changes

* format cleanup

* format cleanup

* added coll and ind

* Modify all parallel I/O paths to take dset_info instead of assuming
dset_info[0].

* Committing clang-format changes

* fixed output

* Rework parallel I/O code to work properly with multi dataset in more
cases.  Fix bug in parallel compression.

* Committing clang-format changes

* Prevent H5D__multi_chunk_collective_io() from messing up collective opt
property for other datasets in I/O.  Other minor cleanup.  Add new test
case to t_pmulti_dset.c for H5FD_MPIO_INDIVIDUAL_IO, disabled for now
due to failures apparently unrelated to multi dataset code.

* Fix spelling

* Committing clang-format changes

* Replace N log N algorithm for finding chunk in
H5D__multi_chunk_collective_io() with O(N) algorithm, and remove use of
io_info->sel_pieces in that function.

* Committing clang-format changes

* Replace sel_pieces skiplist in io_info with flat array of pointers, use
qsort in I/O routine only when necessary.

* Committing clang-format changes

* Add new test case to mdset.c

* Committing clang-format changes

* Fix spelling

* Very minor fix in H5VL__native_dataset_read()

* Fix bug that could affect filtered parallel multi-dataset I/O.

* Add RM entries for H5Dread_multi(), H5Dread_multi_async(),
H5Dwrite_multi(), and H5Dwrite_multi_async()

* Unskip test in swmr.c

* Committing clang-format changes

* Eliminate H5D__pre_read and H5D__pre_write

* Remove examples/ph5mdsettest.c. Will fix and re-add as a test.

* Enable hyperslab combinations in mdset test

* Committing clang-format changes

* Clarify H5Dread/write_multi documentation.

* Fix bugs in multi-dataset I/O.  Expand serial multi dataset test.
Update macro in parallel multi dataset test.

* Committing clang-format changes

* Spelling

* Remove obsolete entry in bin/trace

* Rework type conversion buffer allocation. Only one buffer is shared
between datasets in mdset mode, and it is malloced instead of calloced.

* Committing clang-format changes

* Fix bug in error handling in H5D__read/write

* added multi-dataset fortran check with optional dataset creation id (#2150)

* removed dup. dll entry

* Address comments from code review.

* Remove spurious changes in H5Fmpi.c

* Fix issue with reading unallocated datasets in multi-dataset mode.
Address other comments from code review.

* Committing clang-format changes

* Delay chunk index lookup from io_init to mdio_init so it doesn't add
overhead to single dataset I/O.

* Committing clang-format changes

* Fix inappropriate use of piece_count

* updated copyright on new file, removed benchmark from testing dir.

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: M. Scot Breitenfeld <brtnfld@hdfgroup.org>
Co-authored-by: Dana Robinson <43805+derobins@users.noreply.github.com>
2022-10-19 09:13:15 -07:00
Scot Breitenfeld
889dc1e9a7
address test failing when default real and integers are 8 bytes (#2173) 2022-10-19 08:55:06 -05:00
Scot Breitenfeld
0fd867390a
changed to referencing C APIs by empty brackets (Fortran) (#2167) 2022-10-17 15:37:19 -05:00
Scot Breitenfeld
afb92a3e22
Fix H5Dfill_f test (#2162)
* change to integer for legacy H5Dfill_f testing

* fixed H5Dfill testing issues with promoted real and integer

* updated build fortran dependencies
2022-10-14 11:35:52 -07:00
Scot Breitenfeld
edc3790f5c
renamed H5_FORTRAN_C_LONG_DOUBLE_IS_UNIQUE DLL (#2158)
* changed DLL define to a unique name
2022-10-13 11:41:33 -05:00
Scot Breitenfeld
cffaf47c15
Fix for missing h5dfill_c_long_double in dll (#2155)
* added conditionally include h5dfill_c_long_double in dll
2022-10-12 07:38:27 -05:00
Scot Breitenfeld
64e69d9291
Implemented C matching (and general) H5Dfill Fortran wrappers (#2152) 2022-10-11 07:25:05 -05:00
Scot Breitenfeld
306db409d4
Avoid calling H5FD_subfiling_init from h5open_f. (#2149)
* Only call H5FD_SUBFILING if subfiling conditions are met

* clang format
2022-10-07 09:01:42 -07:00
Scot Breitenfeld
e80079fd21
Subfiling Fortran wrapper work. (#2143)
* added C ref. for Fortran constants

* added C ref. for Fortran constants

* move constant paramters to H5* module listing

* added back comment

* Fortran subfiling and ioc FD with tests. H5Pset/get_mpi_params wrappers with tests, misc.. parallel test clean-up.

* misc. fixes

* fixed CMake testpar issues, formatted, misc. updates

* updated tests
2022-10-06 09:08:56 -07:00
Scot Breitenfeld
1fb83da215
Grouped the Fortran constants in Doxygen (#2136) 2022-10-03 11:13:00 -05:00
Scot Breitenfeld
1bec0ce2d7
Misc. Fortran Doxygen updates (#2129) 2022-09-28 10:52:19 -05:00
Scot Breitenfeld
1c26386c38
Added C references to Fortran constants. (#2126)
* added C references for Fortran APIs
2022-09-26 22:50:09 -05:00
Allen Byrne
45178c87a3
develop Merge doxygen from 1.12 branch (#2095) 2022-09-14 15:44:24 -05:00
Scot Breitenfeld
dcf3b54b6e
removed H5R interface definition (#2090) 2022-09-14 15:43:27 -05:00
Scot Breitenfeld
99f17c7271
Doxygen Fortran (#2062) 2022-09-07 17:11:20 -05:00
Allen Byrne
c8fdd92cd4
Update CMake code to 3.18 minimum version (#2080)
* Update CMake code to 3.18 minimum version

* Updated release note
2022-09-02 17:31:29 -07:00
Dana Robinson
ee55dd777b
Fortran module directory improvements (#2060)
* Removes the module directory from the Automake flags as this
  generated a large number of "missing include directory" warnings
  and is unecessary
* Adds the module path to libhdf5.settings
2022-08-23 12:25:07 -07:00
Scot Breitenfeld
88ed5b69d4
removed h5rget_object_type_f module interface (#2057) 2022-08-23 09:09:08 -07:00
Dana Robinson
f020d129b2
Corrects more Fortran warnings (#2059)
* Moves -Wunused-dummy-arguments to the developer warnings since this
  generates a lot of spurious, unfixable noise due to things like
  callback wrappers
* Changes the return cast in h5fget_fileno_c, fixes a comment, and comment
  on potential badness
* Initializes a variable in tH5L_F03.F90 to quiet a 'maybe
  uninitialized' warning
2022-08-23 08:48:14 -07:00
Dana Robinson
801edb4f52
Quiets Fortran warnings about large arrays (#2053) 2022-08-22 08:28:48 -07:00
Dana Robinson
7f6261a677
Removes cmake_ext_mod (files moved to cmake) (#2041)
At one time this content was a git submodule shared between several
projects but that time has long passed.
2022-08-19 07:54:42 -07:00
Dana Robinson
e6f16c0ec2
Fixes codespell issues (#2032)
* Fixes codespell issues

* Fixed another typo
2022-08-17 16:31:54 -07:00
luzpaz
174505ca3c
Fix typos found in the rest of the hdf5 code-base (#1985)
* Fix typos found in the rest of the hdf5 code-base

* Typo in tool.cmake

* Revert "Typo in tool.cmake"

This reverts commit 06b8403d99.

* Fix clang-format styling
2022-08-10 13:57:26 -07:00
Allen Byrne
956282fa6f
Develop cmake clean (#1971) 2022-08-06 23:59:31 -05:00