Minor code cleanups found while reviewing 'avoid truncate' branch.
Tested on:
MacOSX/64 10.10.1 (amazon) w/serial & parallel
(too minor to require h5committest)
Minor code/comment cleanups, found while reviewing 'avoid truncate' code.
Tested on:
MacOSX/64 10.10.1 (amazon) w/serial & parallel
(Too minor to require h5committest)
Fix cmakehdf5 so that it can figure out where the source directory is.
It expects cmakehdf5 itself resides at $srcdir/bin/cmamkehdf5.
Tested: Jam by invoking cmakehdf4 with different paths.
different language API's and testings. See "cmakehdf5 --help" for details.
Tested: jam using different combinations of option and verified correctness
by inspeacting libhdf5.settings output.
Previously, ph5diff may hang in a test in Linux 32 platform(HDFFV-587).
No solution was available and a patch to bypass the test is implemented.
Since the company is changing domain name soon, the patch would not be valid any more.
Tests were done (repeat 100 mpiexec -np 6 ./ph5diff -v h5diff_hyper1.h5 h5diff_hyper2.h5)
and the previous hanging problem did not occur. It is likely the newer versions of
mpich no longer have this problem. Therefore, it is decide to remove this patch
to make the test script cleaner, if nothing else.
Tested: ran build and test in Jam (linux 32) and the repeat 100 command mentioned above.
All passed.
Revert r25273, 25283 & 25439 (the hyperslab improvement changes). They
are buggy and it's taking me a long time to correct the problem. I'll check
in a revised form of the changes when I've got them straightened out.
Tested on:
Mac OSX 10.10.0 (amazon) w/gcc 4.9.x, C++, FORTRAN
Linux 2.6.x (jam) w/parallel
script. The warnings that this generates cannot easily be resolved in
platform-independent C code since gnu expects the non-standard (gnu)
'D' suffix for double constants.
It's still technically useful for catching float and long double
constants, but should probably be enabled by developers on an
as-needed basis for that purpose so the spurious warnings are
avoided.
Tested on a local linux VM with gcc 4.8.2. This is a very minor change.
Discovered when I temporarily #defined HDfree() to a more complicated
function while investigating something.
Tested on a local linux VM. This is a very minor change.
but the test was not changed (still doing H5A_create(...) < 0).
Fixed the error by changing to compare against NULL.
Tested: ADA AIX machine where the old code was flagged as an error by the AIX compiler.
Did not provide default values for clang++ options.
Also, applied wrong values for the *_CPPFLAGS.
Solution:
Added default values for *_CXXFLAGS.
Fixed the *_CPPFLAGS values.
Tested: wren with and without --enable-production.
