Tests to verify the bug fixed are installed.
Test: v1.8.4 passed all tests on
Jam (default and with --disable-depreacted-symbol), Amani (v16API),
Linew (default).
This should be good for trunk version too.
The error started out as an erroneous test of using v16 API via
source code. (See bug 1264). It was implemented as:
#include "hdf5.h"
#define H5_USE_16_API
That was incorrect and generated warnings in Linux but error in AIX
for redefining macro H5_USE_16_API.
I corrected it yesterday to pass AIX by moving H5_USE_16_API up as:
#define H5_USE_16_API
#include "hdf5.h"
This is the proper way to turn on v16API and it passes all normal
tests. I knew it would not work if somehow v16API is disabled
but hoping it can be fixed later. Well, it broke last night
under --disable-deprecated-symbols.
Removed the #define H5_USE_16_API and let Raymond fix it after
the release.
#define H5_USE_16_API
was inserted AFTER #include <hdf5.>, too late was it to take
effect. Instead, it caused a macro redefinition, flagged as an error
by AIX.
Fixed by moving it before the <hdf5.h>.
Tested: Jam.
If the AR command has embedded shell separators such as the case of
"AR = ar -X 64", $AR ends up as a blank.
Solution:
Put quotes around the command substitution string to protect against embedded
separators. Applied the same to both AR and RANLIB assignments.
Tested:
At Up (AIX 5.3) only because that was where I discovered the error
when AR is ar -X 64
check whether the macros H5_USE_16_API works properly. There used to be a problem to compile
if H5_USE_16_API is defined in the application program (see bug #1264).
Tested on kagiso - simple change.
th user's definition of H5_USE_16_API. The H5_USE_16_API_DEFAULT is defined through
configure with the flag --with-default-api-version=v16.
Tested with h5committest.
Bug fix.
Description:
It used to clean out all *.h5 when done but this could cause a racing
condition error if parallel make (e.g., gmake -j ...) is used because
the "rm ... *.h5 ..." would remove *.h5 generaged and are still used
by other test programs (e.g. h5_write/h5_read).
Solution:
Removed "*.h5" from the cleanup list since the test program has already
taken care of removing temporary *.h5 generated.
Tested platform:
Kagiso, both serial and parallel. Not triple platforms tested since
this is just a simple shell script change.
The test scripts did not take in account that the binary has been installed
somewhere other than the original prefix. Added a provision to allow
explicit definition of $prefix to work.
Tested:
kagiso.
Most fortran compilers do not support the Preprocessing -E option. Removed
the tests for preprocessing only.
examples/testh5cc.sh.in:
c++/examples/testh5c++.sh.in:
Updated comments and some cosmetic rearrangement.
No substance changes.
Tested platform:
Copper, kagiso.
