Commit Graph

2433 Commits

Author SHA1 Message Date
Allen Byrne
28ec2d2693 [svn-r25357] Change default timeout to 1200 seconds or 20 mins
adjust up for certain tests.
2014-06-25 09:15:13 -05:00
Allen Byrne
e90941e86a [svn-r25343] Add more vfd tests to smaller timeout limits 2014-06-23 16:57:13 -05:00
Allen Byrne
9c4e646c1a [svn-r25310] Add max time for VFD objcopy test 2014-06-18 08:39:37 -05:00
Quincey Koziol
ec408ef083 [svn-r25283] Description:
Correct error in new hyperslab selection test to use the right # of
dimensions for start/stride/count/block arrays.  Also, switch H5Sselect_select
to H5Smodify_select.

Tested on:
    MacOSX/64 10.9.3 (amazon) w/gcc 4.9.1, OpenMPI, C++, FORTRAN & threadsafe
    (Too minor to require h5committest)
2014-06-13 22:23:54 -05:00
Quincey Koziol
4ccb865c70 [svn-r25273] Description:
Bring in Chao/Neil/my changes to optimize hyperslab selection operations
further, along with 3 new public API routines: H5Scombine_hyperslab(),
H5Sselect_select() and H5Scombine_select(), along with many minor cleanups to
the code and fixing a few compiler warnings.

Tested on:
    Mac OSX/64 10.9.3 w/gcc 4.9.x and parallel w/OpenMPI
    (h5commttest forthcoming)
2014-06-13 01:23:57 -05:00
Allen Byrne
d74b7fb7b8 [svn-r25261] limit vfd flush1 test time 2014-06-11 14:23:00 -05:00
Allen Byrne
21474f8eee [svn-r25188] Implement change to cmake_ext_mod config folder
Tested: local linux
2014-05-14 14:50:28 -05:00
Larry Knox
c6e3e68297 [svn-r25117] Removed LT_ADD_LIBHDF5_DEPENDENCY configure conditional to roll back fix for removing rpaths from l
ib files.  The fix also removed dependencies on libhdf5, etc. when the --disable-sharedlib-rpath co
nfigure option was invoked.
Added instead configure variable hardcode_into_lib=no.  This removes rpath from lib files on Linux
and solaris machines.

Tested with h5committest on jam, koala, ostrich and platypus (cmake), and with configure option --disable-sharedlib-rpath on emu, platypus and quail.
2014-04-25 16:59:53 -05:00
Dana Robinson
7309bb5ab8 [svn-r25113] Fixed Subversion EOL and executable attributes. No code changes. 2014-04-25 16:27:37 -05:00
Quincey Koziol
95e0006dc2 [svn-r25097] Description:
Make progress toward moving from DXPL IDs to property list structures
within the library.  Also move the signature location code from the H5F
package to the H5FD package, where it's a better fit.  Also, clean up some
more compiler warnings along the way.

Tested on:
    Mac OSX/64 10.9.2 (amazon) w/C++, FORTRAN & parallel
    (h5committest forthcoming)
2014-04-25 09:32:17 -05:00
Quincey Koziol
3bdb116942 [svn-r25092] Description:
More migration to using H5F_io_info_t pointers and away from using
property list IDs internally.  Also, clean up some compiler warnings in the
cache code.

Tested on:
    Mac OSX/64 10.9.2 (amazon) w/C++, FORTRAN & parallel
    (h5committest forthcoming)
2014-04-24 11:30:24 -05:00
Quincey Koziol
7b6eae2ddf [svn-r25084] Description:
Begin process of migrating from using property list IDs internally to the
library to using the internal generic property list data structure.

Tested on:
    Mac OSX/64 10.9.2 (amazon) w/C++, FORTRAN & parallel
    (h5committest forthcoming)
2014-04-23 11:30:25 -05:00
Quincey Koziol
3de25ee226 [svn-r24998] Description:
Check in Neil's changes for correctly handling case where library is
reinitialized through a deprecated routine.

Tested on:
    Linux 2.4.x/32 (jam)
2014-04-09 00:08:21 -05:00
Quincey Koziol
c1163e0399 [svn-r24995] Description:
Improve checks for NULL buffer from user during H5Dread/H5Dwrite calls.

Tested on:
    Linux/32 2.4.x (jam) w/gcc
2014-04-08 23:16:53 -05:00
Dana Robinson
5ae7ad342d [svn-r24993] Purpose:
Adds write tracking to the core VFD, which can be configured
via the H5Pset/get_core_write_tracking() API call. When enabled
and writing to the backing store is enabled, this feature will
track writes and only write out the changed bytes on flush/close.

Tested on:
    32-bit LE linux (jam) w/ Fortran and C++
    64-bit BE linux (ostrich)
    64-bit Darwin 12.5.0 (kite)

All were tested using the core VFD w/ paging on (core_paged
in the VFD list). Make check-vfd was also tested on jam.
2014-04-08 22:35:16 -05:00
Allen Byrne
6739a7f7ac [svn-r24950] Add missing prefix 2014-04-03 08:56:51 -05:00
Allen Byrne
98bbf4a36a [svn-r24948] Group tests by Common name
Remove WIN32 AND NOT CYGWIN if blocks - should be just WIN32

Tested: local linux CMake
2014-04-02 13:35:01 -05:00
Dana Robinson
d01ee66666 [svn-r24937] Adds an H5free_memory() function to the library for use with
functions that return library-allocated memory. The test and tool
code were modified to use this new function where it's appropriate.

Fixes HDFFV-7710, HDFFV-8519, and HDFFV-8551

Tested on:
    64-bit Windows 7 w/ VS2012
    32-bit LE linux w/ parallel and fortran (jam)
    32-bit LE linux w/ fortran and C++ (jam)
2014-03-31 18:35:09 -05:00
Allen Byrne
c6fe8c70b2 [svn-r24932] HDFFV-8290: Remove unnecessary $(srcdir) and use AM_CPPFLAGS instead of INCLUDES. Update automake to 1.14.1
h5committest
2014-03-31 12:07:05 -05:00
Quincey Koziol
f97d63cb95 [svn-r24869] Description:
Clean up more compiler warnings, plus merge a few Coverity bug fixes from
the hdf5_1_8_coverity branch back to the trunk:

r20877:
Purpose: Fix coverity issue 1723

Description:
Modified test_generate in hl/test_image to close file "f" before exit, even if
an error occurs.

r20879:
Issue 63: change check of return of H5Tget_nmembers to <=0. No need to go
futher if call fails as well as empty.

r20881:
Coverity #659 in Run 46: I changed the Line 442 where it tries to check whether
FLAG_PRINTED is TRUE.  But it had just been set to FALSE.  I took out the
condition check in the print statement.

Tested on:
    Mac OSX/64 10.9.2 (amazon) w/C++, FORTRAN & Parallel
    (too minor to require h5committest)
2014-03-23 01:27:57 -05:00
Quincey Koziol
2e4302818a [svn-r24864] Description:
Remove all traces of MPI-POSIX VFD and GPFS detection/code.

    Remove remaining traces of stream VFD.

    Remove testpar/t_posix_compliant test (it's not actually verifying anything).

    Clean up H5D__mpio_opt_possible() further.

    Moved environment variable that disables MPI collective operations into
MPI-IO VFD (instead of it being in src/H5S.c).

    A few other small code cleanups.

Tested on:
    Mac OSX/64 10.9.2 (amazon) w/parallel & serial
2014-03-21 18:02:24 -05:00
Allen Byrne
03d10edd23 [svn-r24824] HDFFV-8700 -
KitWare recommendations: Change CMake commands to lower case.
Bump up CMake minimum versions.
Split test file into separate file for h5repack test.

Tested: local linux
2014-03-18 11:21:46 -05:00
Quincey Koziol
164b4c7534 [svn-r24804] Description:
Brought changes from Coverity branch back to trunk, and cleaned up misc.
other warnings & formatting issues:

r20833:
Fixed Coverity 667 and 668 with real integer overflow tests this time.

r20834:
Use HDstrncpy and HDstrncat. --gh 

r20835:
Change to use strncpy - use base_len + 1 for line 156, use HDstrlen(path) + 1 for line 159

r20836:
Fixed coverity 585 by casting output of fgetc() to a char.

r20837:
Changed sprintf calls to snprintf with size 1 less than the allocated buffer to address coverity issue #967.

Tested on:
    Mac OSX/64 10.9.2 (amazon) w/C++, FORTRAN & parallel
    (too minor to require h5committest)
2014-03-15 23:44:13 -05:00
Quincey Koziol
288c7760a4 [svn-r24803] Description:
Rename GCC_DIAG_OFF/ON macros to H5_GCC_DIAG_OFF/ON and move from
src/H5private.h to src/H5public.h.  Wrap typedef of hsize_t and hssize_t
in DIAG_OFF(long-long) macros.

    Clean up a bunch of "macro '-' is unused" warnings.

Tested on:
    Mac OSX/64 10.9.2 (amazon) w/gcc 4.8.2, C++, FORTRAN, parallel
    (too minor to require h5committest)
2014-03-15 22:13:52 -05:00
Allen Byrne
f5689224b5 [svn-r24789] Bump up the minimum cmake version 2014-03-13 10:05:09 -05:00
Allen Byrne
6c5e74942d [svn-r24782] HDFFV-8700 -
KitWare recommendations: Change CMake commands to lower case.
2014-03-11 17:07:13 -05:00
Allen Byrne
a3292a77ce [svn-r24781] HDFFV-8700 -
KitWare recommendations: Change CMake commands to lower case.
Remove INCLUDE_DIRECTORIES in src for target level includes.
Change ADD_DEFINITIONS package debug defines into CMake option.
Remove -DNDEBUG
2014-03-11 16:14:57 -05:00
Quincey Koziol
1e36b5a348 [svn-r24726] Description:
Revert some earlier usage of strncpy, which was incorrect.

    Bring Coverity changes from branch back to trunk:

r20821:
    Use HDstrncpy. --gh
    (Fixed already, with strdup)

r20822:
    (Not merged, incorrect use of HDstrncpy())

r20823:
    (Not merged, incorrect use of HDstrncpy())

r20824:
    Maintenance: Bug fix: addressed CID 666.
    Value stored at *expression_len should be used in the call to
        HD5packFstring to avoid overflow (and unnecessary arithmetic
        calculation and casting) 

r20825:
    Issue 642: Added check for error and handler with print to stderr and exit.

r20826:
    Undo revision 20818, as that issue has already been fixed in the 1.8 branch
        and trunk (but not coverity branch)

r20827:
    (Not merged, incorrect use of HDstrncpy())
    
r20828:
    Use HDstrncpy. --gh
    (Corrected use of strncpy())

r20829:
    Check return of H5Lget_val(print_udata->fid, path, targbuf,
        linfo->u.val_size + 1, H5P_DEFAULT) and if error set trgbuf[0] to 0.
        Check if  H5Lunpack_elink_val(targbuf, linfo->u.val_size, NULL,
        &filename, &objname) was successful and allow print. Otherwise filename
        and objname are not created. (init those to NULL)

r20830:
    resolved coverity issues 939, 940, 941, 944, and 947.

    all were complaints about use of sprintf, and in all cases, the
    buffers used were large enough for all eventualities.

    Resolved issue by replacing calls to sprintf with calls
    to snprintf.

r20831:
    Maintenance: Addressed CID 852
    Replaced sprintf with snprintf

r20832:
    Purpose: Fix valgrind issues with hl/examples/ex_image2

    Description:
    Modified hl/examples/ex_image2 to free global "gbuf" before exit.

Tested on:
    Mac OSX/64 10.9.1 (amaon) w/C++, FORTRAN & Threadsafety
    (too minor to require h5committest)
2014-02-20 16:29:26 -05:00
Mohamad Chaarawi
863ff882b6 [svn-r24709] rename H5V to H5VM since H5V is needed in the fastforward project for
view objects.  The addition of view objects in the fastforward project
is expected to be brough into the trunk sometimes in the future, which
is why we need to make this change.

Tested Manually on Jam and Ostrich.
Tested with h5commitest - Koala with intel compilers failed, but nothing had to do with those changes.
error on Koala: error while loading shared libraries: libirng.so
2014-02-13 17:12:46 -05:00
Scot Breitenfeld
ee10548723 [svn-r24681] Description:
Fix for HDF5/HDFFV-8620 H5Rget_name with NULL name parameter fails.
The name parameter now excepts NULL, in which case the length of then
name is returned.


Tested: jam (intel and gnu)
2014-02-04 10:11:20 -05:00
Allen Byrne
2f8c7fbd5e [svn-r24659] Restore dsets test to cmake process 2014-01-28 17:20:41 -05:00
Albert Cheng
50bd3521af [svn-r24652] HDFFV-8572: test/testhdf5.c main() should not return number of errors
Solution: testhdf5 now exits EXIT_SUCCESS(0) if no errors, else
EXIT_FAILURE(1).

Tested: Jam only since it is a trivial fix.
2014-01-27 17:33:34 -05:00
Allen Byrne
2f86aa7551 [svn-r24646] HDFFV-8640: Remove xlate_utility by fixing reference files to not add extra lines.
Tested: cmake and autotools local linux
2014-01-27 09:26:21 -05:00
Quincey Koziol
0a506a625b [svn-r24476] Description:
Remove duplicate "intent" flags from top & shared file structures, leaving
    them only in the shared file structure.

Tested on:
    Mac OSX/64 10.9.0 (amazon) w/gcc 4.8, both parallel & serial
    (too minor to require h5committest)
2013-11-30 00:51:42 -05:00
Dana Robinson
3a976e0aa7 [svn-r24416] Fixed some compiler warnings in the dsets test.
Tested on:
    32-bit LE linux (jam)

(These are just minor casting changes in the tests, hence the minimal
testing.)
2013-11-07 16:19:53 -05:00
Allen Byrne
819b8099e2 [svn-r24392] Cleanup testfiles from scripts. Update lists of files to be cleaned. CMake update to clean testfiles.
Tested: local cmake, autools, and h5committest
2013-11-01 16:15:37 -05:00
Dana Robinson
e6cace9ee4 [svn-r24376] Updated all code to use HDmalloc, HDcalloc, and HDfree.
Prep work for adding a memory free function, part of HDFFV-8551.

Tested on:
    32-bit LE linux (jam) 
        * with C++, Fortran
        * with thread safety on

    These are minor changes (almost entirely renaming foo functions
    to HDfoo) that don't change functionality.  This should not
    require a full commit test.
2013-10-30 23:20:36 -05:00
Raymond Lu
277ee2f7ee [svn-r24360] Jira issue 8528: H5Fget_obj_ids overfilled the list of object IDs by one. This is the second round of checkin after
receiving review comments from people. I put the safeguard in both H5F_get_objects and H5F_get_objects_cb to prevent 
overfill the list.

tested with h5committest.
2013-10-25 14:26:08 -05:00
Dana Robinson
b7a4e1a44e [svn-r24358] Changed the big test so that it runs using the h5_fileaccess() fapl.
The previous behavior was to execute a sec2, stdio, and family
test everytime it ran, which was very inefficient under check-vfd.

Tested on:
    32- and 64-bit LE linux (jam and koala)
    64-bit BE linux (ostrich)
    64-bit OS-X 10.6 (fred)
2013-10-24 23:57:01 -05:00
Larry Knox
06aa7b6641 [svn-r24285] Eliminate several "passing argument ... with different width due to prototype" warnings by casting constants to size_t where expected by string functions.
Tested on jam, koala,ostrich and platypus with h5committest.
2013-10-10 16:57:04 -05:00
Quincey Koziol
5f2a34b462 [svn-r24256] Description:
Clean up warnings

Tested on:
    Mac OSX/64 10.8.4 (amazon) w/C++ & FORTRAN
    (too minor for h5committest)
2013-10-04 14:28:22 -05:00
Albert Cheng
7fcd636cb3 [svn-r24234] Bug: tfile.c was failing in the ADA AIX system.
The reason was typo in the index variable in the newly added test_get_obj_ids().

Solution: fixed the typo.

Tested: AIX machine. (Did not run h5committest because the fix is in a remote
machine and the fix is quite obvious.)
2013-09-30 18:11:13 -05:00
Albert Cheng
bbd9ad0b27 [svn-r24214] Put in proper error message if unexpected switch values happened.
Tested: h5committest.
2013-09-28 15:40:01 -05:00
Raymond Lu
421e7549a5 [svn-r24210] Jira issue 8528: H5Fget_obj_ids overfilled the list of object IDs by one. I moved the safeguard in H5F_get_objects_cb
to the beginning of the function to prevent overfill the list.  I added a new test case for this problem and fix in tfile.c.

Tested with h5committest.
2013-09-27 15:15:52 -05:00
Albert Cheng
ebc0b44fe1 [svn-r24202] Bug fix: HDFFV-8271 Big.c error in address generated by random number.
Description:
There is a bug in the current big.c tests. In a nut-shell,
the writing part randomly picks 50 locations and write 4KB
from that location. Random location range is from byte 0
to end of dataset. There is the problem--if the random location
is greater than (end of dataset - 4KB), then error.

Solution:
Adjust the random number to be at least 4KB less than the end of the
dataset. That allows it write 4KB more from the generated starting
position.

Tested: h5comittest plus jam serial build and test.
2013-09-26 01:51:10 -05:00
Larry Knox
ab239810e1 [svn-r24194] Don't add hdf5 library dependencies to lib files when --disable-sharedlib-rpath configure option is invoked. Fix for HDFFV-8276.
Tested with h5committest and on hdf-duck.
2013-09-23 20:14:24 -05:00
Allen Byrne
0653325f0d [svn-r24167] HDFFV-8513, HDFFV-8522 Plugin testing in h5repack, h5dump.
Add more usage info for UserMacros.
Add new option information about the Plugin default path.

Tested: local linux, jam
2013-09-19 11:38:08 -05:00
Quincey Koziol
5b876c929f [svn-r24101] Description:
Clean up warnings, enable new compiler warning flag(s) and bring back
changes from Coverity branch:

r20813:
Remove the dead code as listed for coverity bug #1722. h5committested.

r20814:
Issue 69: Check return value and throw error if negative return. Also free datatype id on error

r20815:
Use HDstrncpy. --gh

r20816:
Replaced one last HDstrcat call with HDstrncat to resolve coverity issue 832.

r20817:
Use HDstrncpy and HDstrncat. --gh

r20818:
Purpose: Fix valgrind issues with h5jam

Description:
Modified h5jam to free strings strdup'd in parse_command_line before exit. Note
that they may still not be freed in case of error, due to the widespread use of
exit().

r20819:
Issue 80: change loop to use int as loop index.

r20820:
Maintenance: Fixed the bug found by coverity CID 788
There were two problems with this function:
    1) it tried to unnecessary free NULL pointer
    2) it tried to allocate c_name buffer that is done by H5Pget_class_name


Tested on:
    Mac OSX 10.8.4 (amazon) w/gcc 4.8.1, C++ & FORTRAN
    (too minor to require h5committest)
2013-09-05 15:44:14 -05:00
Allen Byrne
bf1c137c0c [svn-r24097] Correct indentation 2013-09-04 14:58:45 -05:00
Allen Byrne
7e0bc29012 [svn-r24056] Move make_executable commands back from tests file 2013-08-22 13:41:25 -05:00