Purpose:
Remove H5_MPI_SPECIAL_COLLECTIVE_IO_WORKS and
H5_MPI_COMPLEX_DERIVED_DATATYPE_WORKS #defines from source.
Description:
Two advanced parallel functionalities, special collective IO and
complex derived datatypes, are not supported by older
implementations of mpi, and thus our code limits the use of these
features with #ifdefs and has checks in configure to set them (or
not). Unfortunately, configure can't actually run a parallel check
to see if these features are working (nor not) so it resorts to
looking in the config files where they are explicity enabled or
disabled based on versions of mpi, sytems being built on, or for
no documented reason at all (i.e. just set to on or off as some
'default'). Overriding these settings is easy if need be, provided
it is known that it needs to be done to get improved performance,
and oftentimes it is not.
Most new MPI implementations successfully handle the functionality
requested when these #defines are set, and many of the "turn these
features off" cases in the config files are for old (> 5 years)
versions of MPI and retired systems (such as NCSA's tungsten).
Therefore, the decision has been made to remove the support for
these old versions of MPI and systems that cannot handle these
behaviors. The #ifdefs and supporting setup in the config/ files
and configure script has been removed, and the code executed when
these options were not set removed from the source.
In passing, this commit also cleans up some whitespace issues in
both t_mpi.c and H5Dmpio.c. Furthermore, in t_mpi.c, the special
collective IO test was not getting regularly run due to it being
written to work only with four processes (we regularly test with
six, previously with three), and thus it failed when actually run
due to an out of bounds data buffer assignment. It has been
modified to run at any number of processes greater than four, and
the memory problem has been fixed so the test passes.
Tested:
jam, h5committest, ember
directory. OpenVMS couldn't open a file through symbolic link. This macro is mainly used
in test/links.c for the function call external_symlink and in src/H5F.c.
Tested the same change for 1.8 on OpenVMS.
------------------------------------------------------------------------
#include <stdio.h>
#include <unistd.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <errno.h>
int main(void)
{
int file1, file2;
/* Create a symbolic link to the file 21b.c */
if(symlink("[LU.hdf5_1_8_2_5.test.tmp2]21b.c", "[LU.hdf5_1_8_2_5.test.tmp]sym1") < 0)
printf("symlink failed\n");
/* Create the file 21b.c */
if((file1 = open("[LU.hdf5_1_8_2_5.test.tmp2]21b.c", O_CREAT | O_TRUNC | O_RDWR)) < 0)
printf("1st open failed\n");
if(close(file1) < 0)
printf("close failed\n");
/* Open the 21b.c through the symbolic link */
if((file2 = open("[LU.hdf5_1_8_2_5.test.tmp]sym1", O_RDWR)) < 0) {
int errsv = errno;
printf("2nd open failed, errno=%d\n", errsv);
}
if(close(file2) < 0)
printf("close failed\n");
return 0;
}
