mirror/hdf5
2
0
Fork 0
mirror of https://github.com/HDFGroup/hdf5.git synced 2025-03-31 17:10:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix #2598 sanitize leak (#2660)

Browse Source
This commit is contained in:
Allen Byrne 2023-04-07 12:35:51 -05:00 committed by GitHub
parent 526f0769a3
commit fc91e8856f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
release_docs/RELEASE.txt
View File

@ -237,7 +237,12 @@ Bug Fixes since HDF5-1.13.3 release
Tools
-----
-
- In the tools traverse function - an error in either visit call
will bypass the cleanup of the local data variables.
Replaced the H5TOOLS_GOTO_ERROR with just H5TOOLS_ERROR.
(ADB - 2023/04/06 GH-2598)
Performance

8
tools/lib/h5trav.c
View File

@ -144,9 +144,9 @@ trav_token_visited(hid_t loc_id, trav_addr_t *visited, H5O_token_t *token)
size_t u; /* Local index variable */
int token_cmp;
/* Look for address */
/* Look for path associated with token */
for (u = 0; u < visited->nused; u++) {
/* Check for address already in array */
/* Check for token already in array */
if (H5Otoken_cmp(loc_id, &visited->objs[u].token, token, &token_cmp) < 0)
return NULL;
if (!token_cmp)
@ -281,13 +281,13 @@ traverse(hid_t file_id, const char *grp_name, hbool_t visit_start, hbool_t recur
/* Visit all links in group, recursively */
if (H5Lvisit_by_name2(file_id, grp_name, trav_index_by, trav_index_order, traverse_cb, &udata,
H5P_DEFAULT) < 0)
H5TOOLS_GOTO_ERROR((-1), "H5Lvisit_by_name failed");
H5TOOLS_ERROR((-1), "H5Lvisit_by_name failed");
} /* end if */
else {
/* Iterate over links in group */
if (H5Literate_by_name2(file_id, grp_name, trav_index_by, trav_index_order, NULL, traverse_cb,
&udata, H5P_DEFAULT) < 0)
H5TOOLS_GOTO_ERROR((-1), "H5Literate_by_name failed");
H5TOOLS_ERROR((-1), "H5Literate_by_name failed");
} /* end else */
/* Free visited addresses table */