mirror/hdf5
2
0
Fork 0
mirror of https://github.com/HDFGroup/hdf5.git synced 2024-11-21 01:04:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

[svn-r4672] Purpose:

Browse Source 
Bug fix
Description:
    Snapshot does "make check" directly, instead of building all
    binary first.  This means it does not cover code that are not
    tested (e.g., example, perform).  (That explained why the errors
    in the PIO performance code were not reported in daily test but
    blew up when people built the library the "normal" way.)
    It is done this way so that the snaptest aborts as soon as
    the first test failed rather than after all code are compiled.
Solution:
    Add "make" (to build all binary) before "make check".
    The allows snaptest to fail as soon as the first compiling failure.
    If we wish the snaptest to abort on the first test failure, the two
    can be swapped as "make check && make ...".  (It would appear strange
    to run tests then make binary.)
Platforms tested:
    Would be tested in the daily test tonight.  (I should have tested
    it first but I started this commit process already.  Sorry.)
This commit is contained in:
Albert Cheng 2001-12-05 12:18:34 -05:00
parent 4886a6c447
commit e3c98c2899
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
bin/snapshot
View File

@ -256,10 +256,11 @@ if [ "$cmd" = "all" -o -n "$cmdtest" ]; then
fi
fi
# Make sure all the serial tests work.
# Build, run tests and install procedures
if [ "$snapshot" = "yes" ]; then
if (cd ${TESTDIR} && \
${srcdir:+${CURRENT}/}${CONFIGURE} --prefix=$INSTALLDIR && \
${MAKE} && \
${MAKE} check && \
${MAKE} install install-doc && \
${MAKE} uninstall uninstall-doc); then