From dfe5cb24b9e6ef2bbe092b0d6147ac5c3c7837b5 Mon Sep 17 00:00:00 2001
From: Scot Breitenfeld <brtnfld@hdfgroup.org>
Date: Wed, 12 Jul 2023 13:56:02 -0500
Subject: [PATCH] addresses compilation fortran warnings on Frontier (#3236)

---
 fortran/src/H5Aff.F90  | 3 +--
 fortran/src/H5Dff.F90  | 2 +-
 fortran/src/H5ESff.F90 | 1 -
 fortran/src/H5Eff.F90  | 2 +-
 fortran/src/H5Fff.F90  | 2 +-
 fortran/src/H5Gff.F90  | 4 ++--
 fortran/src/H5Iff.F90  | 2 +-
 fortran/src/H5Lff.F90  | 3 ---
 fortran/src/H5Off.F90  | 2 --
 fortran/src/H5Pff.F90  | 1 -
 fortran/src/H5Rff.F90  | 3 ++-
 fortran/src/H5Sff.F90  | 3 ++-
 fortran/src/H5Tff.F90  | 1 -
 fortran/src/H5VLff.F90 | 1 -
 fortran/src/H5Zff.F90  | 1 +
 fortran/src/H5_ff.F90  | 1 -
 16 files changed, 12 insertions(+), 20 deletions(-)

diff --git a/fortran/src/H5Aff.F90 b/fortran/src/H5Aff.F90
index b30044daac..9216060d5f 100644
--- a/fortran/src/H5Aff.F90
+++ b/fortran/src/H5Aff.F90
@@ -70,9 +70,8 @@
 
 MODULE H5A
 
-  USE, INTRINSIC :: ISO_C_BINDING, ONLY : C_PTR, C_CHAR, C_NULL_CHAR, C_LOC, C_INT
-
   USE H5GLOBAL
+  IMPLICIT NONE
 
   PRIVATE h5awrite_char_scalar, h5awrite_ptr
   PRIVATE h5aread_char_scalar, h5aread_ptr
diff --git a/fortran/src/H5Dff.F90 b/fortran/src/H5Dff.F90
index 5b571e55ba..66bee98faf 100644
--- a/fortran/src/H5Dff.F90
+++ b/fortran/src/H5Dff.F90
@@ -85,10 +85,10 @@
 
 MODULE H5D
 
-  USE, INTRINSIC :: ISO_C_BINDING, ONLY : C_PTR, C_CHAR
   USE H5GLOBAL
   USE H5LIB, ONLY : h5kind_to_type
   USE H5S, ONLY : H5Sget_simple_extent_ndims_f, H5Sclose_f
+  IMPLICIT NONE
 
   PRIVATE h5dread_vl_integer, h5dread_vl_real, h5dread_vl_string
   PRIVATE h5dwrite_vl_integer, h5dwrite_vl_real, h5dwrite_vl_string
diff --git a/fortran/src/H5ESff.F90 b/fortran/src/H5ESff.F90
index f102d23051..76e84881e5 100644
--- a/fortran/src/H5ESff.F90
+++ b/fortran/src/H5ESff.F90
@@ -33,7 +33,6 @@
 
 MODULE H5ES
 
-  USE, INTRINSIC :: ISO_C_BINDING, ONLY : C_PTR, C_CHAR, C_INT64_T, C_BOOL
   USE H5GLOBAL
   IMPLICIT NONE
 
diff --git a/fortran/src/H5Eff.F90 b/fortran/src/H5Eff.F90
index a4c9e8cd16..4ef18c126f 100644
--- a/fortran/src/H5Eff.F90
+++ b/fortran/src/H5Eff.F90
@@ -37,8 +37,8 @@
 
 MODULE H5E
 
-  USE, INTRINSIC :: ISO_C_BINDING, ONLY : C_PTR, C_FUNPTR, C_CHAR
   USE H5GLOBAL
+  IMPLICIT NONE
 
   INTEGER, PARAMETER :: PRINTON  = 1 !< Turn on automatic printing of errors
   INTEGER, PARAMETER :: PRINTOFF = 0 !< Turn off automatic printing of errors
diff --git a/fortran/src/H5Fff.F90 b/fortran/src/H5Fff.F90
index aec149fd7c..f8a7405300 100644
--- a/fortran/src/H5Fff.F90
+++ b/fortran/src/H5Fff.F90
@@ -36,7 +36,7 @@
 !
 
 MODULE H5F
-  USE, INTRINSIC :: ISO_C_BINDING, ONLY : C_PTR, C_CHAR, C_NULL_PTR
+
   USE H5GLOBAL
   IMPLICIT NONE
 
diff --git a/fortran/src/H5Gff.F90 b/fortran/src/H5Gff.F90
index c8701a2a3d..a9c7208f97 100644
--- a/fortran/src/H5Gff.F90
+++ b/fortran/src/H5Gff.F90
@@ -36,10 +36,10 @@
 !
 
 MODULE H5G
-  USE, INTRINSIC :: ISO_C_BINDING, ONLY : C_CHAR, C_INT
+
   USE H5GLOBAL
   USE H5P, ONLY : H5Pcreate_f, H5Pset_local_heap_size_hint_f, H5Pclose_f
-
+  IMPLICIT NONE
 
 !
 ! @brief Fortran2003 Derived Type for @ref H5G_info_t
diff --git a/fortran/src/H5Iff.F90 b/fortran/src/H5Iff.F90
index 6e6662c071..7c449eaa8b 100644
--- a/fortran/src/H5Iff.F90
+++ b/fortran/src/H5Iff.F90
@@ -37,8 +37,8 @@
 
 MODULE H5I
 
-  USE, INTRINSIC :: ISO_C_BINDING, ONLY : C_PTR, C_CHAR
   USE H5GLOBAL
+  IMPLICIT NONE
 
 CONTAINS
 
diff --git a/fortran/src/H5Lff.F90 b/fortran/src/H5Lff.F90
index e2e9e4949c..86bee8822a 100644
--- a/fortran/src/H5Lff.F90
+++ b/fortran/src/H5Lff.F90
@@ -37,12 +37,9 @@
 
 MODULE H5L
 
-  USE, INTRINSIC :: ISO_C_BINDING, ONLY : C_PTR, C_FUNPTR, C_CHAR, C_INT64_T, C_INT
   USE H5GLOBAL
-
   IMPLICIT NONE
 
-
   TYPE, bind(c) :: union_t
      TYPE(H5O_TOKEN_T_F) :: token !< Type for object tokens
      INTEGER(size_t)  :: val_size !< Size of a soft link or user-defined link value
diff --git a/fortran/src/H5Off.F90 b/fortran/src/H5Off.F90
index 54c503e16e..e7862cfa1d 100644
--- a/fortran/src/H5Off.F90
+++ b/fortran/src/H5Off.F90
@@ -37,11 +37,9 @@
 
 MODULE H5O
 
-  USE, INTRINSIC :: ISO_C_BINDING, ONLY : C_PTR, C_FUNPTR, C_CHAR, C_INT64_T, C_LONG, C_INT, C_LOC
   USE H5GLOBAL
   IMPLICIT NONE
 
-
 !> @brief h5o_info_t derived type. The time values are an integer array as specified in the Fortran intrinsic DATE_AND_TIME(VALUES).
   TYPE, BIND(C) :: h5o_info_t
      INTEGER(C_LONG)     :: fileno     !< File number that object is located in
diff --git a/fortran/src/H5Pff.F90 b/fortran/src/H5Pff.F90
index c6229f7fe5..16ad2ac9c6 100644
--- a/fortran/src/H5Pff.F90
+++ b/fortran/src/H5Pff.F90
@@ -39,7 +39,6 @@
 
 MODULE H5P
 
-  USE, INTRINSIC :: ISO_C_BINDING, ONLY : C_PTR, C_CHAR
   USE H5GLOBAL
   USE H5fortkit
 
diff --git a/fortran/src/H5Rff.F90 b/fortran/src/H5Rff.F90
index 1b2cd8aea0..ea7cbb69c9 100644
--- a/fortran/src/H5Rff.F90
+++ b/fortran/src/H5Rff.F90
@@ -46,8 +46,9 @@
 !
 
 MODULE H5R
-  USE, INTRINSIC :: ISO_C_BINDING, ONLY : C_PTR, C_CHAR, C_SIGNED_CHAR
+
   USE H5GLOBAL
+  IMPLICIT NONE
 
   ! If you change the value of these parameters, do not forget to change corresponding
   ! values in the H5f90.h file.
diff --git a/fortran/src/H5Sff.F90 b/fortran/src/H5Sff.F90
index 79386f3e6a..fff32c0a6c 100644
--- a/fortran/src/H5Sff.F90
+++ b/fortran/src/H5Sff.F90
@@ -37,8 +37,9 @@
 !
 
 MODULE H5S
-  USE, INTRINSIC :: ISO_C_BINDING, ONLY : C_PTR, C_CHAR, C_INT
+
   USE H5GLOBAL
+  IMPLICIT NONE
 
 CONTAINS
 !>
diff --git a/fortran/src/H5Tff.F90 b/fortran/src/H5Tff.F90
index fa65ef6039..4e05bbc30d 100644
--- a/fortran/src/H5Tff.F90
+++ b/fortran/src/H5Tff.F90
@@ -38,7 +38,6 @@
 
 MODULE H5T
 
-  USE, INTRINSIC :: ISO_C_BINDING, ONLY : C_PTR,  C_CHAR, C_NULL_PTR
   USE H5GLOBAL
   IMPLICIT NONE
 
diff --git a/fortran/src/H5VLff.F90 b/fortran/src/H5VLff.F90
index 56edccb8f4..5a1fa9fd3b 100644
--- a/fortran/src/H5VLff.F90
+++ b/fortran/src/H5VLff.F90
@@ -37,7 +37,6 @@
 
 MODULE H5VL
 
-  USE, INTRINSIC :: ISO_C_BINDING, ONLY : C_PTR, C_FUNPTR, C_CHAR, C_INT64_T, C_INT
   USE H5GLOBAL
   USE H5fortkit
 
diff --git a/fortran/src/H5Zff.F90 b/fortran/src/H5Zff.F90
index a31e597214..eae94c5bb8 100644
--- a/fortran/src/H5Zff.F90
+++ b/fortran/src/H5Zff.F90
@@ -38,6 +38,7 @@
 MODULE H5Z
 
   USE H5GLOBAL
+  IMPLICIT NONE
 
 CONTAINS
 
diff --git a/fortran/src/H5_ff.F90 b/fortran/src/H5_ff.F90
index ecea23d119..42e70582a1 100644
--- a/fortran/src/H5_ff.F90
+++ b/fortran/src/H5_ff.F90
@@ -51,7 +51,6 @@
 
 MODULE H5LIB
 
-  USE, INTRINSIC :: ISO_C_BINDING, ONLY : C_PTR, C_INTPTR_T, C_INT64_T
   USE H5GLOBAL
   IMPLICIT NONE