mirror/hdf5
2
0
Fork 0
mirror of https://github.com/HDFGroup/hdf5.git synced 2025-03-13 16:47:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

Added int variable for comparison with H5_VERS_RELEASE in H5.c to avoid (#866)

Browse Source 
warning that unsigned comparison < 0 is always false, which is known,
        but for later versions the comparison can possibly be true.
This commit is contained in:
Larry Knox 2021-07-29 20:18:37 -05:00 committed by GitHub
parent 9bb1d6d78e
commit 9fd356e240
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/H5.c
View File

@ -912,6 +912,8 @@ H5check_version(unsigned majnum, unsigned minnum, unsigned relnum)
static unsigned int disable_version_check = 0; /* Set if the version check should be disabled */
static const char * version_mismatch_warning = VERSION_MISMATCH_WARNING;
herr_t ret_value = SUCCEED; /* Return value */
int releasenum = relnum; /* To avoid warning for unsigned < 0
comparison in first release versions */
FUNC_ENTER_API_NOINIT_NOERR_NOFS
H5TRACE3("e", "IuIuIu", majnum, minnum, relnum);
@ -931,7 +933,7 @@ H5check_version(unsigned majnum, unsigned minnum, unsigned relnum)
}
/* H5_VERS_MAJOR and H5_VERS_MINOR must match */
if (H5_VERS_MAJOR != majnum || H5_VERS_MINOR != minnum || H5_VERS_RELEASE > relnum) {
if (H5_VERS_MAJOR != majnum || H5_VERS_MINOR != minnum || H5_VERS_RELEASE > releasenum) {
switch (disable_version_check) {
case 0:
HDfprintf(stderr, "%s%s", version_mismatch_warning,