mirror/hdf5
2
0
Fork 0
mirror of https://github.com/HDFGroup/hdf5.git synced 2025-02-23 16:20:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

[svn-r18166] Purpose:

Browse Source 
Take care of test case fail for h5repack from checkin (r18164)

Description:
    Previous checkin didn't allow h5diff to return succeed when a link's 
    target object doesn't exist. Changed it to succeed with warning.
    (Need to discuss related feature)

Tested on Jam
This commit is contained in:
Jonathan Kim 2010-01-25 19:20:16 -05:00
parent 985a261886
commit 98639557ac
4 changed files with 22 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tools/h5diff/testfiles/h5diff_400.txt
View File

@ -35,8 +35,11 @@ link : </softlink_group2> and </softlink_group2>
group : </target_group> and </target_group>
0 differences found
0 differences found
error: "/no_obj" doesn't exist
error: unable to get softlink info from "/softlink_noexist"
warn: link target "/no_obj" doesn't exist
warn: link target "/no_obj" doesn't exist
link : </softlink_noexist> and </softlink_noexist>
Comparison not supported: </no_obj> and </no_obj> are of type unknown type
0 differences found
dataset: </target_dset1> and </target_dset1>
0 differences found
dataset: </target_dset2> and </target_dset2>
@ -45,3 +48,7 @@ group : </target_group> and </target_group>
0 differences found
dataset: </target_group/dset> and </target_group/dset>
0 differences found
--------------------------------
Some objects are not comparable
--------------------------------
Use -c for a list of objects.

8
tools/h5diff/testfiles/h5diff_417.txt
View File

@ -1,2 +1,6 @@
error: "/no_obj" doesn't exist
error: unable to get softlink info from "/softlink_noexist"
warn: link target "/no_obj" doesn't exist
</no_obj> is of type unknown type and </target_dset2> is of type H5G_DATASET
--------------------------------
Some objects are not comparable
--------------------------------
Use -c for a list of objects.

8
tools/h5diff/testfiles/h5diff_418.txt
View File

@ -1,2 +1,6 @@
error: "/no_obj" doesn't exist
error: unable to get softlink info from "/softlink_noexist"
warn: link target "/no_obj" doesn't exist
</target_dset2> is of type H5G_DATASET and </no_obj> is of type unknown type
--------------------------------
Some objects are not comparable
--------------------------------
Use -c for a list of objects.

3
tools/lib/h5diff.c
View File

@ -278,8 +278,7 @@ static int H5tools_get_softlink_target_info(hid_t file_id, const char * linkpath
}
else
{
parallel_print("error: \"%s\" doesn't exist \n", s_trg_info->path);
goto out;
parallel_print("warn: link target \"%s\" doesn't exist \n", s_trg_info->path);
}
/* set target obj type to return */