mirror/hdf5
2
0
Fork 0
mirror of https://github.com/HDFGroup/hdf5.git synced 2025-03-19 16:50:46 +08:00
Code Issues Packages Projects Releases Wiki Activity

[svn-r11786] Purpose:

Browse Source 
Minor bug fixes.

Description:
1.  Changed free() calls to HDfree()
2.  Corrected behavior of -m command-line parameter
3.  Changed return value to always return 0.

Solution:

2.  The -m flag tells the test to run only the MPI IO tests.  However, it would incorrectly make
the test run both the MPI and POSIX tests (same as the default behavior).

3.  This test is known to fail on many platforms, and, even on those platforms where it usually passes,
it is known to suffer transient failures (especially with small test file sizes).  It's outcome is
also very dependent on the filesystem on which the testfile is created.  Corrected
the program to always return success, so that it doesn't interfere with the daily tests.

The motivation for this is that
this test has nothing to do with the HDF library and is an auxiliary test.  Failures in t_posix_complaint
do not necessarily mean that parallel HDF will fail, but simply indicate something to look into,
especially on new platforms.  This is now an "output only" test, and any errors will be only be visible
in the output.

Platforms tested:
copper (all of these were minor changes)

Misc. update:
This commit is contained in:
Leon Arber 2005-12-11 13:40:07 -05:00
parent 86ee1cc2ff
commit 8d90fdaf96
1 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
testpar/t_posix_compliant.c
View File

@ -114,8 +114,8 @@ static int allwrite_allread_blocks(int numprocs, int rank, int write_size)
mpio_result = MPI_File_close(&fh);
CHECK_SUCCESS(mpio_result);
free(writebuf);
free(readbuf);
HDfree(writebuf);
HDfree(readbuf);
return err_flag;
@ -188,8 +188,8 @@ static int posix_allwrite_allread_blocks(int numprocs, int rank, int write_size)
if(rank == 0)
unlink(testfile);
free(writebuf);
free(readbuf);
HDfree(writebuf);
HDfree(readbuf);
return err_flag;
}
@ -267,8 +267,8 @@ static int posix_onewrite_allread_blocks(int numprocs, int rank, int write_size)
if(rank == 0)
unlink(testfile);
free(writebuf);
free(readbuf);
HDfree(writebuf);
HDfree(readbuf);
return err_flag;
}
@ -355,8 +355,8 @@ static int posix_onewrite_allread_interlaced(int numprocs, int rank, int write_s
if(rank == 0)
unlink(testfile);
free(writebuf);
free(readbuf);
HDfree(writebuf);
HDfree(readbuf);
return err_flag;
}
@ -424,8 +424,8 @@ static int allwrite_allread_interlaced(int numprocs, int rank, int write_size)
mpio_result = MPI_File_close(&fh);
CHECK_SUCCESS(mpio_result);
free(writebuf);
free(readbuf);
HDfree(writebuf);
HDfree(readbuf);
return err_flag;
@ -544,8 +544,8 @@ static int allwrite_allread_overlap(int numprocs, int rank, int write_size)
mpio_result = MPI_File_close(&fh);
CHECK_SUCCESS(mpio_result);
free(writebuf);
free(readbuf);
HDfree(writebuf);
HDfree(readbuf);
return err_flag;
@ -593,8 +593,8 @@ static int onewrite_allread_blocks(int numprocs, int rank, int write_size)
mpio_result = MPI_File_close(&fh);
CHECK_SUCCESS(mpio_result);
free(writebuf);
free(readbuf);
HDfree(writebuf);
HDfree(readbuf);
return err_flag;
@ -656,8 +656,8 @@ static int onewrite_allread_interlaced(int numprocs, int rank, int write_size)
mpio_result = MPI_File_close(&fh);
CHECK_SUCCESS(mpio_result);
free(writebuf);
free(readbuf);
HDfree(writebuf);
HDfree(readbuf);
return err_flag;
@ -698,7 +698,7 @@ int main(int argc, char* argv[])
break;
case 'm':
mpi_tests = 1;
posix_tests = 1;
posix_tests = 0;
break;
case 'p':
/* need 2 extra--1 for the / and 1 for the terminating NULL. */
@ -829,7 +829,7 @@ done:
MPI_Barrier(MPI_COMM_WORLD);
MPI_Finalize();
return err_flag;
return 0;
}