mirror/hdf5
2
0
Fork 0
mirror of https://github.com/HDFGroup/hdf5.git synced 2025-01-30 15:32:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

[svn-r9814] Purpose: Bug fix

Browse Source 
Description:  the last 2 bytes of mantissa can be lost when converting from unsigned long long
to long double.  In last check-in, a fix was made to ignore that precision loss.  But sometimes,
the last 2 bytes are rounded up to the 3rd last byte.

Solution:  Ignore the 3rd last byte, too, when comparing values.

Platforms tested: sleipnir - only this system is concerned.
This commit is contained in:
Raymond Lu 2005-01-12 15:40:36 -05:00
parent 39b18b8e0f
commit 524830d67e
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test/dtypes.c
View File

@ -5851,7 +5851,8 @@ test_conv_int_float(const char *name, hid_t src, hid_t dst)
/* For GNU compilers on FreeBSD(sleipnir), during conversion from 'unsigned long long'
* to 'long double', the last 2 bytes of mantissa are lost. But this loss seems
* acceptable. We allow it go through instead of fail it.
* acceptable. We allow it to go through instead of fail it. Sometimes, there's roundup
* to the 3rd last byte of mantissa. So we only try to compare all but the last 3 bytes.
*/
#ifndef H5_ULLONG_TO_LDOUBLE_PRECISION_WORKS
if(src_type==INT_ULLONG && dst_type==FLT_LDOUBLE) {
@ -5859,7 +5860,7 @@ test_conv_int_float(const char *name, hid_t src, hid_t dst)
HDmemcpy(&tmp_s,&buf[j*dst_size],sizeof(long double));
HDmemcpy(&tmp_h,&hw[0],sizeof(long double));
/*Don't compare the last 2 bytes of mantissa*/
if(!HDmemcmp(&tmp_s+2, &tmp_h+2, sizeof(long double)-2))
if(!HDmemcmp(&tmp_s+3, &tmp_h+3, sizeof(long double)-3))
continue; /*no error*/
}
#endif /*end H5_ULLONG_TO_LDOUBLE_PRECISION_WORKS*/