mirror/hdf5
2
0
Fork 0
mirror of https://github.com/HDFGroup/hdf5.git synced 2025-04-18 17:40:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

[svn-r17058] added some "dummy" declarations for d_status

Browse Source 
this error
home/hdftest/snapshots-hdf5/current/tools/lib/h5tools_ref.c:126: undefined reference to `d_status'

happens because the original developer of h5tools_ref.c declared these 2 variables in that source file

extern char   *progname;
extern int    d_status;

this means that all programs that use this source file (typically all tools) will have to define these 2 variables, even if they are *not* used. 

examples

const char *progname = "h5jam";
int d_status = EXIT_SUCCESS;

"progname" is usually used to print the program name in the usage, and "d_status" is just a return value of the tool, usually.

I was wondering about removing these 2 declarations from h5tools_ref.c

extern char   *progname;
extern int    d_status;

and define those variables on each tool if they are only needed (it seems to me that only h5ls and h5dump actually "need" them)

tested: smirom parallel
This commit is contained in:
Pedro Vicente Nunes 2009-06-16 13:19:40 -05:00
parent 5e8d84b421
commit 41b80569d7
2 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/h5diff/h5diffgentest.c
View File

@ -97,6 +97,9 @@ static int write_dset(hid_t loc_id,int rank,hsize_t *dims,const char *name,hid_t
*-------------------------------------------------------------------------
*/
/* module-scoped variables */
int d_status = EXIT_SUCCESS;
int main(void)
{
test_basic(FILE1, FILE2, FILE11);

2
tools/h5diff/ph5diff_main.c
View File

@ -52,6 +52,8 @@ static void ph5diff_worker(int );
*-------------------------------------------------------------------------
*/
/* module-scoped variables */
int d_status = EXIT_SUCCESS;
int main(int argc, const char *argv[])
{