mirror/hdf5
2
0
Fork 0
mirror of https://github.com/HDFGroup/hdf5.git synced 2025-03-31 17:10:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

[svn-r20901] Remove if() that avoided a copy of the last element to itself. This was to solve an issue of a difference between 1.8 and trunk. 1.8 used the wrong variable in the if() and upon reflection the if() was determined to be unnecessary and complicated the logic. 1.8 tests would have treated the if() as always true with the result being the same as though the if() was absent.

Browse Source 
This change reflects that equivalance and will avoid a potential problem in 1.8.

Tested: local linux, reviewed by two developers
This commit is contained in:
Allen Byrne 2011-05-25 10:14:06 -05:00
parent e082497e0c
commit 1fd585a5a0
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hl/src/H5DS.c
View File

@ -813,10 +813,8 @@ herr_t H5DSdetach_scale(hid_t did,
/* same object, reset. we want to detach only for this DIM */
if(did_oi.fileno == tmp_oi.fileno && did_oi.addr == tmp_oi.addr) {
/* if we found not the last one, copy the last one to replace
the one which is found */
if(ii < nelmts-1)
dsbuf[ii] = dsbuf[nelmts-1];
/* copy the last one to replace the one which is found */
dsbuf[ii] = dsbuf[nelmts-1];
nelmts--;
found_dset=1;
break;