mirror/hdf5
2
0
Fork 0
mirror of https://github.com/HDFGroup/hdf5.git synced 2025-03-13 16:47:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

[svn-r13485] Description:

Browse Source 
Fix reference to uninitialized memory, which could trigger a memory
corruption, once in a purple moon.

Tested on:
	FreeBSD/32 6.2 (duty) 	w/valgrind
This commit is contained in:
Quincey Koziol 2007-03-09 23:50:28 -05:00
parent 56b7fd71a3
commit 1bca28acc3
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/H5Z.c
View File

@ -797,25 +797,25 @@ H5Z_append(H5O_pline_t *pline, H5Z_filter_t filter, unsigned flags,
* filter struct is reallocated. Set these pointers to ~NULL
* so that we can reset them after reallocating the filters array.
*/
for(n=0; n<pline->nalloc; ++n) {
for(n = 0; n < pline->nalloc; ++n)
if(pline->filter[n].cd_values == pline->filter[n]._cd_values)
pline->filter[n].cd_values = (void *) ~((size_t)NULL);
}
x.nalloc = MAX(H5Z_MAX_NFILTERS, 2 * pline->nalloc);
x.filter = H5MM_realloc(pline->filter, x.nalloc*sizeof(x.filter[0]));
x.filter = H5MM_realloc(pline->filter, x.nalloc * sizeof(x.filter[0]));
if(NULL == x.filter)
HGOTO_ERROR(H5E_RESOURCE, H5E_NOSPACE, FAIL, "memory allocation failed for filter pipeline")
/* Fix pointers in previous filters that need to point to their own
* internal data.
*/
for(n = 0; n < pline->nalloc; ++n)
if(x.filter[n].cd_values == (void *) ~((size_t) NULL))
x.filter[n].cd_values = x.filter[n]._cd_values;
/* Point to newly allocated buffer */
pline->nalloc = x.nalloc;
pline->filter = x.filter;
/* Fix pointers in filters that need to point to their own internal
* data.
*/
for(n=0; n<pline->nalloc; ++n) {
if(pline->filter[n].cd_values == (void *) ~((size_t) NULL))
pline->filter[n].cd_values = pline->filter[n]._cd_values;
}
} /* end if */
/* Add the new filter to the pipeline */