mirror/hdf5
2
0
Fork 0
mirror of https://github.com/HDFGroup/hdf5.git synced 2025-03-31 17:10:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

[svn-r4589] Purpose:

Browse Source 
Code cleanup
Description:
    Clean up various compiler warnings from generic property updates.
Platforms tested:
    FreeBSD 4.4 (hawkwind)
This commit is contained in:
Quincey Koziol 2001-11-03 17:27:54 -05:00
parent 3af26fa7a5
commit 0001a13617
18 changed files with 49 additions and 71 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
perform/iopipe.c
View File

@ -7,7 +7,6 @@
*/
/* See H5private.h for how to include headers */
#undef NDEBUG
#include "hdf5.h"
#ifdef H5_HAVE_WINSOCK_H
@ -17,36 +16,6 @@
/*Winsock.h includes windows.h, due to the different value of
WINVER, windows.h should be put before H5private.h. Kent yang 6/21/2001*/
#include "H5private.h"
#ifdef H5_STDC_HEADERS
# include <assert.h>
# include <fcntl.h>
# include <stdio.h>
# include <string.h>
# include <stdlib.h>
#endif
#ifdef H5_HAVE_UNISTD_H
# include <sys/types.h>
# include <unistd.h>
#endif
#if defined(H5_TIME_WITH_SYS_TIME)
# include <sys/time.h>
# include <time.h>
#elif defined(H5_HAVE_SYS_TIME_H)
# include <sys/time.h>
#else
# include <time.h>
#endif
#ifdef H5_HAVE_SYS_RESOURCE_H
# include <sys/resource.h>
#endif
#if defined (__MWERKS__)
#ifdef H5_HAVE_SYS_TIMEB
#undef H5_HAVE_SYS_TIMEB
@ -56,6 +25,7 @@ WINVER, windows.h should be put before H5private.h. Kent yang 6/21/2001*/
#endif
#endif /* __MWERKS__*/
#include "H5private.h"
#ifdef H5_HAVE_SYS_TIMEB
#include <sys/timeb.h>

5
src/H5F.c
View File

@ -1034,7 +1034,9 @@ H5F_new(H5F_file_t *shared, hid_t fcpl_id, hid_t fapl_id)
{
H5F_t *f=NULL, *ret_value=NULL;
int n;
#ifdef H5_HAVE_PARALLEL
hid_t driver_id = -1;
#endif /* H5_HAVE_PARALLEL */
FUNC_ENTER(H5F_new, NULL);
@ -1774,9 +1776,6 @@ H5Fcreate(const char *filename, unsigned flags, hid_t fcpl_id,
H5F_t *new_file = NULL; /*file struct for new file */
hid_t ret_value = FAIL; /*return value */
size_t meta_block_size = 0;
hid_t driver_id=-1;
FUNC_ENTER(H5Fcreate, FAIL);
H5TRACE4("i","sIuii",filename,flags,fcpl_id,fapl_id);

5
src/H5FDcore.c
View File

@ -13,8 +13,9 @@
#include "H5Eprivate.h" /*error handling */
#include "H5Fprivate.h" /*files */
#include "H5FDprivate.h" /*file driver */
#include "H5FDcore.h" /* Core file driver */
#include "H5MMprivate.h" /* Memory allocation */
#include "H5FDcore.h" /* Core file driver */
#include "H5Iprivate.h" /*object IDs */
#include "H5MMprivate.h" /* Memory allocation */
#include "H5Pprivate.h" /*property lists */
#undef MAX

1
src/H5FDdpss.c
View File

@ -14,6 +14,7 @@
#include "H5Eprivate.h" /* error handling */
#include "H5FDprivate.h" /*file driver */
#include "H5FDdpss.h"
#include "H5Iprivate.h" /*object IDs */
#include "H5MMprivate.h" /* memory management */
#ifdef COALESCE_READS

9
src/H5FDfamily.c
View File

@ -25,8 +25,9 @@
#include "H5Eprivate.h" /*error handling */
#include "H5Fprivate.h" /*files */
#include "H5FDprivate.h" /*file driver */
#include "H5FDfamily.h" /* Family file driver */
#include "H5MMprivate.h" /* Memory allocation */
#include "H5FDfamily.h" /* Family file driver */
#include "H5Iprivate.h" /*object IDs */
#include "H5MMprivate.h" /* Memory allocation */
#include "H5Pprivate.h" /*property lists */
@ -181,7 +182,7 @@ H5Pset_fapl_family(hid_t fapl_id, hsize_t memb_size, hid_t memb_fapl_id)
H5TRACE3("e","ihi",fapl_id,memb_size,memb_fapl_id);
/* Check arguments */
if(H5I_GENPROP_LST != H5I_get_type(fapl_id) ||
if(H5I_GENPROP_LST != H5Iget_type(fapl_id) ||
TRUE != H5Pisa_class(fapl_id, H5P_FILE_ACCESS))
HRETURN_ERROR(H5E_ARGS, H5E_BADTYPE, FAIL,
"not a file access property list");
@ -233,7 +234,7 @@ H5Pget_fapl_family(hid_t fapl_id, hsize_t *memb_size/*out*/,
FUNC_ENTER(H5Pget_fapl_family, FAIL);
H5TRACE3("e","ixx",fapl_id,memb_size,memb_fapl_id);
if(H5I_GENPROP_LST != H5I_get_type(fapl_id) ||
if(H5I_GENPROP_LST != H5Iget_type(fapl_id) ||
TRUE != H5Pisa_class(fapl_id, H5P_FILE_ACCESS))
HRETURN_ERROR(H5E_ARGS, H5E_BADTYPE, FAIL, "not a file access list");
if (H5FD_FAMILY!=H5P_get_driver(fapl_id))

5
src/H5FDgass.c
View File

@ -12,8 +12,9 @@
#include "H5Eprivate.h" /*error handling */
#include "H5Fprivate.h" /*files */
#include "H5FDprivate.h" /*file driver */
#include "H5FDgass.h" /* Core file driver */
#include "H5MMprivate.h" /* Memory allocation */
#include "H5FDgass.h" /* Core file driver */
#include "H5Iprivate.h" /*object IDs */
#include "H5MMprivate.h" /* Memory allocation */
#include "H5Pprivate.h" /*property lists */

5
src/H5FDlog.c
View File

@ -18,9 +18,10 @@
#include "H5Eprivate.h" /*error handling */
#include "H5Fprivate.h" /*files */
#include "H5FDprivate.h" /*file driver */
#include "H5FDlog.h" /* logging file driver */
#include "H5FDlog.h" /* logging file driver */
#include "H5FLprivate.h" /*Free Lists */
#include "H5MMprivate.h" /* Memory allocation */
#include "H5Iprivate.h" /*object IDs */
#include "H5MMprivate.h" /* Memory allocation */
#include "H5Pprivate.h" /*property lists */

5
src/H5FDmpio.c
View File

@ -24,8 +24,9 @@
#include "H5Eprivate.h" /*error handling */
#include "H5Fprivate.h" /*files */
#include "H5FDprivate.h" /*file driver */
#include "H5FDmpio.h" /* MPI I/O file driver */
#include "H5MMprivate.h" /* Memory allocation */
#include "H5FDmpio.h" /* MPI I/O file driver */
#include "H5Iprivate.h" /*object IDs */
#include "H5MMprivate.h" /* Memory allocation */
#include "H5Pprivate.h" /*property lists */
/*

6
src/H5FDmulti.c
View File

@ -14,7 +14,9 @@
#include <stdlib.h>
#include "hdf5.h"
#ifdef QAK
#include "H5private.h" /* library function */
#endif /* QAK */
/*
* Define H5FD_MULTI_DEBUG if you want the ability to print debugging
@ -402,7 +404,7 @@ H5Pset_fapl_multi(hid_t fapl_id, const H5FD_mem_t *memb_map,
H5Eclear();
/* Check arguments and supply default values */
if(H5I_GENPROP_LST != H5I_get_type(fapl_id) ||
if(H5I_GENPROP_LST != H5Iget_type(fapl_id) ||
TRUE != H5Pisa_class(fapl_id, H5P_FILE_ACCESS))
H5Epush_ret(func, H5E_PLIST, H5E_BADVALUE, "not an access list", -1);
if (!memb_map) {
@ -499,7 +501,7 @@ H5Pget_fapl_multi(hid_t fapl_id, H5FD_mem_t *memb_map/*out*/,
/* Clear the error stack */
H5Eclear();
if(H5I_GENPROP_LST != H5I_get_type(fapl_id) ||
if(H5I_GENPROP_LST != H5Iget_type(fapl_id) ||
TRUE != H5Pisa_class(fapl_id, H5P_FILE_ACCESS))
H5Epush_ret(func, H5E_PLIST, H5E_BADTYPE, "not an access list", -1);
if (H5FD_MULTI!=H5Pget_driver(fapl_id))

7
src/H5FDsec2.c
View File

@ -16,9 +16,10 @@
#include "H5Eprivate.h" /*error handling */
#include "H5Fprivate.h" /*files */
#include "H5FDprivate.h" /*file driver */
#include "H5FDsec2.h" /* Sec2 file driver */
#include "H5FDsec2.h" /* Sec2 file driver */
#include "H5FLprivate.h" /*Free Lists */
#include "H5MMprivate.h" /* Memory allocation */
#include "H5Iprivate.h" /*object IDs */
#include "H5MMprivate.h" /* Memory allocation */
#include "H5Pprivate.h" /*property lists */
#ifdef MAX
@ -204,7 +205,7 @@ H5FD_sec2_init(void)
{
FUNC_ENTER(H5FD_sec2_init, FAIL);
if (H5I_VFL!=H5Iget_type(H5FD_SEC2_g))
if (H5I_VFL!=H5I_get_type(H5FD_SEC2_g))
H5FD_SEC2_g = H5FDregister(&H5FD_sec2_g);
FUNC_LEAVE(H5FD_SEC2_g);

1
src/H5FDsrb.c
View File

@ -12,6 +12,7 @@
#include "H5Fprivate.h" /*files */
#include "H5FDprivate.h" /*file driver */
#include "H5FDsrb.h" /* Core file driver */
#include "H5Iprivate.h" /*object IDs */
#include "H5MMprivate.h" /* Memory allocation */
#include "H5Pprivate.h" /*property lists */

6
src/H5FDstdio.c
View File

@ -15,7 +15,9 @@
#include <sys/stat.h>
#include "hdf5.h"
#ifdef QAK
#include "H5private.h" /* library function */
#endif /* QAK */
#ifdef H5_HAVE_STDIO_H
#include <stdio.h>
@ -228,8 +230,8 @@ H5Pset_fapl_stdio(hid_t fapl_id)
/* Clear the error stack */
H5Eclear();
if(H5I_GENPROP_LST != H5I_get_type(fapl_id) ||
TRUE != H5Pisa_class(fapl_id, H5P_FILE_ACCESS)) {
if(H5I_GENPROP_LST != H5Iget_type(fapl_id) ||
0 == H5Pisa_class(fapl_id, H5P_FILE_ACCESS)) {
H5Epush_ret(func, H5E_PLIST, H5E_BADTYPE,
"not a file access property list", -1);
}

6
src/H5Fprivate.h
View File

@ -436,9 +436,9 @@ __DLL__ herr_t H5F_addr_pack(H5F_t *f, haddr_t *addr_p /*out*/,
const unsigned long objno[2]);
/* callback Functions for file access class */
__DLL__ herr_t H5F_acs_create(hid_t fapl_id, void UNUSED *close_data);
__DLL__ herr_t H5F_acs_close(hid_t fapl_id, void UNUSED *close_data);
__DLL__ herr_t H5F_acs_create(hid_t fapl_id, void *close_data);
__DLL__ herr_t H5F_acs_close(hid_t fapl_id, void *close_data);
__DLL__ herr_t H5F_acs_copy(hid_t new_fapl_id, hid_t old_fapl_id,
void UNUSED *close_data);
void *close_data);
#endif

14
src/H5P.c
View File

@ -158,16 +158,13 @@ H5P_init_interface(void)
{
H5P_genclass_t *root_class; /* Pointer to root property list class created */
H5P_genclass_t *pclass; /* Pointer to property list class to create */
herr_t ret_value = SUCCEED;
int i;
herr_t status;
herr_t ret_value = SUCCEED;
FUNC_ENTER(H5P_init_interface, FAIL);
if (ret_value < 0) {
HRETURN_ERROR(H5E_ATOM, H5E_CANTINIT, FAIL,
"unable to initialize atom group");
}
/* Make certain IDs are initialized */
if (ret_value < 0)
HRETURN_ERROR(H5E_ATOM, H5E_CANTINIT, FAIL, "unable to initialize atom group");
/*
* Initialize the Generic Property class & object groups.
@ -231,7 +228,6 @@ H5P_init_interface(void)
if ((H5P_CLS_MOUNT_g = H5I_register (H5I_GENPROP_CLS, pclass))<0)
HRETURN_ERROR (H5E_PLIST, H5E_CANTREGISTER, FAIL, "can't register property list class");
FUNC_LEAVE(ret_value);
}
@ -255,7 +251,7 @@ H5P_init_interface(void)
int
H5P_term_interface(void)
{
int i, n=0;
int n=0;
if (interface_initialize_g) {
/* Destroy HDF5 library property classes & lists */

1
src/H5Ppublic.h
View File

@ -140,7 +140,6 @@ __DLL__ herr_t H5Pcopy_prop(hid_t dst_id, hid_t src_id, const char *name);
__DLL__ herr_t H5Premove(hid_t plist_id, const char *name);
__DLL__ herr_t H5Punregister(hid_t pclass_id, const char *name);
__DLL__ herr_t H5Pclose_class(hid_t plist_id);
__DLL__ hid_t H5Pcreate(hid_t type);
__DLL__ herr_t H5Pclose(hid_t plist_id);
__DLL__ hid_t H5Pcopy(hid_t plist_id);
__DLL__ herr_t H5Pget_version(hid_t plist_id, int *boot/*out*/,

2
src/H5Tvlen.c
View File

@ -449,7 +449,7 @@ herr_t H5T_vlen_disk_read(H5F_t *f, void *vl_addr, void *buf, size_t UNUSED len)
*
*-------------------------------------------------------------------------
*/
herr_t H5T_vlen_disk_write(hid_t plist_id, H5F_t *f, void *vl_addr, void *buf, hsize_t seq_len, hsize_t base_size)
herr_t H5T_vlen_disk_write(hid_t UNUSED plist_id, H5F_t *f, void *vl_addr, void *buf, hsize_t seq_len, hsize_t base_size)
{
uint8_t *vl=(uint8_t *)vl_addr; /* Pointer to the user's hvl_t information */
H5HG_t hobjid;

4
src/H5Vprivate.h
View File

@ -95,10 +95,10 @@ __DLL__ hsize_t H5V_array_offset(unsigned n, const hsize_t *total_size,
*
*-------------------------------------------------------------------------
*/
static H5_inline hsize_t UNUSED
static H5_inline hsize_t
H5V_vector_reduce_product(unsigned n, const hsize_t *v)
{
size_t ans = 1;
hsize_t ans = 1;
if (n && !v) return 0;
while (n--) ans *= *v++;

6
test/tfile.c
View File

@ -63,7 +63,8 @@ test_file_create(void)
hsize_t ublock; /*sizeof userblock */
size_t parm; /*file-creation parameters */
size_t parm2; /*file-creation parameters */
int iparm, iparm2;
int iparm;
unsigned iparm2;
herr_t ret; /*generic return value */
/* Output message about test being performed */
@ -295,7 +296,8 @@ test_file_open(void)
hsize_t ublock; /*sizeof user block */
size_t parm; /*file-creation parameters */
size_t parm2; /*file-creation parameters */
int iparm, iparm2;
int iparm;
unsigned iparm2;
herr_t ret; /*generic return value */
/* Output message about test being performed */