mirror of
https://github.com/gradio-app/gradio.git
synced 2025-04-12 12:40:29 +08:00
* Fix the download button of the `gr.Gallery()` component to work * Refactoring js/gallery/shared/Gallery.svelte * Fix `gr.Gallery()` to set `orig_name` for URLs * Fix Gallery.postprocess() * Fix `download()` to fallback to `window.open()` when CORS is not allowed * Fix `gr.Gallery` to leave as None so it will be replaced with a local cache path and restore the `<a>` tag-based download feature on the frontend * Align a variable name to its type name * Fix Gallery's tests * Fix the frontend test for gallery * Revert "Fix `gr.Gallery` to leave as None so it will be replaced with a local cache path and restore the `<a>` tag-based download feature on the frontend" This reverts commit d754980cc27ded760bfc26df4310f913c2c6944a. * Revert "Fix Gallery's tests" This reverts commit 4e2aa3fff1ef7b586839fa6c485d1a3b8738fd03. * Revert "Fix the frontend test for gallery" This reverts commit 007caa23e7b9dbab36376307137a30f277fca297. * Fix for linter * Add a test about the download button * Fix type defs on Gallery.postprocess * Improve TestGallery * add changeset * Update gradio/components/gallery.py Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * Update gradio/components/gallery.py Co-authored-by: Abubakar Abid <abubakar@huggingface.co> * Revert "Update gradio/components/gallery.py" This reverts commit 4d6e12730511fe9840a5372787ad81fd83cbb44c. * Revert "Update gradio/components/gallery.py" This reverts commit f2bfad0744d20e121c8eef40a335979a7c703517. * Use `tuple` instead of `typing.Tuple` * Revert "Use `tuple` instead of `typing.Tuple`" This reverts commit 69ab93cad4f39fe38f0e0f88126be572bf12cecf. --------- Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com> Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
Backend Testing Guidelines
- All the tests should test Backend functionalities. Frontend functionalities and e2e tests are done in Frontend.
- Make use of pytest fixtures whenever it is possible. With fixtures, objects with high initialize durations are reused within tests, ex. a client session.
- All testdata resides within _gradio/test_data and all test_files resides within test/test_files.
- When doing network operations do not forget to make use of async to make tests faster.
- Have clear class and function naming within the tests.
- Short descriptions within test functions are great.
- Library function docstrings is expected to contain an example, please add missing docstrings to the library while you are writing tests the related function.
- Library docstring examples and descriptions are expected to align with tests, please fix divergent tests and library docstrings.