From d3e1d272d50245ce6f875bb6098113e44876b69e Mon Sep 17 00:00:00 2001 From: Freddy Boulton Date: Wed, 12 Jul 2023 21:08:36 -0400 Subject: [PATCH] Fix flaky ui test (#4906) * Debug * Upload screenshots * Fix path * turn on verbose mode * turn on verbose mode * turn on verbose mode * await click * cleanup * trigger ci --------- Co-authored-by: pngwn --- .config/playwright.config.js | 2 +- .github/workflows/ui.yml | 7 +++++++ js/app/test/blocks_chained_events.spec.ts | 2 +- package.json | 2 +- 4 files changed, 10 insertions(+), 3 deletions(-) diff --git a/.config/playwright.config.js b/.config/playwright.config.js index cf8fb79278..7172e17f97 100644 --- a/.config/playwright.config.js +++ b/.config/playwright.config.js @@ -5,5 +5,5 @@ export default { }, testMatch: /.*.spec.ts/, testDir: "..", - globalSetup: "./playwright-setup.js" + globalSetup: "./playwright-setup.js", }; diff --git a/.github/workflows/ui.yml b/.github/workflows/ui.yml index 4c0e84aad1..825fe18cfd 100644 --- a/.github/workflows/ui.yml +++ b/.github/workflows/ui.yml @@ -53,6 +53,13 @@ jobs: run: | . venv/bin/activate pnpm test:browser + - name: upload screenshots + uses: actions/upload-artifact@v3 + if: always() + with: + name: playwright-screenshots + path: | + ./test-results - name: run browser component tests run: | . venv/bin/activate diff --git a/js/app/test/blocks_chained_events.spec.ts b/js/app/test/blocks_chained_events.spec.ts index df3c73cf07..03ee6dcb67 100644 --- a/js/app/test/blocks_chained_events.spec.ts +++ b/js/app/test/blocks_chained_events.spec.ts @@ -91,7 +91,7 @@ test("gr.Info makes the toast show up", async ({ page }) => { }); test("gr.Warning makes the toast show up", async ({ page }) => { - page.click("text=Trigger Warning"); + await page.click("text=Trigger Warning"); const toast = page.getByTestId("toast-body"); expect(toast).toContainText("This is a warning!"); diff --git a/package.json b/package.json index dae6c287c5..c68615fdea 100644 --- a/package.json +++ b/package.json @@ -21,7 +21,7 @@ "test:node": "TEST_MODE=node pnpm vitest run --config .config/vitest.config.ts", "test:browser": "pnpm --filter @gradio/app test:browser", "test:browser:full": "run-s build test:browser", - "test:browser:verbose": "GRADIO_TEST_VERBOSE=true pnpm test:browser", + "test:browser:verbose": "pnpm test:browser", "test:browser:dev": "pnpm --filter @gradio/app test:browser:dev", "ci:publish": "pnpm publish --no-git-checks --access public -r", "ci:version": "changeset version && pnpm i --lockfile-only",