From b5126adf8d67661c92345b5334b919921873fddb Mon Sep 17 00:00:00 2001 From: Ali Abid Date: Tue, 22 Feb 2022 22:31:01 -0800 Subject: [PATCH] restore flagging options --- ui/packages/app/src/App.svelte | 2 + ui/packages/app/src/Interface.svelte | 64 ++++++++++++++++++++++------ 2 files changed, 53 insertions(+), 13 deletions(-) diff --git a/ui/packages/app/src/App.svelte b/ui/packages/app/src/App.svelte index 1a780eb6cb..51aa7b4d42 100644 --- a/ui/packages/app/src/App.svelte +++ b/ui/packages/app/src/App.svelte @@ -34,6 +34,7 @@ export let root: string; export let space: string | undefined = undefined; export let allow_flagging: string; + export let flagging_options: Array | undefined = undefined; export let allow_interpretation: boolean; export let live: boolean; export let queue: boolean; @@ -69,6 +70,7 @@ {fn} {root} {allow_flagging} + {flagging_options} {allow_interpretation} {live} {queue} diff --git a/ui/packages/app/src/Interface.svelte b/ui/packages/app/src/Interface.svelte index c8d5744064..3d1314bd2a 100644 --- a/ui/packages/app/src/Interface.svelte +++ b/ui/packages/app/src/Interface.svelte @@ -19,6 +19,7 @@ export let examples: Array>; export let root: string; export let allow_flagging: string; + export let flagging_options: Array | undefined = undefined; export let allow_interpretation: boolean; export let avg_durations: undefined | Array = undefined; export let live: boolean; @@ -33,6 +34,7 @@ let has_changed = false; let queue_index: number | null = null; let initial_queue_index: number | null = null; + let just_flagged: boolean = false; const default_inputs: Array = input_components.map((component) => "default" in component ? component.default : null @@ -156,12 +158,20 @@ state = "START"; stopTimer(); }; - const flag = () => { + const flag = (flag_option: string | null) => { + let flag_data: Record = { + input_data: input_values, + output_data: output_values + }; + if (flag_option !== null) { + flag_data["flag_option"] = flag_option; + } + just_flagged = true; + setTimeout(() => { + just_flagged = false; + }, 500); fn("flag", { - data: { - input_data: input_values, - output_data: output_values - } + data: flag_data }); }; const interpret = () => { @@ -304,12 +314,36 @@ {/if} {#if allow_flagging !== "never"} - + {#if flagging_options} + + {:else} + + {/if} {/if} @@ -352,6 +386,9 @@ } animation: ld-breath 0.75s infinite linear; } + .flag-option { + @apply hover:bg-gray-100; + } .gradio-interface[theme="default"] { .component-set { @apply bg-gray-50 dark:bg-gray-700 dark:drop-shadow-xl shadow; @@ -371,6 +408,9 @@ .panel-button.submit { @apply bg-amber-500 hover:bg-amber-400 dark:bg-red-700 dark:hover:bg-red-600 text-white; } + .panel-button.just_flagged { + @apply bg-red-300 hover:bg-red-300; + } .examples { .examples-table-holder:not(.gallery) { @apply shadow; @@ -394,6 +434,4 @@ } } } - .gradio-interface[theme="huggingface"] { - }