mirror/gradio
2
0
Fork 0
mirror of https://github.com/gradio-app/gradio.git synced 2025-02-17 11:29:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

Update the selected indices in Dropdown when value changes programmatically (#6425)

Browse Source 
* dropdown fix'

* add changeset

* typo

---------

Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
This commit is contained in:
Abubakar Abid 2023-11-15 09:55:19 -08:00 committed by GitHub
parent f816136a03
commit b3ba17dd11
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 50 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.changeset/whole-eels-poke.md Normal file
View File

@ -0,0 +1,6 @@
---
"@gradio/dropdown": patch
"gradio": patch
---
fix:Update the selected indices in `Dropdown` when value changes programmatically

39
js/dropdown/dropdown.test.ts
View File

@ -326,4 +326,43 @@ describe("Dropdown", () => {
await item.blur();
expect(item.value).toBe("applepie");
});
test("setting a value should update the displayed value and selected indices", async () => {
const { getByLabelText, getAllByTestId, component } = await render(
Dropdown,
{
show_label: true,
loading_status,
value: "",
allow_custom_value: false,
label: "Dropdown",
choices: [
["apple", "apple"],
["zebra", "zebra"],
["pony", "pony"]
],
filterable: true,
interactive: true
}
);
const item: HTMLInputElement = getByLabelText(
"Dropdown"
) as HTMLInputElement;
expect(item.value).toBe("apple");
await item.focus();
let options = getAllByTestId("dropdown-option");
expect(options[0]).toHaveClass("selected");
await component.$set({ value: "zebra" });
expect(item.value).toBe("zebra");
options = getAllByTestId("dropdown-option");
expect(options[0]).toHaveClass("selected");
await component.$set({ value: undefined });
expect(item.value).toBe("");
options = getAllByTestId("dropdown-option");
expect(options[0]).not.toHaveClass("selected");
});
});

4
js/dropdown/shared/Dropdown.svelte
View File

@ -105,12 +105,16 @@
function set_input_text(): void {
if (value === undefined) {
input_text = "";
selected_index = null;
} else if (choices_values.includes(value as string)) {
input_text = choices_names[choices_values.indexOf(value as string)];
selected_index = choices_values.indexOf(value as string);
} else if (allow_custom_value) {
input_text = value as string;
selected_index = null;
} else {
input_text = "";
selected_index = null;
}
}

2
pnpm-lock.yaml
View File

@ -1,4 +1,4 @@
lockfileVersion: '6.0'
lockfileVersion: '6.1'
settings:
autoInstallPeers: true