From abad6383dffff72bd46704ee6f57f0ac761a3f2e Mon Sep 17 00:00:00 2001 From: Ron Au <5785323+ronvoluted@users.noreply.github.com> Date: Thu, 21 Apr 2022 19:07:43 +1000 Subject: [PATCH] Update text (#1050) * docs(CONTRIBUTING): Update with new details * docs(ui): Update with correct details * fix(Error): Fix minor typo * docs: Link to `ui` readme from contributing guide * Update CONTRIBUTING.md Co-authored-by: pngwn --- CONTRIBUTING.md | 8 ++++---- ui/README.md | 4 ++-- ui/packages/app/src/main.ts | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c05c38aa3f..e8539a56d5 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -7,7 +7,7 @@ Prequisites: More than 30 awesome developers have contributed to the `gradio` library, and we'd be thrilled if you would like be the next `gradio` contributor! You can start by forking or cloning the repo (https://github.com/gradio-app/gradio.git) and creating your own branch to work from. -### Install Gradio locally from the `master` branch +### Install Gradio locally from the `main` branch * Clone this repo * Navigate to the repo folder and run @@ -51,7 +51,7 @@ It's helpful to know the overall structure of the repository so that you can foc * `/gradio`: contains the Python source code for the library * `/gradio/interface.py`: contains the Python source code for the core `Interface` class (**start HERE!**) -* `/frontend`: contains the HTML/JS/CSS source code for the library +* `/ui`: contains the HTML/JS/CSS source code for the library ([start here for frontend changes](/ui/README.md)) * `/test`: contains Python unit tests for the library * `/demo`: contains demos that are used in the documentation as well as for integration tests * `/website`: contains the code for the Gradio website (www.gradio.app). See the README in the `/website` folder for more details @@ -62,10 +62,10 @@ All PRs must pass the continuous integration tests before merging. To test local ## Submitting PRs -All PRs should be against `master`. Direct commits to master are blocked, and PRs require an approving review to merge into master. By convention, the Gradio maintainers will review PRs when: +All PRs should be against `main`. Direct commits to main are blocked, and PRs require an approving review to merge into main. By convention, the Gradio maintainers will review PRs when: * An initial review has been requested, and -* A maintainer (@abidlabs, @aliabid94, @aliabd, @AK391, or @dawoodkhan82) is tagged in the PR comments and asked to complete a review +* A maintainer (@abidlabs, @aliabid94, @aliabd, @AK391, @dawoodkhan82, or @pngwn) is tagged in the PR comments and asked to complete a review We ask that you make sure initial CI checks are passing before requesting a review. One of the Gradio maintainers will merge the PR when all the checks are passing. diff --git a/ui/README.md b/ui/README.md index c49e3d20c3..924da0edfb 100644 --- a/ui/README.md +++ b/ui/README.md @@ -31,7 +31,7 @@ This will install the dependencies for all packages within the `ui` folder and l ## local development -To develop locally, open two browser tabs from the root of the repository. +To develop locally, open two terminal tabs from the root of the repository. Run the python test server, from the root directory: @@ -40,7 +40,7 @@ cd demo/kitchen_sink python run.py ``` -This will start a development server on port `7863` that the web app is expecting. +This will start a development server on port `7860` that the web app is expecting. Run the web app: diff --git a/ui/packages/app/src/main.ts b/ui/packages/app/src/main.ts index d381804db0..6d4521e9fb 100644 --- a/ui/packages/app/src/main.ts +++ b/ui/packages/app/src/main.ts @@ -62,7 +62,7 @@ window.launchGradio = (config: Config, element_query: string) => { if (!target) { throw new Error( - "The target element could not be found. Please ensure atht element exists." + "The target element could not be found. Please ensure that element exists." ); }