mirror/gradio
2
0
Fork 0
mirror of https://github.com/gradio-app/gradio.git synced 2025-03-31 12:20:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix then logic to work after failures (#4115)

Browse Source 
* change

* changes

* changes

---------

Co-authored-by: Abubakar Abid <abubakar@huggingface.co>
This commit is contained in:
aliabid94 2023-05-08 22:16:54 -05:00 committed by GitHub
parent fab7642414
commit a3a34697ad
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -14,6 +14,7 @@
- Soft theme label color fix by [@aliabid94](https://github.com/aliabid94) in [PR 4070](https://github.com/gradio-app/gradio/pull/4070)
- Fix `gr.Slider` `release` event not triggering on mobile by [@space-nuko](https://github.com/space-nuko) in [PR 4098](https://github.com/gradio-app/gradio/pull/4098)
- Removes extraneous `State` component info from the `/info` route by [@abidlabs](https://github.com/freddyaboulton) in [PR 4107](https://github.com/gradio-app/gradio/pull/4107)
- Make .then() work even if first event fails by [@aliabid94](https://github.com/aliabid94) in [PR 4115](https://github.com/gradio-app/gradio/pull/4115).
## Documentation Changes:

16
js/app/src/Blocks.svelte
View File

@ -235,12 +235,10 @@
app.on("data", ({ data, fn_index }) => {
handle_update(data, fn_index);
let status = loading_status.get_status_for_fn(fn_index);
if (status === "complete" || status === "error") {
if (status === "complete") {
// handle .success and successful .then here, after data has updated
dependencies.forEach((dep, i) => {
if (
dep.trigger_after === fn_index &&
(!dep.trigger_only_on_success || status === "complete")
) {
if (dep.trigger_after === fn_index) {
trigger_api_call(i, null);
}
});
@ -249,6 +247,14 @@
app.on("status", ({ fn_index, ...status }) => {
loading_status.update({ ...status, fn_index });
if (status.status === "error") {
// handle failed .then here, since "data" listener won't trigger
dependencies.forEach((dep, i) => {
if (dep.trigger_after === fn_index && !dep.trigger_only_on_success) {
trigger_api_call(i, null);
}
});
}
});
function set_prop<T extends ComponentMeta>(obj: T, prop: string, val: any) {