mirror/gradio
2
0
Fork 0
mirror of https://github.com/gradio-app/gradio.git synced 2025-01-24 10:54:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

JS functions break entire app if there's no input, fixed (#7865)

Browse Source 
* changes

* add changeset

* add changeset

* changes

* changes

* changes

---------

Co-authored-by: Ali Abid <aliabid94@gmail.com>
Co-authored-by: gradio-pr-bot <gradio-pr-bot@users.noreply.github.com>
This commit is contained in:
aliabid94 2024-03-28 14:54:46 -07:00 committed by GitHub
parent e6d051dc8a
commit 7bbc3b62bf
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 34 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.changeset/pretty-ghosts-cry.md Normal file
View File

@ -0,0 +1,6 @@
---
"@gradio/app": patch
"gradio": patch
---
fix:JS functions break entire app if there's no input, fixed

2
demo/theme_builder/run.ipynb
View File

@ -1 +1 @@
{"cells": [{"cell_type": "markdown", "id": "302934307671667531413257853548643485645", "metadata": {}, "source": ["# Gradio Demo: theme_builder"]}, {"cell_type": "code", "execution_count": null, "id": "272996653310673477252411125948039410165", "metadata": {}, "outputs": [], "source": ["!pip install -q gradio "]}, {"cell_type": "code", "execution_count": null, "id": "288918539441861185822528903084949547379", "metadata": {}, "outputs": [], "source": ["import gradio as gr\n", "\n", "demo = gr.themes.builder\n", "\n", "if __name__ == \"__main__\":\n", " demo()"]}], "metadata": {}, "nbformat": 4, "nbformat_minor": 5}
{"cells": [{"cell_type": "markdown", "id": "302934307671667531413257853548643485645", "metadata": {}, "source": ["# Gradio Demo: theme_builder"]}, {"cell_type": "code", "execution_count": null, "id": "272996653310673477252411125948039410165", "metadata": {}, "outputs": [], "source": ["!pip install -q gradio "]}, {"cell_type": "code", "execution_count": null, "id": "288918539441861185822528903084949547379", "metadata": {}, "outputs": [], "source": ["from gradio.themes.builder_app import demo\n", "\n", "if __name__ == \"__main__\":\n", " demo.launch()"]}], "metadata": {}, "nbformat": 4, "nbformat_minor": 5}

6
demo/theme_builder/run.py
View File

@ -1,6 +1,4 @@
import gradio as gr
demo = gr.themes.builder
from gradio.themes.builder_app import demo
if __name__ == "__main__":
demo()
demo.launch()

1
gradio/themes/builder_app.py
View File

@ -97,6 +97,7 @@ with gr.Blocks( # noqa: SIM117
[theme.__name__ for theme in themes],
value="Base",
show_label=False,
label="Theme",
)
load_theme_btn = gr.Button("Load Theme", elem_id="load_theme")
with gr.TabItem("Core Colors"):

3
js/app/src/init.ts
View File

@ -196,7 +196,8 @@ export function create_components(): {
update_scheduled_store.set(false);
}
function update_value(updates: UpdateTransaction[]): void {
function update_value(updates: UpdateTransaction[] | undefined): void {
if (!updates) return;
pending_updates.push(updates);
if (!update_scheduled) {

22
js/app/test/theme_builder.spec.ts Normal file
View File

@ -0,0 +1,22 @@
import { test, expect } from "@gradio/tootils";
test("test theme builder changes are applied", async ({ page }) => {
await page.getByLabel("Theme", { exact: true }).click();
await page.getByLabel("Soft", { exact: true }).click();
await page.getByRole("button", { name: "Load Theme" }).click();
await page.getByRole("tab", { name: "Core Colors" }).click();
await page.getByLabel("Primary Hue").click();
await page.getByLabel("emerald").click();
const go_btn = page.getByRole("button", { name: "Go", exact: true });
await expect(go_btn).toHaveCSS(
"font-family",
'Montserrat, ui-sans-serif, "system-ui", sans-serif'
);
await expect(go_btn).toHaveCSS("background-color", "rgb(16, 185, 129)");
await page.getByRole("button", { name: "View Code ▼" }).click();
const code = page.getByLabel("Code input container");
await expect(code).toContainText("gr.themes.Soft");
await expect(code).toContainText('primary_hue="emerald"');
});