mirror/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2024-11-27 09:16:35 +08:00
Code Issues Packages Projects Releases Wiki Activity
fd6453c45e
godot/tests
History
Rémi Verschelde fd6453c45e Revert "Remove NOTIFICATION_ENTER_TREE when paired with NOTIFICATION_THEME_CHANGED" 
This reverts commit 4b817a565c.

Fixes #64988.
Fixes #64997.

This caused several regressions (#64988, #64997,
https://github.com/godotengine/godot/issues/64997#issuecomment-1229970605)
which point at a flaw in the current logic:

- `Control::NOTIFICATION_ENTER_TREE` triggers a *deferred* notification with
  `NOTIFCATION_THEME_CHANGED` as introduced in #62845.
- Some classes use their `THEME_CHANGED` to cache theme items in
  member variables (e.g. `style_normal`, etc.), and use those member
  variables in `ENTER_TREE`, `READY`, `DRAW`, etc. Since the `THEME_CHANGE`
  notification is now deferred, they end up accessing invalid state and this
  can lead to not applying theme properly (e.g. for EditorHelp) or crashing
  (e.g. for EditorLog or CodeEdit).

So we need to go back to the drawing board and see if `THEME_CHANGED` can be
called earlier so that the previous logic still works?

Or can we refactor all engine code to make sure that:
- `ENTER_TREE` and similar do not depend on theme properties cached in member
  variables.
- Or `THEME_CHANGE` does trigger a general UI update to make sure that any
  bad theme handling in `ENTER_TREE` and co. gets fixed when `THEME_CHANGE`
  does arrive for the first time. But that means having a temporary invalid
  (and possibly still crashing) state, and doing some computations twice
  which might be heavy (e.g. `EditorHelp::_update_doc()`).
2022-08-29 11:11:29 +02:00
..
core Rename str2var to str_to_var and similar 2022-08-26 14:58:22 +02:00
data File: Re-add support to skip CR (\r) in File::get_as_text 2022-08-01 00:40:35 +02:00
python_build ci: add basic test pipeline for shader builders 2022-08-19 20:32:13 +09:00
scene Revert "Remove NOTIFICATION_ENTER_TREE when paired with NOTIFICATION_THEME_CHANGED" 2022-08-29 11:11:29 +02:00
servers [Text Server] Prevent composite glyphs which incorporate kashida from being used for justification. Update TextServer tests to clean up on fail. 2022-08-05 19:35:38 +03:00
create_test.py Add a Python script to create new test suites more quickly 2022-08-20 14:41:05 +02:00
SCsub Remove unused legacy tests 2022-04-07 00:38:44 +02:00
test_macros.cpp Replace most uses of Map by HashMap 2022-05-16 10:37:48 +02:00
test_macros.h Merge pull request #61315 from lawnjelly/variant_bucket_pools 2022-08-02 15:54:18 +02:00
test_main.cpp Vector4/Vector4i: Add missing methods, tests and fix change of sign operator 2022-08-07 12:25:05 +02:00
test_main.h Update copyright statements to 2022 2022-01-03 21:27:34 +01:00
test_tools.h Update copyright statements to 2022 2022-01-03 21:27:34 +01:00
test_utils.cpp Update copyright statements to 2022 2022-01-03 21:27:34 +01:00
test_utils.h Update copyright statements to 2022 2022-01-03 21:27:34 +01:00
test_validate_testing.h Variant memory pools 2022-07-04 12:01:46 +01:00