mirror/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-01-12 20:22:49 +08:00
Code Issues Packages Projects Releases Wiki Activity
e6deba8d19
godot/core
History
Crazy-P e6deba8d19 Fixes logically dead code (Coverity) 
Fixes reported logically dead codes by Coverity

* image.cpp: Doesn't really need any modification. But to remove the bug
report then we have to move the MAX call away from the for loop
statement.

* rasterizer_gles3.cpp: Removes unnecessary elif condition since it is
checked earlier in the function

* collada.cpp: If stamement never reached due to macro ERR_CONTINUE does
the same.

* navigation_mesh.cpp: Variables should always be null - however, also
checked for the very same condition in their function call. Leaving this
for review (whether the function call is necessary or not)

* path_editor_plugin.cpp: If cancel is true, then it should restore the
edited value to the original provided.
http://docs.godotengine.org/en/3.0/classes/class_editorspatialgizmo.html#class-editorspatialgizmo-commit-handle

* spatial_editor_gizmos.cpp: the very condition of i >= 3 is
predetermined in the if case right before it. Thus case 1 is always '1'
and case 2 is always '-1'

* grid_map_editor.cpp: Same as above in spatial_editor_gizmos.cpp

* voxel_light_baker.cpp: Same as above in spatial_editor_gizmos.cpp

* visual_server.cpp: Same as above in spatial_editor_gizmos.cpp

* visual_script_expression.cpp: char '-' is already true in the switch
case mechanism. Thus it can never reach to default case.

* particles.cpp: Case 'PARAM_MAX' is unreachable due to index checking
right before the switch execution.

* shader_language.cpp: Invalid index is handled in switch default case.
`type < TYPE_FLOAT && type > TYPE_VEC4` -> `(type < TYPE_FLOAT || type > TYPE_VEC4`)
Fixes the "always false problem" in TODO comment.
2018-04-21 22:35:23 +08:00
..
bind Merge pull request #18227 from bojidar-bg/fix-date-unix-crash 2018-04-18 13:30:04 +02:00
helper Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
io Revert "Unify http- and percent- encode/decode" 2018-04-12 21:12:34 +02:00
math Avoid converting Quat to Euler angles when not necessary. 2018-04-14 15:53:25 -04:00
os Fixes left/up axis not mappable as actions 2018-04-18 21:38:52 +02:00
allocators.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
array.cpp Duplicate Arrays and Dictionaries when instancing scene in editor 2018-03-13 17:18:08 +02:00
array.h Duplicate Arrays and Dictionaries when instancing scene in editor 2018-03-13 17:18:08 +02:00
class_db.cpp Ctrl+Clicking a enum now scrolls down to it in the docs. 2018-04-03 21:56:54 +02:00
class_db.h Ctrl+Clicking a enum now scrolls down to it in the docs. 2018-04-03 21:56:54 +02:00
color_names.inc
color.cpp Fix mismatch between Color.h and Color.from_hsv() 2018-03-14 21:04:02 +01:00
color.h Add Color.from_hsv() 2018-01-18 22:13:00 +01:00
command_queue_mt.cpp Fix several in-class initialization clang warning 2018-03-22 00:17:18 -03:00
command_queue_mt.h Fix several in-class initialization clang warning 2018-03-22 00:17:18 -03:00
compressed_translation.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
compressed_translation.h Fix typos with codespell 2018-02-21 19:46:06 +01:00
core_string_names.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
core_string_names.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
dictionary.cpp Duplicate Arrays and Dictionaries when instancing scene in editor 2018-03-13 17:18:08 +02:00
dictionary.h Duplicate Arrays and Dictionaries when instancing scene in editor 2018-03-13 17:18:08 +02:00
dvector.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
dvector.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
engine.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
engine.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
error_list.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
error_macros.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
error_macros.h Add a macro to deprecate methods 2018-04-18 14:27:26 +02:00
func_ref.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
func_ref.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
global_constants.cpp Fix typos with codespell 2018-02-21 19:46:06 +01:00
global_constants.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
hash_map.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
hashfuncs.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
image.cpp Fixes logically dead code (Coverity) 2018-04-21 22:35:23 +08:00
image.h change to clang format 2018-02-24 13:59:02 +13:00
input_map.cpp Allow actions to provide an analog value 2018-04-16 23:20:43 +02:00
input_map.h Allow actions to provide an analog value 2018-04-16 23:20:43 +02:00
int_types.h Update copyright statements to 2018 2018-01-01 14:40:47 +01:00
list.h Fix typos in code and docs with codespell 2018-01-18 22:01:42 +01:00
make_binders.py Properly closing all files in Python code 2018-03-11 14:55:50 +01:00
map.h Fix typos with codespell 2018-02-21 19:46:06 +01:00
message_queue.cpp Fix typos with codespell 2018-02-21 19:46:06 +01:00
message_queue.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
method_bind.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
method_bind.h Fix typos in code and docs with codespell 2018-01-18 22:01:42 +01:00
method_ptrcall.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
node_path.cpp Fixes logically dead code (Coverity) 2018-04-21 22:35:23 +08:00
node_path.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
oa_hash_map.h Fix typos in code and docs with codespell 2018-01-18 22:01:42 +01:00
object.cpp Bind many more properties to scripts 2018-01-12 00:58:14 +02:00
object.h Make sure PropertyHint matches in the VisualScript editor. 2018-01-15 22:19:54 +01:00
ordered_hash_map.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
packed_data_container.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
packed_data_container.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
pair.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
path_remap.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
path_remap.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
pool_allocator.cpp Fix typos with codespell 2018-02-21 19:46:06 +01:00
pool_allocator.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
print_string.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
print_string.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
project_settings.cpp Allow actions to provide an analog value 2018-04-16 23:20:43 +02:00
project_settings.h Allow actions to provide an analog value 2018-04-16 23:20:43 +02:00
ref_ptr.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
ref_ptr.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
reference.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
reference.h Fix several in-class initialization clang warning 2018-03-22 00:17:18 -03:00
register_core_types.cpp Add new MultiplayerAPI class 2018-03-03 18:28:49 +01:00
register_core_types.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
resource.cpp Duplicate Arrays and Dictionaries when instancing scene in editor 2018-03-13 17:18:08 +02:00
resource.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
rid.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
rid.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
ring_buffer.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
safe_refcount.cpp Fix inconsistencies and typos in argument names 2018-02-01 16:47:20 +01:00
safe_refcount.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
script_debugger_local.cpp Kill an old debugging message 2018-02-05 11:18:49 +01:00
script_debugger_local.h Mono: Implement stack info for errors and exceptions 2018-01-09 17:19:03 +01:00
script_debugger_remote.cpp Fix typos with codespell 2018-02-21 19:46:06 +01:00
script_debugger_remote.h Mono: Implement stack info for errors and exceptions 2018-01-09 17:19:03 +01:00
script_language.cpp Bind many more properties to scripts 2018-01-12 00:58:14 +02:00
script_language.h Ctrl+Clicking a enum now scrolls down to it in the docs. 2018-04-03 21:56:54 +02:00
SCsub Merge pull request #17440 from viktor-ferenczi/issue-5042 2018-03-13 11:49:58 +01:00
self_list.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
set.h Fix typos with codespell 2018-02-21 19:46:06 +01:00
simple_type.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
sort.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
string_buffer.h Fix several in-class initialization clang warning 2018-03-22 00:17:18 -03:00
string_builder.cpp fixed crash with StringBuilder 2018-01-20 15:26:58 +01:00
string_builder.h Fix several in-class initialization clang warning 2018-03-22 00:17:18 -03:00
string_db.cpp Fix some Coverity warnings in String API 2018-04-18 22:20:39 +02:00
string_db.h Fix some Coverity warnings in String API 2018-04-18 22:20:39 +02:00
translation.cpp Add locale renames for Hebrew and Indonesian on Windows 2018-02-14 18:49:27 +01:00
translation.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
type_info.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
typedefs.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
ucaps.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
undo_redo.cpp obsolete UndoRedo max_steps; no users identified 2018-01-08 10:57:07 -06:00
undo_redo.h obsolete UndoRedo max_steps; no users identified 2018-01-08 10:57:07 -06:00
ustring.cpp Fix some Coverity warnings in String API 2018-04-18 22:20:39 +02:00
ustring.h Revert "Unify http- and percent- encode/decode" 2018-04-12 21:12:34 +02:00
variant_call.cpp Duplicate Arrays and Dictionaries when instancing scene in editor 2018-03-13 17:18:08 +02:00
variant_construct_string.cpp Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
variant_op.cpp Fix names of Variant operators 2018-04-16 14:54:49 -03:00
variant_parser.cpp add template argument for size in StringBuffer 2018-01-20 20:03:17 +01:00
variant_parser.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
variant.cpp Add base support for 2D meshes in Godot, including Sprite -> Mesh2D conversion. 2018-02-21 09:39:09 -03:00
variant.h Duplicate Arrays and Dictionaries when instancing scene in editor 2018-03-13 17:18:08 +02:00
vector.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
version.h Refactor version macros and fix related bugs 2018-02-23 20:15:29 +01:00
vmap.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00
vset.h Add missing copyright headers and fix formatting 2018-01-05 01:22:23 +01:00