mirror of
https://github.com/godotengine/godot.git
synced 2024-12-27 11:24:59 +08:00
fd6453c45e
This reverts commit 4b817a565c.
Fixes #64988.
Fixes #64997.
This caused several regressions (#64988, #64997,
https://github.com/godotengine/godot/issues/64997#issuecomment-1229970605)
which point at a flaw in the current logic:
- `Control::NOTIFICATION_ENTER_TREE` triggers a *deferred* notification with
`NOTIFCATION_THEME_CHANGED` as introduced in #62845.
- Some classes use their `THEME_CHANGED` to cache theme items in
member variables (e.g. `style_normal`, etc.), and use those member
variables in `ENTER_TREE`, `READY`, `DRAW`, etc. Since the `THEME_CHANGE`
notification is now deferred, they end up accessing invalid state and this
can lead to not applying theme properly (e.g. for EditorHelp) or crashing
(e.g. for EditorLog or CodeEdit).
So we need to go back to the drawing board and see if `THEME_CHANGED` can be
called earlier so that the previous logic still works?
Or can we refactor all engine code to make sure that:
- `ENTER_TREE` and similar do not depend on theme properties cached in member
variables.
- Or `THEME_CHANGE` does trigger a general UI update to make sure that any
bad theme handling in `ENTER_TREE` and co. gets fixed when `THEME_CHANGE`
does arrive for the first time. But that means having a temporary invalid
(and possibly still crashing) state, and doing some computations twice
which might be heavy (e.g. `EditorHelp::_update_doc()`).
112 lines
5.1 KiB
C++
112 lines
5.1 KiB
C++
/*************************************************************************/
|
|
/* openxr_action_editor.cpp */
|
|
/*************************************************************************/
|
|
/* This file is part of: */
|
|
/* GODOT ENGINE */
|
|
/* https://godotengine.org */
|
|
/*************************************************************************/
|
|
/* Copyright (c) 2007-2022 Juan Linietsky, Ariel Manzur. */
|
|
/* Copyright (c) 2014-2022 Godot Engine contributors (cf. AUTHORS.md). */
|
|
/* */
|
|
/* Permission is hereby granted, free of charge, to any person obtaining */
|
|
/* a copy of this software and associated documentation files (the */
|
|
/* "Software"), to deal in the Software without restriction, including */
|
|
/* without limitation the rights to use, copy, modify, merge, publish, */
|
|
/* distribute, sublicense, and/or sell copies of the Software, and to */
|
|
/* permit persons to whom the Software is furnished to do so, subject to */
|
|
/* the following conditions: */
|
|
/* */
|
|
/* The above copyright notice and this permission notice shall be */
|
|
/* included in all copies or substantial portions of the Software. */
|
|
/* */
|
|
/* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, */
|
|
/* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF */
|
|
/* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.*/
|
|
/* IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY */
|
|
/* CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, */
|
|
/* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE */
|
|
/* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
|
|
/*************************************************************************/
|
|
|
|
#include "openxr_action_editor.h"
|
|
|
|
void OpenXRActionEditor::_bind_methods() {
|
|
ADD_SIGNAL(MethodInfo("remove", PropertyInfo(Variant::OBJECT, "action_editor")));
|
|
}
|
|
|
|
void OpenXRActionEditor::_theme_changed() {
|
|
rem_action->set_icon(get_theme_icon(SNAME("Remove"), SNAME("EditorIcons")));
|
|
}
|
|
|
|
void OpenXRActionEditor::_notification(int p_what) {
|
|
switch (p_what) {
|
|
case NOTIFICATION_ENTER_TREE:
|
|
case NOTIFICATION_THEME_CHANGED: {
|
|
_theme_changed();
|
|
} break;
|
|
}
|
|
}
|
|
|
|
void OpenXRActionEditor::_on_action_name_changed(const String p_new_text) {
|
|
// TODO validate if entry is allowed
|
|
|
|
// If our localized name matches our action name, set this too
|
|
if (action->get_name() == action->get_localized_name()) {
|
|
action->set_localized_name(p_new_text);
|
|
action_localized_name->set_text(p_new_text);
|
|
}
|
|
action->set_name(p_new_text);
|
|
}
|
|
|
|
void OpenXRActionEditor::_on_action_localized_name_changed(const String p_new_text) {
|
|
action->set_localized_name(p_new_text);
|
|
}
|
|
|
|
void OpenXRActionEditor::_on_item_selected(int p_idx) {
|
|
ERR_FAIL_INDEX(p_idx, OpenXRAction::OPENXR_ACTION_MAX);
|
|
|
|
action->set_action_type(OpenXRAction::ActionType(p_idx));
|
|
}
|
|
|
|
void OpenXRActionEditor::_on_remove_action() {
|
|
emit_signal("remove", this);
|
|
}
|
|
|
|
OpenXRActionEditor::OpenXRActionEditor(Ref<OpenXRAction> p_action) {
|
|
action = p_action;
|
|
|
|
set_h_size_flags(Control::SIZE_EXPAND_FILL);
|
|
|
|
action_name = memnew(LineEdit);
|
|
action_name->set_text(action->get_name());
|
|
action_name->set_custom_minimum_size(Size2(150.0, 0.0));
|
|
action_name->connect("text_changed", callable_mp(this, &OpenXRActionEditor::_on_action_name_changed));
|
|
add_child(action_name);
|
|
|
|
action_localized_name = memnew(LineEdit);
|
|
action_localized_name->set_text(action->get_localized_name());
|
|
action_localized_name->set_custom_minimum_size(Size2(150.0, 0.0));
|
|
action_localized_name->set_h_size_flags(Control::SIZE_EXPAND_FILL);
|
|
action_localized_name->connect("text_changed", callable_mp(this, &OpenXRActionEditor::_on_action_localized_name_changed));
|
|
add_child(action_localized_name);
|
|
|
|
action_type = memnew(OptionButton);
|
|
action_type->add_item("Bool", OpenXRAction::OPENXR_ACTION_BOOL);
|
|
action_type->add_item("Float", OpenXRAction::OPENXR_ACTION_FLOAT);
|
|
action_type->add_item("Vector2", OpenXRAction::OPENXR_ACTION_VECTOR2);
|
|
action_type->add_item("Pose", OpenXRAction::OPENXR_ACTION_POSE);
|
|
action_type->add_item("Haptic", OpenXRAction::OPENXR_ACTION_HAPTIC);
|
|
action_type->select(int(action->get_action_type()));
|
|
action_type->set_custom_minimum_size(Size2(100.0, 0.0));
|
|
action_type->connect("item_selected", callable_mp(this, &OpenXRActionEditor::_on_item_selected));
|
|
add_child(action_type);
|
|
|
|
// maybe add dropdown to edit our toplevel paths, or do we deduce them from our suggested bindings?
|
|
|
|
rem_action = memnew(Button);
|
|
rem_action->set_tooltip_text(TTR("Remove action"));
|
|
rem_action->connect("pressed", callable_mp(this, &OpenXRActionEditor::_on_remove_action));
|
|
rem_action->set_flat(true);
|
|
add_child(rem_action);
|
|
}
|