mirror of
https://github.com/godotengine/godot.git
synced 2024-12-09 10:09:20 +08:00
cacced7e50
Currently we rely on some undefined behavior when Object->cast_to() gets called with a Null pointer. This used to work fine with GCC < 6 but newer versions of GCC remove all codepaths in which the this pointer is Null. However, the non-static cast_to() was supposed to be null safe. This patch makes cast_to() Null safe and removes the now redundant Null checks where they existed. It is explained in this article: https://www.viva64.com/en/b/0226/
81 lines
3.1 KiB
C++
81 lines
3.1 KiB
C++
/*************************************************************************/
|
|
/* gi_probe_editor_plugin.h */
|
|
/*************************************************************************/
|
|
/* This file is part of: */
|
|
/* GODOT ENGINE */
|
|
/* http://www.godotengine.org */
|
|
/*************************************************************************/
|
|
/* Copyright (c) 2007-2017 Juan Linietsky, Ariel Manzur. */
|
|
/* Copyright (c) 2014-2017 Godot Engine contributors (cf. AUTHORS.md) */
|
|
/* */
|
|
/* Permission is hereby granted, free of charge, to any person obtaining */
|
|
/* a copy of this software and associated documentation files (the */
|
|
/* "Software"), to deal in the Software without restriction, including */
|
|
/* without limitation the rights to use, copy, modify, merge, publish, */
|
|
/* distribute, sublicense, and/or sell copies of the Software, and to */
|
|
/* permit persons to whom the Software is furnished to do so, subject to */
|
|
/* the following conditions: */
|
|
/* */
|
|
/* The above copyright notice and this permission notice shall be */
|
|
/* included in all copies or substantial portions of the Software. */
|
|
/* */
|
|
/* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, */
|
|
/* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF */
|
|
/* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.*/
|
|
/* IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY */
|
|
/* CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, */
|
|
/* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE */
|
|
/* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
|
|
/*************************************************************************/
|
|
#include "gi_probe_editor_plugin.h"
|
|
|
|
void GIProbeEditorPlugin::_bake() {
|
|
|
|
if (gi_probe) {
|
|
gi_probe->bake();
|
|
}
|
|
}
|
|
|
|
void GIProbeEditorPlugin::edit(Object *p_object) {
|
|
|
|
GIProbe *s = Object::cast_to<GIProbe>(p_object);
|
|
if (!s)
|
|
return;
|
|
|
|
gi_probe = s;
|
|
}
|
|
|
|
bool GIProbeEditorPlugin::handles(Object *p_object) const {
|
|
|
|
return p_object->is_class("GIProbe");
|
|
}
|
|
|
|
void GIProbeEditorPlugin::make_visible(bool p_visible) {
|
|
|
|
if (p_visible) {
|
|
bake->show();
|
|
} else {
|
|
|
|
bake->hide();
|
|
}
|
|
}
|
|
|
|
void GIProbeEditorPlugin::_bind_methods() {
|
|
|
|
ClassDB::bind_method("_bake", &GIProbeEditorPlugin::_bake);
|
|
}
|
|
|
|
GIProbeEditorPlugin::GIProbeEditorPlugin(EditorNode *p_node) {
|
|
|
|
editor = p_node;
|
|
bake = memnew(Button);
|
|
bake->set_icon(editor->get_gui_base()->get_icon("BakedLight", "EditorIcons"));
|
|
bake->hide();
|
|
bake->connect("pressed", this, "_bake");
|
|
add_control_to_container(CONTAINER_SPATIAL_EDITOR_MENU, bake);
|
|
gi_probe = NULL;
|
|
}
|
|
|
|
GIProbeEditorPlugin::~GIProbeEditorPlugin() {
|
|
}
|