mirror of
https://github.com/godotengine/godot.git
synced 2024-11-27 09:16:35 +08:00
2d98b40d47
When a Vector of Vectors gets resized the 'this' pointer of the Vectors change. This means that the VectorWriteProxy _parent references get invalidated. Thanks a lot to @ibrahn for finding the root cause of this. To fix this we now create a pointer to CowData in Vector (which won't change when the vectors move) and pass that to the write proxy also. This fixes #20475
184 lines
5.5 KiB
C++
184 lines
5.5 KiB
C++
/*************************************************************************/
|
|
/* vector.h */
|
|
/*************************************************************************/
|
|
/* This file is part of: */
|
|
/* GODOT ENGINE */
|
|
/* https://godotengine.org */
|
|
/*************************************************************************/
|
|
/* Copyright (c) 2007-2018 Juan Linietsky, Ariel Manzur. */
|
|
/* Copyright (c) 2014-2018 Godot Engine contributors (cf. AUTHORS.md) */
|
|
/* */
|
|
/* Permission is hereby granted, free of charge, to any person obtaining */
|
|
/* a copy of this software and associated documentation files (the */
|
|
/* "Software"), to deal in the Software without restriction, including */
|
|
/* without limitation the rights to use, copy, modify, merge, publish, */
|
|
/* distribute, sublicense, and/or sell copies of the Software, and to */
|
|
/* permit persons to whom the Software is furnished to do so, subject to */
|
|
/* the following conditions: */
|
|
/* */
|
|
/* The above copyright notice and this permission notice shall be */
|
|
/* included in all copies or substantial portions of the Software. */
|
|
/* */
|
|
/* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, */
|
|
/* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF */
|
|
/* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.*/
|
|
/* IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY */
|
|
/* CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, */
|
|
/* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE */
|
|
/* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
|
|
/*************************************************************************/
|
|
|
|
#ifndef VECTOR_H
|
|
#define VECTOR_H
|
|
|
|
/**
|
|
* @class Vector
|
|
* @author Juan Linietsky
|
|
* Vector container. Regular Vector Container. Use with care and for smaller arrays when possible. Use PoolVector for large arrays.
|
|
*/
|
|
#include "cowdata.h"
|
|
#include "error_macros.h"
|
|
#include "os/memory.h"
|
|
#include "sort.h"
|
|
|
|
template <class T>
|
|
class VectorWriteProxy {
|
|
friend class Vector<T>;
|
|
CowData<T> *_parent;
|
|
|
|
_FORCE_INLINE_ VectorWriteProxy(CowData<T> *parent) :
|
|
_parent(parent){};
|
|
|
|
public:
|
|
_FORCE_INLINE_ T &operator[](int p_index) {
|
|
CRASH_BAD_INDEX(p_index, _parent->size());
|
|
|
|
return _parent->ptrw()[p_index];
|
|
}
|
|
};
|
|
|
|
template <class T>
|
|
class Vector {
|
|
friend class VectorWriteProxy<T>;
|
|
|
|
CowData<T> *_cowdata;
|
|
|
|
public:
|
|
VectorWriteProxy<T> write;
|
|
|
|
bool push_back(const T &p_elem);
|
|
|
|
void remove(int p_index) { _cowdata->remove(p_index); }
|
|
void erase(const T &p_val) {
|
|
int idx = find(p_val);
|
|
if (idx >= 0) remove(idx);
|
|
};
|
|
void invert();
|
|
|
|
_FORCE_INLINE_ T *ptrw() { return _cowdata->ptrw(); }
|
|
_FORCE_INLINE_ const T *ptr() const { return _cowdata->ptr(); }
|
|
_FORCE_INLINE_ void clear() { resize(0); }
|
|
_FORCE_INLINE_ bool empty() const { return _cowdata->empty(); }
|
|
|
|
_FORCE_INLINE_ T get(int p_index) { return _cowdata->get(p_index); }
|
|
_FORCE_INLINE_ const T get(int p_index) const { return _cowdata->get(p_index); }
|
|
_FORCE_INLINE_ void set(int p_index, const T &p_elem) { _cowdata->set(p_index, p_elem); }
|
|
_FORCE_INLINE_ int size() const { return _cowdata->size(); }
|
|
Error resize(int p_size) { return _cowdata->resize(p_size); }
|
|
_FORCE_INLINE_ const T &operator[](int p_index) const { return _cowdata->get(p_index); }
|
|
Error insert(int p_pos, const T &p_val) { return _cowdata->insert(p_pos, p_val); }
|
|
|
|
void append_array(const Vector<T> &p_other);
|
|
|
|
template <class C>
|
|
void sort_custom() {
|
|
|
|
int len = _cowdata->size();
|
|
if (len == 0)
|
|
return;
|
|
|
|
T *data = ptrw();
|
|
SortArray<T, C> sorter;
|
|
sorter.sort(data, len);
|
|
}
|
|
|
|
void sort() {
|
|
|
|
sort_custom<_DefaultComparator<T> >();
|
|
}
|
|
|
|
void ordered_insert(const T &p_val) {
|
|
int i;
|
|
for (i = 0; i < _cowdata->size(); i++) {
|
|
|
|
if (p_val < operator[](i)) {
|
|
break;
|
|
};
|
|
};
|
|
insert(i, p_val);
|
|
}
|
|
|
|
int find(const T &p_val, int p_from = 0) const {
|
|
int ret = -1;
|
|
if (p_from < 0 || size() == 0)
|
|
return ret;
|
|
|
|
for (int i = p_from; i < size(); i++) {
|
|
|
|
if (ptr()[i] == p_val) {
|
|
ret = i;
|
|
break;
|
|
};
|
|
};
|
|
|
|
return ret;
|
|
}
|
|
|
|
_FORCE_INLINE_ Vector() :
|
|
_cowdata(new CowData<T>()),
|
|
write(VectorWriteProxy<T>(_cowdata)) {}
|
|
_FORCE_INLINE_ Vector(const Vector &p_from) :
|
|
_cowdata(new CowData<T>()),
|
|
write(VectorWriteProxy<T>(_cowdata)) { _cowdata->_ref(p_from._cowdata); }
|
|
inline Vector &operator=(const Vector &p_from) {
|
|
_cowdata->_ref(p_from._cowdata);
|
|
return *this;
|
|
}
|
|
|
|
_FORCE_INLINE_ ~Vector() {
|
|
delete _cowdata;
|
|
}
|
|
};
|
|
|
|
template <class T>
|
|
void Vector<T>::invert() {
|
|
|
|
for (int i = 0; i < size() / 2; i++) {
|
|
T *p = ptrw();
|
|
SWAP(p[i], p[size() - i - 1]);
|
|
}
|
|
}
|
|
|
|
template <class T>
|
|
void Vector<T>::append_array(const Vector<T> &p_other) {
|
|
const int ds = p_other.size();
|
|
if (ds == 0)
|
|
return;
|
|
const int bs = size();
|
|
resize(bs + ds);
|
|
for (int i = 0; i < ds; ++i)
|
|
ptrw()[bs + i] = p_other[i];
|
|
}
|
|
|
|
template <class T>
|
|
bool Vector<T>::push_back(const T &p_elem) {
|
|
|
|
Error err = resize(size() + 1);
|
|
ERR_FAIL_COND_V(err, true)
|
|
set(size() - 1, p_elem);
|
|
|
|
return false;
|
|
}
|
|
|
|
#endif
|