godot/editor
Rémi Verschelde 7da392bcc5
Don't return reference on copy assignment operators
We prefer to prevent using chained assignment (`T a = b = c = T();`) as this
can lead to confusing code and subtle bugs.

According to https://en.wikipedia.org/wiki/Assignment_operator_(C%2B%2B), C++
allows any arbitrary return type, so this is standard compliant.

This could be re-assessed if/when we have an actual need for a behavior more
akin to that of the C++ STL, for now this PR simply changes a handful of
cases which were inconsistent with the rest of the codebase (`void` return
type was already the most common case prior to this commit).
2021-11-30 16:26:29 +01:00
..
debugger Don't return reference on copy assignment operators 2021-11-30 16:26:29 +01:00
fileserver
icons Use a different icon for eased keyframes in the animation editor 2021-11-15 13:16:21 +01:00
import Merge pull request #55238 from Giwayume/bugfix/atlas_cutoff_edge_master 2021-11-24 08:01:47 +01:00
plugins Right-clicking with copied tiles cancels it 2021-11-30 00:23:44 +05:30
translations i18n: Sync editor translations with Weblate 2021-11-19 09:55:09 +01:00
action_map_editor.cpp Rename remove() to remove_at() when removing by index 2021-11-23 18:58:57 -07:00
action_map_editor.h
animation_bezier_editor.cpp Make bezier handle type a property of keyframes, update interface 2021-11-16 09:26:35 -05:00
animation_bezier_editor.h Make bezier handle type a property of keyframes, update interface 2021-11-16 09:26:35 -05:00
animation_track_editor_plugins.cpp Use "enum class" for input enums 2021-11-12 15:37:54 -06:00
animation_track_editor_plugins.h
animation_track_editor.cpp Make bezier handle type a property of keyframes, update interface 2021-11-16 09:26:35 -05:00
animation_track_editor.h reimplement ping-pong 2021-11-03 13:39:33 +09:00
array_property_edit.cpp
array_property_edit.h
audio_stream_preview.cpp
audio_stream_preview.h Don't return reference on copy assignment operators 2021-11-30 16:26:29 +01:00
code_editor.cpp Make delete_lines work correctly regardless of the selection 2021-11-26 08:28:58 +00:00
code_editor.h Remove unimplemented methods 2021-10-21 18:44:25 +01:00
connections_dialog.cpp Rename remove() to remove_at() when removing by index 2021-11-23 18:58:57 -07:00
connections_dialog.h
create_dialog.cpp Rename remove() to remove_at() when removing by index 2021-11-23 18:58:57 -07:00
create_dialog.h
dependency_editor.cpp Added reset_size method to Control and Window classes 2021-11-22 16:55:21 +03:00
dependency_editor.h
dictionary_property_edit.cpp
dictionary_property_edit.h
doc_tools.cpp Modules: Make sure to include modules_enabled.gen.h where needed 2021-11-12 13:42:58 +01:00
doc_tools.h
editor_about.cpp clang-format: Disable alignment of operands, too unreliable 2021-10-28 15:19:35 +02:00
editor_about.h
editor_asset_installer.cpp
editor_asset_installer.h
editor_atlas_packer.cpp
editor_atlas_packer.h
editor_audio_buses.cpp Use "enum class" for input enums 2021-11-12 15:37:54 -06:00
editor_audio_buses.h Don't return reference on copy assignment operators 2021-11-30 16:26:29 +01:00
editor_autoload_settings.cpp Improve various texts 2021-11-23 12:20:57 +01:00
editor_autoload_settings.h
editor_builders.py Use maximum zlib compression when generating editor translation headers 2021-10-29 19:07:48 +02:00
editor_command_palette.cpp Use "enum class" for input enums 2021-11-12 15:37:54 -06:00
editor_command_palette.h Use "enum class" for input enums 2021-11-12 15:37:54 -06:00
editor_data.cpp Rename remove() to remove_at() when removing by index 2021-11-23 18:58:57 -07:00
editor_data.h Remove unimplemented methods 2021-10-21 18:44:25 +01:00
editor_dir_dialog.cpp
editor_dir_dialog.h
editor_export.cpp Don't return reference on copy assignment operators 2021-11-30 16:26:29 +01:00
editor_export.h Add path to functions that return iporter options 2021-11-14 14:06:10 -03:00
editor_feature_profile.cpp
editor_feature_profile.h
editor_file_dialog.cpp Don't return reference on copy assignment operators 2021-11-30 16:26:29 +01:00
editor_file_dialog.h
editor_file_system.cpp Rename remove() to remove_at() when removing by index 2021-11-23 18:58:57 -07:00
editor_file_system.h
editor_folding.cpp
editor_folding.h
editor_fonts.cpp Ignore empty Font resources as theme override. 2021-10-25 14:05:37 +03:00
editor_fonts.h
editor_help_search.cpp Use "enum class" for input enums 2021-11-12 15:37:54 -06:00
editor_help_search.h Move the docs for constructors and operators out of methods section 2021-10-29 12:34:57 -05:00
editor_help.cpp Add [theme_item] tag to editor help 2021-11-18 15:32:23 +01:00
editor_help.h Move the docs for constructors and operators out of methods section 2021-10-29 12:34:57 -05:00
editor_inspector.cpp Rename remove() to remove_at() when removing by index 2021-11-23 18:58:57 -07:00
editor_inspector.h Fix EditorInspectorPlugin virtual bindings and add parse_group callback 2021-11-10 17:56:59 +03:00
editor_layouts_dialog.cpp Use "enum class" for input enums 2021-11-12 15:37:54 -06:00
editor_layouts_dialog.h
editor_log.cpp Use "enum class" for input enums 2021-11-12 15:37:54 -06:00
editor_log.h
editor_native_shader_source_visualizer.cpp
editor_native_shader_source_visualizer.h
editor_node.cpp Rename remove() to remove_at() when removing by index 2021-11-23 18:58:57 -07:00
editor_node.h Allow creating .gitignore and .gitattributes when creating a new project 2021-11-12 21:27:31 -06:00
editor_path.cpp
editor_path.h Remove unimplemented methods 2021-10-21 18:44:25 +01:00
editor_paths.cpp
editor_paths.h
editor_plugin_settings.cpp
editor_plugin_settings.h
editor_plugin.cpp Add scene Post-Import Plugin support. 2021-10-15 09:12:04 -03:00
editor_plugin.h Add scene Post-Import Plugin support. 2021-10-15 09:12:04 -03:00
editor_properties_array_dict.cpp Rename remove() to remove_at() when removing by index 2021-11-23 18:58:57 -07:00
editor_properties_array_dict.h
editor_properties.cpp Use "enum class" for input enums 2021-11-12 15:37:54 -06:00
editor_properties.h Fix EditorInspectorPlugin virtual bindings and add parse_group callback 2021-11-10 17:56:59 +03:00
editor_resource_picker.cpp Use "enum class" for input enums 2021-11-12 15:37:54 -06:00
editor_resource_picker.h Infer shader type based on edited node 2021-11-03 15:27:38 +01:00
editor_resource_preview.cpp Add GLES2 2D renderer + Linux display manager 2021-10-30 02:05:48 +02:00
editor_resource_preview.h Add GLES2 2D renderer + Linux display manager 2021-10-30 02:05:48 +02:00
editor_run_native.cpp
editor_run_native.h
editor_run_script.cpp
editor_run_script.h
editor_run.cpp Rename remove() to remove_at() when removing by index 2021-11-23 18:58:57 -07:00
editor_run.h
editor_scale.cpp
editor_scale.h
editor_sectioned_inspector.cpp
editor_sectioned_inspector.h
editor_settings.cpp Use "enum class" for input enums 2021-11-12 15:37:54 -06:00
editor_settings.h Use "enum class" for input enums 2021-11-12 15:37:54 -06:00
editor_spin_slider.cpp Added reset_size method to Control and Window classes 2021-11-22 16:55:21 +03:00
editor_spin_slider.h Make EditorSpinSlider wait for text on key_up/down 2021-10-26 18:00:16 -04:00
editor_themes.cpp Modules: Make sure to include modules_enabled.gen.h where needed 2021-11-12 13:42:58 +01:00
editor_themes.h
editor_toaster.cpp Fix incorrect encoding (Latin-1 instead of UTF-8) used in _error_handler functions. 2021-11-08 23:45:08 +02:00
editor_toaster.h
editor_translation_parser.cpp
editor_translation_parser.h
editor_vcs_interface.cpp Allow creating .gitignore and .gitattributes when creating a new project 2021-11-12 21:27:31 -06:00
editor_vcs_interface.h Allow creating .gitignore and .gitattributes when creating a new project 2021-11-12 21:27:31 -06:00
editor_zoom_widget.cpp Use "enum class" for input enums 2021-11-12 15:37:54 -06:00
editor_zoom_widget.h
export_template_manager.cpp
export_template_manager.h
filesystem_dock.cpp Rename remove() to remove_at() when removing by index 2021-11-23 18:58:57 -07:00
filesystem_dock.h Remove unimplemented methods 2021-10-21 18:44:25 +01:00
find_in_files.cpp Small formatting fixes in Find in Files 2021-10-27 16:13:49 +02:00
find_in_files.h
groups_editor.cpp Added ability to copy group name 2021-10-21 03:56:08 -04:00
groups_editor.h Remove unimplemented methods 2021-10-21 18:44:25 +01:00
import_defaults_editor.cpp Add path to functions that return iporter options 2021-11-14 14:06:10 -03:00
import_defaults_editor.h
import_dock.cpp Add path to functions that return iporter options 2021-11-14 14:06:10 -03:00
import_dock.h Add path to functions that return iporter options 2021-11-14 14:06:10 -03:00
inspector_dock.cpp Fixed animation insertion in SkeletonEditor 2021-10-23 16:50:00 +09:00
inspector_dock.h
localization_editor.cpp Rename remove() to remove_at() when removing by index 2021-11-23 18:58:57 -07:00
localization_editor.h
multi_node_edit.cpp
multi_node_edit.h
node_dock.cpp
node_dock.h
plugin_config_dialog.cpp Modules: Make sure to include modules_enabled.gen.h where needed 2021-11-12 13:42:58 +01:00
plugin_config_dialog.h Fix plugin create dialog subfolder and script field validity checks 2021-10-17 23:42:04 +02:00
pot_generator.cpp
pot_generator.h
progress_dialog.cpp
progress_dialog.h
project_export.cpp Improved some editor checkboxes 2021-11-21 21:29:34 +01:00
project_export.h
project_manager.cpp Move logic for saving project features to ProjectSettings save_custom 2021-11-25 03:08:05 -06:00
project_manager.h
project_settings_editor.cpp
project_settings_editor.h Remove unimplemented methods 2021-10-21 18:44:25 +01:00
property_editor.cpp Added reset_size method to Control and Window classes 2021-11-22 16:55:21 +03:00
property_editor.h Update usabilaty of the CustomPropertyEditor 2021-11-04 16:42:08 +01:00
property_selector.cpp Use "enum class" for input enums 2021-11-12 15:37:54 -06:00
property_selector.h
quick_open.cpp Use "enum class" for input enums 2021-11-12 15:37:54 -06:00
quick_open.h
register_exporters.h
rename_dialog.cpp Modules: Make sure to include modules_enabled.gen.h where needed 2021-11-12 13:42:58 +01:00
rename_dialog.h Modules: Make sure to include modules_enabled.gen.h where needed 2021-11-12 13:42:58 +01:00
reparent_dialog.cpp
reparent_dialog.h Remove unimplemented methods 2021-10-21 18:44:25 +01:00
scene_tree_dock.cpp Fix scene tree dock icon not switching colors on theme change 2021-11-29 19:42:06 +01:00
scene_tree_dock.h Modules: Make sure to include modules_enabled.gen.h where needed 2021-11-12 13:42:58 +01:00
scene_tree_editor.cpp
scene_tree_editor.h Remove unimplemented methods 2021-10-21 18:44:25 +01:00
script_create_dialog.cpp Allow to name built-in scripts upon creation 2021-11-04 02:34:35 +01:00
script_create_dialog.h Allow to name built-in scripts upon creation 2021-11-04 02:34:35 +01:00
SCsub i18n: Sync classref translations with Weblate 2021-11-03 15:06:09 +01:00
settings_config_dialog.cpp Rename remove() to remove_at() when removing by index 2021-11-23 18:58:57 -07:00
settings_config_dialog.h
shader_create_dialog.cpp Infer shader type based on edited node 2021-11-03 15:27:38 +01:00
shader_create_dialog.h Infer shader type based on edited node 2021-11-03 15:27:38 +01:00
shader_globals_editor.cpp
shader_globals_editor.h