Commit Graph

59236 Commits

Author SHA1 Message Date
Rémi Verschelde
a363269479
AnimationMixer: Validate ObjectID before blend in case the object was freed
Works around #85365, but it's likely only a partial fix.
The proper fix would be to remove the Object pointer from the TrackCache
and always go back to the ObjectID before doing operations like this.
2023-11-28 12:27:23 +01:00
Rémi Verschelde
f82bf35a03
Merge pull request #85457 from m4gr3d/fix_android_editor_restart_loop
Fix an issue causing the running project window to loop-restart when closed
2023-11-28 09:14:11 +01:00
Fredia Huya-Kouadio
7cd604132b Fix an issue causing the running project window to loop-restart when closed with the back button 2023-11-27 23:43:19 -08:00
Rémi Verschelde
a008a85443
Merge pull request #85411 from TokageItLab/fix-animpbtrack-stop
Make AnimationPlaybackTrack keep state when stopping
2023-11-28 08:28:25 +01:00
Rémi Verschelde
d6dd1de644
Merge pull request #85454 from m4gr3d/fix_android_freeze_on_close
Fix issue causing Godot Android apps / games to freeze on close
2023-11-28 08:22:14 +01:00
Fredia Huya-Kouadio
1e4af5269f Fix issue causing Godot Android apps / games to freeze on close
The issue occurred because during the 'close' event, the logic was trying to terminate the native engine on the UI thread instead of doing on the render thread.
2023-11-27 18:24:36 -08:00
Rémi Verschelde
eda44bfe10
Merge pull request #85252 from QbieShay/qbe/fix-radial-inwards-velocity
Fix radial inwards velocity clamping incorrectly (regression from #83488)
2023-11-27 21:25:58 +01:00
Rémi Verschelde
03c251e659
Merge pull request #85427 from bruvzg/ed_restore_mode
[Editor] Save and restore previous window mode when toggling full-screen.
2023-11-27 19:42:38 +01:00
Rémi Verschelde
b3a0e077eb
Merge pull request #85432 from RandomShaper/fix_gds_exit_crash_lower
Fix GDScript thread-exit routine assuming thread-enter was called
2023-11-27 16:01:55 +01:00
Rémi Verschelde
a807d4bfa7
Merge pull request #85418 from bruvzg/fix_crash_on_late_enterexit
Fix crash on late mouse enter/exit event arrival.
2023-11-27 16:01:30 +01:00
Rémi Verschelde
b20ecc91e4
Merge pull request #85366 from TokageItLab/more-stable-seek-discrete
Check the seeking if it is processed immediately after playback as a special case
2023-11-27 16:01:03 +01:00
Pedro J. Estébanez
cfa7e72057 Fix GDScript thread-exit routine assuming thread-enter was called 2023-11-27 13:01:37 +01:00
bruvzg
27ca31f359 [Editor] Save and restore previous window mode when toggling full-screen. 2023-11-27 12:44:30 +02:00
bruvzg
bf19ced15d
Fix crash on late mouse enter/exit event arrival. 2023-11-27 08:47:43 +02:00
Silc Lizard (Tokage) Renew
d3a429962f Make AnimationPlaybakTrack keep state when stopping 2023-11-27 12:14:25 +09:00
Alex Drozd
8f2b701892 Fix order of operations for macos template check 2023-11-26 23:26:32 +01:00
Alex Drozd
3f22c1bfb6 use venv if detected when building godot.sln 2023-11-26 23:25:13 +01:00
Rémi Verschelde
5df9867967
Merge pull request #85357 from mhilbrunner/fix-generate-vsproj
Fix generating vsproj with SCons 4.6.0+
2023-11-26 00:03:35 +01:00
Silc Lizard (Tokage) Renew
c36200b9a1 Check the seek process immediately after playback as a special case 2023-11-26 07:32:34 +09:00
bruvzg
7a59efac32
[RTL] Fix CharFX character offset calculation. 2023-11-26 00:07:46 +02:00
Max Hilbrunner
72110134d6 Fix generating vsproj with SCons 4.6.0+ 2023-11-25 21:27:18 +01:00
oeelis
834ccb9698 Fix issue with 3D scene drag and drop preview node 2023-11-24 15:44:51 +02:00
Rémi Verschelde
1ba920fada
Merge pull request #85308 from YuriSizov/editor-fix-animation-backup-copy-crash
Fix a crash when trying to restore uncopyable animation tracks
2023-11-24 14:43:04 +01:00
Yuri Sizov
671c04f89f Fix a crash when trying to restore uncopyable animation tracks 2023-11-24 14:20:30 +01:00
Rémi Verschelde
d6a1db2b07
Merge pull request #85302 from RandomShaper/copy_constr_avb
Perform safe copies in `AnimatedValuesBackup::get_cache_copy()`
2023-11-24 11:56:18 +01:00
Rémi Verschelde
8d43168fd7
Merge pull request #85279 from RandomShaper/enhance_change_scene_docs
Enhance `SceneTree.change_scene*()` methods' docs
2023-11-24 11:56:11 +01:00
Pedro J. Estébanez
fbb931df8c Perform safe copies in AnimatedValuesBackup::get_cache_copy() 2023-11-24 11:38:59 +01:00
Pedro J. Estébanez
ab01dc5a48 Enhance SceneTree.change_scene*() methods' docs 2023-11-24 11:25:21 +01:00
Rémi Verschelde
066e7d483a
Merge pull request #85284 from Sauermann/fix-enter-hide
Fix crash when hiding a Control during mouse-entering
2023-11-24 00:01:15 +01:00
Rémi Verschelde
4247244071
Merge pull request #85280 from bruvzg/custom_call_read_after_free
Prevent read-after-free in the queued CallableCustomStaticMethodPointer.
2023-11-24 00:00:52 +01:00
Rémi Verschelde
e6c8d40d10
Merge pull request #85266 from KoBeWi/copy_more_RAM
Fix TrackCache memory crash
2023-11-24 00:00:23 +01:00
Markus Sauermann
3de9afc4a9 Fix crash when hiding a Control during mouse-entering
gui.mouse_over can be set to `nullptr` in the `NOTIFICATION_MOUSE_ENTER`-
user-callback a few lines above. This case was previously not handled.
2023-11-23 23:25:00 +01:00
Rémi Verschelde
ce3bac5f55
Merge pull request #85249 from clayjohn/SUT-cleanup
Suppress surface upgrade warnings when showing SurfaceUpgradeTool warning
2023-11-23 22:57:53 +01:00
Rémi Verschelde
070ac8dfcd
Merge pull request #85248 from RandomShaper/fix_gdlamb_doublefree_2
Fix lambda cross-thread dynamics (take 2)
2023-11-23 22:57:25 +01:00
bruvzg
eb81e8b2dc
Prevent read-after-free in the queued CallableCustomStaticMethodPointer. 2023-11-23 23:22:08 +02:00
kobewi
1c0a0f5fdd Fix TrackCache memory crash 2023-11-23 20:26:03 +01:00
Pedro J. Estébanez
bfe66ab7cd Fixup thread-owned lambda bookkeeping on thread exit (take 2) 2023-11-23 18:50:20 +01:00
Yuri Sizov
bc1949d797 Correctly check scripts that must inherit EditorPlugin
Also updates some error messages related to this kind of check
across the codebase.
2023-11-23 16:24:43 +01:00
Rémi Verschelde
bb63963486
Merge pull request #85254 from TokageItLab/bind-reset-animedit
Bind `_reset`/`_restore` in AnimationMixer
2023-11-23 15:35:15 +01:00
Rémi Verschelde
1524972aa5
Merge pull request #85221 from TokageItLab/clear-seek-flg
Clear seeked/started flag after seeking/advancing in AnimationPlayer
2023-11-23 15:34:46 +01:00
Hugo Locurcio
70959a9c04
Fix typo in BaseMaterial3D conversion from 3.x SpatialMaterial 2023-11-23 15:18:03 +01:00
Silc Lizard (Tokage) Renew
f66224dd2d Bind _reset/_restore in AnimationMixer 2023-11-23 22:47:52 +09:00
QbieShay
a879e59581 Fixed radial inwards velocity clamping incorrectly (regression from 83488) 2023-11-23 10:32:56 +01:00
smix8
6fdb16af47 Fix NavigationRegion2D transform update
Fixes NavigationRegion2D transform update.
2023-11-23 07:23:20 +01:00
clayjohn
549a83eee2 Suppress surface upgrade warnings when showing SurfaceUpgradeTool warning
Also ensure the EditorProgress dialogue shows correct numbers
2023-11-22 15:35:50 -07:00
Rémi Verschelde
fa4a65387e
Merge pull request #85227 from KoBeWi/when_two_IDs_fight_the_editor_suffers
Fix crash caused by conflicting menu option IDs
2023-11-22 21:57:14 +01:00
Rémi Verschelde
ee14dc6ce5
Merge pull request #85222 from YuriSizov/lord-have-mercy
Rework the surface upgrade tool to inform users without blocking
2023-11-22 21:56:50 +01:00
Rémi Verschelde
bd74d92ef7
Merge pull request #84957 from BastiaanOlij/fix_msaa2d_when_no_2d
Ensure 2D MSAA resolve is performed when 3D content but no 2D content in scene
2023-11-22 21:56:23 +01:00
Pedro J. Estébanez
f26328e9a3 Revert recently added approach to cross-thread lambda survival
Commits reverted:
- 1ed6919148
- 271511726b
2023-11-22 20:07:01 +01:00
Yuri Sizov
10b70e2498 Rework the surface upgrade tool to inform users without blocking
This removes the immediate confirmation dialog and insteads prints the
message to the editor log (and it also appears as a toast). The immediate dialog
is a devil's plaything, and it cannot be used in this scenario (if it can be used
anywhere at all). The condition that triggers the SUT can happen during any
attempt by the rendering server to read a mesh. This means it will conflict
with a number of editor processes, like loading, importing, preview
generation, export, CLI mode, etc.

So while this is less on the nose as far as informing users goes, it's also
our best option to use the log and the toaster.
2023-11-22 19:03:14 +01:00