Commit Graph

60764 Commits

Author SHA1 Message Date
Dalton Lang
8a2e4409e6 [X11] Partial Fix Godot Editor and Project Manager steals focus on a window manager on Linux
This is a workaround for the most critical portion of the WM focus bug
described in #68305. On some specific X11 WM configurations, the
editor's main window and any popups it creates will fight for focus,
which causes a total system lockup due to mouse and keyboard input being
stolen as well. Getting out of this infinite loop requires force
restarting the system.

It can be tested with the following shell script:

```bash
	!#/bin/sh

	godot4 &
	sleep 30
	pkill -x godot4
```

The workaround identified in #68305 is to remove the call to
XSetInputFocus in the ConfigureNotify event handler, so I have removed
the conditional block that calls this as well as the setup code above it
since there is no need to allocate the memory for the variables if they
won't be used in that call anymore.

This is just a hack and is not a complete fix for #68305. Multiple
developers are collaborating on a proper fix in the discussion in that
issue, but time is a valuable resource that no one has enough of, so I
am committing this workaround as a stop-gap to prevent the most critical
problem while we work on a full solution for the underlying cause.
2024-02-05 17:00:24 -06:00
Rémi Verschelde
d3352813ea
Merge pull request #87981 from adamscott/add-emscripten--sgl_enable_get_proc_address-linker-flag
Fix emscripten 3.1.51 breaking change about `*glGetProcAddress()`
2024-02-05 18:06:15 +01:00
Rémi Verschelde
9a63aeda79
Merge pull request #87980 from KoBeWi/this_history_is_now…_history
Check if history exists before discarding
2024-02-05 18:05:52 +01:00
Rémi Verschelde
843c350cca
Merge pull request #87956 from adamscott/fix-emscripten-lto-build
Add workaround for emscripten >= 3.1.47 LTO build
2024-02-05 18:05:26 +01:00
Adam Scott
5922ac0fb1
Fix emscripten 3.1.51 breaking change about *glGetProcAddress() 2024-02-05 11:55:03 -05:00
kobewi
808f4e8cb9 Check if history exists before discarding 2024-02-05 17:42:37 +01:00
Rémi Verschelde
f427d2f0d3
Merge pull request #87976 from AThousandShips/black_hole
Fix crash with `PhysicsBody2D/3D::get_gravity` with invalid state
2024-02-05 17:22:54 +01:00
Rémi Verschelde
f8f2c8c85a
Merge pull request #87814 from bruvzg/memalign
[Core] Improve `CowData` and `Memory` metadata alignment.
2024-02-05 17:10:52 +01:00
A Thousand Ships
fb1662b939
Fix crash with PhysicsBody2D/3D::get_gravity with invalid state 2024-02-05 16:40:49 +01:00
bruvzg
7bcb419149
[Core] Improve CowData and Memory metadata alignment. 2024-02-05 17:30:02 +02:00
Rémi Verschelde
63d6bda8e9
Merge pull request #87871 from vittorioromeo/use_v_shorthand
Use `_v` shorthand for type traits and `if constexpr` where appropriate
2024-02-05 15:00:23 +01:00
Rémi Verschelde
6f2adcd63c
Merge pull request #87960 from bruvzg/mvk_ver_chk
[macOS] Check Vulkan SDK version when looking for MoltenVK libs.
2024-02-05 14:54:56 +01:00
Rémi Verschelde
01fd96e19d
Merge pull request #87951 from AThousandShips/doc_link_fix
Fix inverted link in docs
2024-02-05 14:54:33 +01:00
Rémi Verschelde
710c56e6b1
Merge pull request #87948 from ryevdokimov/always-default-to-region-select
Fix new region select with selection when over geometry
2024-02-05 14:54:10 +01:00
Rémi Verschelde
43a8351263
Merge pull request #87943 from 0x0ACB/tree_recursion
Only recurse depth wise in `Tree::_count_selected_items`
2024-02-05 14:53:46 +01:00
Rémi Verschelde
2f9ea3a505
Merge pull request #87941 from AThousandShips/num_fix
[GDScript] Prevent running `String` number functions on invalid literal
2024-02-05 14:53:23 +01:00
Rémi Verschelde
f4f1398503
Merge pull request #87938 from tishin/fix-gdextension-deinit
Add null check for GDExtension deinitialization
2024-02-05 14:53:00 +01:00
Rémi Verschelde
3eb25dd728
Merge pull request #87933 from aaronfranke/fix-gltf-crash-root-skel-imp
Fix crash when importing a GLTF file with a skeleton as the root
2024-02-05 14:52:37 +01:00
Rémi Verschelde
8631f68509
Merge pull request #87928 from 31/dev/31/call-deferred-cs
Add `Callable` `call_deferred()` C# example
2024-02-05 14:52:14 +01:00
Rémi Verschelde
64cee8a99f
Merge pull request #87922 from ryevdokimov/all-tools-can-select-regression-2
Fix a regression when multiple nodes are selected and drag transform is attempted w/o gizmo
2024-02-05 14:51:48 +01:00
Rémi Verschelde
79539cb886
Merge pull request #87893 from vittorioromeo/extract_safe_binary_mutex
Extract `SafeBinaryMutex` to separate header
2024-02-05 14:51:25 +01:00
Rémi Verschelde
fbd203401b
Merge pull request #87881 from smix8/height_min_max_helpers
Add HeightMapShape3D functions to get min / max height
2024-02-05 14:51:02 +01:00
Rémi Verschelde
c23cc08b1c
Merge pull request #87880 from kitbdev/fix-textedit-freeze
Fix freeze in TextEdit with `scroll_past_end_of_file` and `fit_content_height`
2024-02-05 14:50:33 +01:00
Rémi Verschelde
45e9d20d60
Merge pull request #87834 from TokageItLab/remove-dupecall-scene-tree-dock
Remove duplicated callings `set()` from SceneTreeDock
2024-02-05 14:50:09 +01:00
Rémi Verschelde
474d9b7e2e
Merge pull request #87771 from jsjtxietian/region-mismatch
Fix `TextureRegionEditor::_pan_callback` deferred called with only one argument
2024-02-05 14:49:45 +01:00
Rémi Verschelde
07655a0e11
Merge pull request #87623 from Calinou/editor-scene-drag-and-drop-tweak-modifier
Change scene drag-and-drop modifier behavior in the 2D and 3D editors
2024-02-05 14:49:21 +01:00
Rémi Verschelde
e096be85c4
Merge pull request #87125 from ryevdokimov/fix-removing-preview-nodes-on-ui-cancel
Clear drag preview nodes on `NOTIFICATION_DRAG_END`
2024-02-05 14:48:56 +01:00
Rémi Verschelde
acde2a81ff
Merge pull request #84640 from aaronfranke/gravity-get
Expose a method to get gravity for any physics body
2024-02-05 14:48:31 +01:00
bruvzg
70e328385c
[macOS] Check Vulkan SDK version when looking for MoltenVK libs. 2024-02-04 23:09:52 +02:00
Adam Scott
656bc22e28
Add workaround for emscripten >= 3.1.47 LTO build 2024-02-04 15:24:24 -05:00
Robert Yevdokimov
6718a9e4cf Fix bug that translates node during region select over geometry by always defaulting to region select 2024-02-04 13:34:18 -05:00
A Thousand Ships
17000bf8c3
Fix inverted link in docs
Title and url were swapped
2024-02-04 18:31:09 +01:00
vittorioromeo
71e0082ab0 Extract 'SafeBinaryMutex' to separate header
This change simply extracts 'SafeBinaryMutex' from 'mutex.h' to
    'safe_binary_mutex.h', in an effort to reduce the compilation
    speed impact of including `mutex.h`.
2024-02-04 16:59:54 +01:00
Mikhail Tishin
dc4c6cfb9b Add null check for gdextension deinitialization 2024-02-04 18:38:59 +03:00
A Thousand Ships
66d55e62f0
[GDScript] Prevent running String number functions on invalid literal
Prevents printing excessive errors.
2024-02-04 14:35:22 +01:00
ACB
43038bbfcb Only recurse depth wise in Tree::_count_selected_items 2024-02-04 14:21:03 +01:00
Aaron Franke
4c8d69f264
Fix crash when importing a GLTF file with a skeleton as the root 2024-02-04 02:48:16 -06:00
31
0a9715d6b5 Add Callable call_deferred() C# example 2024-02-03 20:49:05 -08:00
jsjtxietian
d06c526fb0 Fix TextureRegionEditor::_pan_callback deferred called with only one arg 2024-02-04 12:10:05 +08:00
Robert Yevdokimov
677bd9783a Fix a regression when multiple nodes are selected. and drag transform is attempted w/o gizmo 2024-02-03 21:45:08 -05:00
smix8
0a485fc30a Add HeightMapShape3D functions to get min / max height
Adds HeightMapShape3D functions to get min / max height.
2024-02-04 01:23:30 +01:00
Robert Yevdokimov
7a2c386e28 Clear drag preview nodes on NOTIFICATION_DRAG_END 2024-02-03 18:50:33 -05:00
Rémi Verschelde
b4e2a24c1f
Merge pull request #87915 from dalexeev/editor-fix-parse-category-for-custom-categories
Editor: Fix `_parse_category()` is not called for custom categories
2024-02-03 23:23:21 +01:00
Rémi Verschelde
c341d9704c
Merge pull request #87913 from OverloadedOrama/docs-feature-native-dialog
Minor fix in DisplayServer docs to include Linux & Windows in `FEATURE_NATIVE_DIALOG`
2024-02-03 23:22:58 +01:00
Rémi Verschelde
c680c7cffe
Merge pull request #87912 from bruvzg/menu_name_set_fix
[macOS] Fix changing main menu item names.
2024-02-03 23:22:35 +01:00
Rémi Verschelde
a72789c9d6
Merge pull request #87907 from adamscott/fix-window-override-settings
Fix `display/window/size/window_{width,height}_override` to permit `0`
2024-02-03 23:22:11 +01:00
Rémi Verschelde
21d336d69d
Merge pull request #87903 from AThousandShips/collide_fix
Fix `max_collisions` not being passed in `PhysicsBody3D::test_move`
2024-02-03 23:21:47 +01:00
Rémi Verschelde
f69aa5e649
Merge pull request #87887 from jtakakura/fix-unintentional-translation-in-animation-tree
Fix unintentional translations in AnimationTree
2024-02-03 23:21:24 +01:00
Rémi Verschelde
217597371e
Merge pull request #87878 from adamscott/emacs-gitignore
Add basic Emacs `.gitignore` entries
2024-02-03 23:21:01 +01:00
Rémi Verschelde
cfc9a9f50b
Merge pull request #87869 from capnm/240202_thorvg_from_v0.12.3_to_0.12.4
ThorVG: update from v0.12.3 to v0.12.4
2024-02-03 23:20:37 +01:00