mirror/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2024-12-27 11:24:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

Checking path variable if empty before opening external editor to fix #71528

Browse Source
This commit is contained in:
Christoh Prenissl 2023-01-16 22:32:23 +01:00 committed by Christoph Prenissl
parent 0ddd9c3e8f
commit 85aa03baaf
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
editor/plugins/script_editor_plugin.cpp
View File

@ -2256,11 +2256,14 @@ bool ScriptEditor::edit(const Ref<Resource> &p_resource, int p_line, int p_col,
args.push_back(script_path);
}
Error err = OS::get_singleton()->create_process(path, args);
if (err == OK) {
return false;
if (!path.is_empty()) {
Error err = OS::get_singleton()->create_process(path, args);
if (err == OK) {
return false;
}
}
WARN_PRINT("Couldn't open external text editor, using internal");
ERR_PRINT("Couldn't open external text editor, falling back to the internal editor. Review your `text_editor/external/` editor settings.");
}
for (int i = 0; i < tab_container->get_tab_count(); i++) {