Merge pull request #98597 from timothyqiu/on-your-lawn

Fix heap-use-after-free when ctrl-clicking controls in a container
This commit is contained in:
Thaddeus Crews 2024-10-29 19:25:44 -05:00
commit 6b70a6197f
No known key found for this signature in database
GPG Key ID: 62181B86FE9E5D84

View File

@ -1464,10 +1464,12 @@ bool CanvasItemEditor::_gui_input_rotate(const Ref<InputEvent> &p_event) {
List<CanvasItem *> selection = _get_edited_canvas_items(false, true, &has_locked_items);
// Remove not movable nodes
for (CanvasItem *E : selection) {
if (!_is_node_movable(E, true)) {
for (List<CanvasItem *>::Element *E = selection.front(); E;) {
List<CanvasItem *>::Element *N = E->next();
if (!_is_node_movable(E->get(), true)) {
selection.erase(E);
}
E = N;
}
drag_selection = selection;