display of large help text in visual script

implemented vertical scroller for help text in popup
disabled broken positioning code
This commit is contained in:
derammo 2022-05-13 21:11:41 -04:00
parent 35596e6b74
commit 5a481bd340
2 changed files with 10 additions and 10 deletions

View File

@ -1959,15 +1959,6 @@ void VisualScriptEditor::_generic_search(Vector2 pos, bool node_centered) {
} }
new_connect_node_select->select_from_visual_script(script, false); // do not reset text new_connect_node_select->select_from_visual_script(script, false); // do not reset text
// Ensure that the dialog fits inside the graph.
Size2 bounds = graph->get_global_position() + graph->get_size() - new_connect_node_select->get_size();
pos.x = pos.x > bounds.x ? bounds.x : pos.x;
pos.y = pos.y > bounds.y ? bounds.y : pos.y;
if (pos != Vector2()) {
new_connect_node_select->set_position(pos);
}
} }
void VisualScriptEditor::input(const Ref<InputEvent> &p_event) { void VisualScriptEditor::input(const Ref<InputEvent> &p_event) {

View File

@ -521,8 +521,17 @@ VisualScriptPropertySelector::VisualScriptPropertySelector() {
results_tree->connect("item_selected", callable_mp(this, &VisualScriptPropertySelector::_item_selected)); results_tree->connect("item_selected", callable_mp(this, &VisualScriptPropertySelector::_item_selected));
vbox->add_child(results_tree); vbox->add_child(results_tree);
ScrollContainer *scroller = memnew(ScrollContainer);
scroller->set_horizontal_scroll_mode(ScrollContainer::SCROLL_MODE_DISABLED);
scroller->set_v_size_flags(Control::SIZE_EXPAND_FILL);
scroller->set_custom_minimum_size(Size2(600, 400) * EDSCALE);
vbox->add_child(scroller);
help_bit = memnew(EditorHelpBit); help_bit = memnew(EditorHelpBit);
vbox->add_child(help_bit); help_bit->set_h_size_flags(Control::SIZE_EXPAND_FILL);
help_bit->set_v_size_flags(Control::SIZE_EXPAND_FILL);
scroller->add_child(help_bit);
help_bit->connect("request_hide", callable_mp(this, &VisualScriptPropertySelector::_hide_requested)); help_bit->connect("request_hide", callable_mp(this, &VisualScriptPropertySelector::_hide_requested));
get_ok_button()->set_text(TTR("Open")); get_ok_button()->set_text(TTR("Open"));
get_ok_button()->set_disabled(true); get_ok_button()->set_disabled(true);