From 2e5cf62dee5d79617d202d791ac40344b07d10fb Mon Sep 17 00:00:00 2001 From: Raul Santos Date: Mon, 1 Aug 2022 04:37:07 +0200 Subject: [PATCH] Fix `Vector4::min_axis_index` for equal components The documentation says if all components are equal it must return AXIS_W but it was returning AXIS_X. --- core/math/vector4.cpp | 2 +- core/math/vector4i.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/core/math/vector4.cpp b/core/math/vector4.cpp index ed42d8bfb96..cc0d0dcf726 100644 --- a/core/math/vector4.cpp +++ b/core/math/vector4.cpp @@ -89,7 +89,7 @@ Vector4::Axis Vector4::min_axis_index() const { uint32_t min_index = 0; real_t min_value = x; for (uint32_t i = 1; i < 4; i++) { - if (operator[](i) < min_value) { + if (operator[](i) <= min_value) { min_index = i; min_value = operator[](i); } diff --git a/core/math/vector4i.cpp b/core/math/vector4i.cpp index 8c571b02e3a..2dc5b742026 100644 --- a/core/math/vector4i.cpp +++ b/core/math/vector4i.cpp @@ -47,7 +47,7 @@ Vector4i::Axis Vector4i::min_axis_index() const { uint32_t min_index = 0; int32_t min_value = x; for (uint32_t i = 1; i < 4; i++) { - if (operator[](i) < min_value) { + if (operator[](i) <= min_value) { min_index = i; min_value = operator[](i); }