mirror/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-02-17 22:43:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #80467 from aaronfranke/mesh-lod-limit

Browse Source 
Limit mesh complexity in LOD generation to prevent crashing
This commit is contained in:
Rémi Verschelde 2023-09-21 14:24:54 +02:00
commit 184e603c99
No known key found for this signature in database
GPG Key ID: C3336907360768E1
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
scene/resources/importer_mesh.cpp
View File

@ -475,6 +475,14 @@ void ImporterMesh::generate_lods(float p_normal_merge_angle, float p_normal_spli
if (new_index_count == 0 || (new_index_count >= (index_count * 0.75f))) {
break;
}
if (new_index_count > 5000000) {
// This limit theoretically shouldn't be needed, but it's here
// as an ad-hoc fix to prevent a crash with complex meshes.
// The crash still happens with limit of 6000000, but 5000000 works.
// In the future, identify what's causing that crash and fix it.
WARN_PRINT("Mesh LOD generation failed for mesh " + get_name() + " surface " + itos(i) + ", mesh is too complex. Some automatic LODs were not generated.");
break;
}
new_indices.resize(new_index_count);