mirror/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-02-23 23:15:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #66590 from akien-mga/animation-workaround-disable-onion-skinning

Browse Source 
Animation editor: Disable onion skinning temporarily due to rendering bug
This commit is contained in:
Rémi Verschelde 2022-09-29 15:34:02 +02:00
commit 176da47ffd
2 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
editor/plugins/animation_player_editor_plugin.cpp
View File

@ -874,6 +874,11 @@ void AnimationPlayerEditor::_update_player() {
onion_toggle->set_disabled(no_anims_found); onion_toggle->set_disabled(no_anims_found);
onion_skinning->set_disabled(no_anims_found); onion_skinning->set_disabled(no_anims_found);
if (hack_disable_onion_skinning) {
onion_toggle->set_disabled(true);
onion_skinning->set_disabled(true);
}
_update_animation_list_icons(); _update_animation_list_icons();
updating = false; updating = false;
@ -1678,6 +1683,16 @@ AnimationPlayerEditor::AnimationPlayerEditor(AnimationPlayerEditorPlugin *p_plug
onion_skinning->get_popup()->add_check_item(TTR("Include Gizmos (3D)"), ONION_SKINNING_INCLUDE_GIZMOS); onion_skinning->get_popup()->add_check_item(TTR("Include Gizmos (3D)"), ONION_SKINNING_INCLUDE_GIZMOS);
hb->add_child(onion_skinning); hb->add_child(onion_skinning);
// FIXME: Onion skinning disabled for now as it's broken and triggers fast
// flickering red/blue modulation (GH-53870).
if (hack_disable_onion_skinning) {
onion_toggle->set_disabled(true);
onion_toggle->set_tooltip_text(TTR("Onion Skinning temporarily disabled due to rendering bug."));
onion_skinning->set_disabled(true);
onion_skinning->set_tooltip_text(TTR("Onion Skinning temporarily disabled due to rendering bug."));
}
hb->add_child(memnew(VSeparator)); hb->add_child(memnew(VSeparator));
pin = memnew(Button); pin = memnew(Button);

2
editor/plugins/animation_player_editor_plugin.h
View File

@ -131,6 +131,8 @@ class AnimationPlayerEditor : public VBoxContainer {
AnimationTrackEditor *track_editor = nullptr; AnimationTrackEditor *track_editor = nullptr;
static AnimationPlayerEditor *singleton; static AnimationPlayerEditor *singleton;
bool hack_disable_onion_skinning = true; // Temporary hack for GH-53870.
// Onion skinning. // Onion skinning.
struct { struct {
// Settings. // Settings.