From 48db6669f63eb148e952de75ba535de8894c18d8 Mon Sep 17 00:00:00 2001 From: Haoyu Qiu Date: Sun, 22 Sep 2024 00:22:33 +0800 Subject: [PATCH] Fix crash when using non-PackedScene resource for POT generation --- editor/plugins/packed_scene_translation_parser_plugin.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/editor/plugins/packed_scene_translation_parser_plugin.cpp b/editor/plugins/packed_scene_translation_parser_plugin.cpp index b38965753e8..d8e6d3f2019 100644 --- a/editor/plugins/packed_scene_translation_parser_plugin.cpp +++ b/editor/plugins/packed_scene_translation_parser_plugin.cpp @@ -32,7 +32,6 @@ #include "core/io/resource_loader.h" #include "core/object/script_language.h" -#include "scene/gui/option_button.h" #include "scene/resources/packed_scene.h" void PackedSceneEditorTranslationParserPlugin::get_recognized_extensions(List *r_extensions) const { @@ -49,7 +48,9 @@ Error PackedSceneEditorTranslationParserPlugin::parse_file(const String &p_path, ERR_PRINT("Failed to load " + p_path); return err; } - Ref state = Ref(loaded_res)->get_state(); + Ref packed_scene = loaded_res; + ERR_FAIL_COND_V_MSG(packed_scene.is_null(), ERR_FILE_UNRECOGNIZED, vformat("'%s' is not a valid PackedScene resource.", p_path)); + Ref state = packed_scene->get_state(); Vector parsed_strings; Vector> atr_owners;