mirror/godot
2
0
Fork 0
mirror of https://github.com/godotengine/godot.git synced 2025-04-01 00:41:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #62692 from Nolkaloid/typesafe-nodepath-dnd

Browse Source 
Fix drag'n drop type checking for NodePaths
This commit is contained in:
Rémi Verschelde 2022-07-04 23:54:06 +02:00 committed by GitHub
commit 100d223736
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
editor/editor_properties.cpp
View File

@ -3175,7 +3175,20 @@ bool EditorPropertyNodePath::is_drop_valid(const Dictionary &p_drag_data) const
return false;
}
Array nodes = p_drag_data["nodes"];
return nodes.size() == 1;
if (nodes.size() != 1) {
return false;
}
Node *dropped_node = get_tree()->get_edited_scene_root()->get_node(nodes[0]);
ERR_FAIL_NULL_V(dropped_node, false);
for (const StringName &E : valid_types) {
if (dropped_node->is_class(E)) {
return true;
}
}
return false;
}
void EditorPropertyNodePath::update_property() {